[PATCH] RISCV:Kernel: Cleanup RISCV Kernel header files

[PATCH] RISCV:Kernel: Cleanup RISCV Kernel header files

[G SatishKumar]

	This patch cleanup unnecessary haeder files
	from RISCV kernel files

Signed-off-by: G SatishKumar <gsatish.ldd@gmail.com>
---
 arch/riscv/kernel/cacheinfo.c | 1 -
 arch/riscv/kernel/cpu.c       | 1 -
 arch/riscv/kernel/irq.c       | 2 --
 3 files changed, 4 deletions(-)

diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
index cb35ffd..0e710fc 100644
--- a/arch/riscv/kernel/cacheinfo.c
+++ b/arch/riscv/kernel/cacheinfo.c
@@ -13,7 +13,6 @@
 
 #include <linux/cacheinfo.h>
 #include <linux/cpu.h>
-#include <linux/of.h>
 #include <linux/of_device.h>
 
 static void ci_leaf_init(struct cacheinfo *this_leaf,
diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c
index b4a7d44..f3f4690 100644
--- a/arch/riscv/kernel/cpu.c
+++ b/arch/riscv/kernel/cpu.c
@@ -13,7 +13,6 @@
 
 #include <linux/init.h>
 #include <linux/seq_file.h>
-#include <linux/of.h>
 #include <asm/smp.h>
 
 /*
diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c
index 48e6b7d..1d76b60 100644
--- a/arch/riscv/kernel/irq.c
+++ b/arch/riscv/kernel/irq.c
@@ -7,9 +7,7 @@
 
 #include <linux/interrupt.h>
 #include <linux/irqchip.h>
-#include <linux/irqdomain.h>
 #include <linux/seq_file.h>
-#include <asm/smp.h>
 
 /*
  * Possible interrupt causes:
-- 
2.7.4


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] RISCV:Kernel: Cleanup RISCV Kernel header files

[Paul Walmsley]

On Wed, 2 Jan 2019, G SatishKumar wrote:

> 	This patch cleanup unnecessary haeder files
> 	from RISCV kernel files
> 
> Signed-off-by: G SatishKumar <gsatish.ldd@gmail.com>

When applied on top of upstream commit 7b5585136713, the build 
fails with errors similar to the following:

arch/riscv/kernel/cpu.c: In function 'riscv_of_processor_hartid':
arch/riscv/kernel/cpu.c:27:7: error: implicit declaration of function 
'of_device_is_compatible'; did you mean 'file_ns_capable'? 
[-Werror=implicit-function-declaration]
  if (!of_device_is_compatible(node, "riscv")) {
       ^~~~~~~~~~~~~~~~~~~~~~~
       file_ns_capable
arch/riscv/kernel/cpu.c:32:6: error: implicit declaration of function 
'of_property_read_u32' [-Werror=implicit-function-declaration]
  if (of_property_read_u32(node, "reg", &hart)) {
      ^~~~~~~~~~~~~~~~~~~~

etc.

- Paul


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv