linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2 1/6] mm: Introduce common STRUCT_PAGE_MAX_SHIFT define
Date: Mon, 29 Oct 2018 17:53:04 +0000	[thread overview]
Message-ID: <20181029175303.GB16739@arm.com> (raw)
In-Reply-To: <20181015175702.9036-2-logang@deltatee.com>

Hi Logan,

On Mon, Oct 15, 2018 at 11:56:57AM -0600, Logan Gunthorpe wrote:
> This define is used by arm64 to calculate the size of the vmemmap
> region. It is defined as the log2 of the upper bound on the size
> of a struct page.
> 
> We move it into mm_types.h so it can be defined properly instead of
> set and checked with a build bug. This also allows us to use the same
> define for riscv.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Christoph Hellwig <hch@lst.de>
> ---
>  arch/arm64/include/asm/memory.h | 9 ---------
>  arch/arm64/mm/init.c            | 8 --------
>  include/asm-generic/fixmap.h    | 1 +
>  include/linux/mm_types.h        | 5 +++++
>  4 files changed, 6 insertions(+), 17 deletions(-)

This looks like a really good cleanup to me, thanks:

Acked-by: Will Deacon <will.deacon@arm.com>

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-sh@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	linux-kernel@vger.kernel.org, Stephen Bates <sbates@raithlin.com>,
	linux-mm@kvack.org, linux-riscv@lists.infradead.org,
	Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] mm: Introduce common STRUCT_PAGE_MAX_SHIFT define
Date: Mon, 29 Oct 2018 17:53:04 +0000	[thread overview]
Message-ID: <20181029175303.GB16739@arm.com> (raw)
Message-ID: <20181029175304.AuctVLVfP7cIWL_8M2q8nJL1ay8bXfPX1nilR_v5RCU@z> (raw)
In-Reply-To: <20181015175702.9036-2-logang@deltatee.com>

Hi Logan,

On Mon, Oct 15, 2018 at 11:56:57AM -0600, Logan Gunthorpe wrote:
> This define is used by arm64 to calculate the size of the vmemmap
> region. It is defined as the log2 of the upper bound on the size
> of a struct page.
> 
> We move it into mm_types.h so it can be defined properly instead of
> set and checked with a build bug. This also allows us to use the same
> define for riscv.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Christoph Hellwig <hch@lst.de>
> ---
>  arch/arm64/include/asm/memory.h | 9 ---------
>  arch/arm64/mm/init.c            | 8 --------
>  include/asm-generic/fixmap.h    | 1 +
>  include/linux/mm_types.h        | 5 +++++
>  4 files changed, 6 insertions(+), 17 deletions(-)

This looks like a really good cleanup to me, thanks:

Acked-by: Will Deacon <will.deacon@arm.com>

Will

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2018-10-29 17:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 17:56 [PATCH v2 0/6] sparsemem support for RISC-V Logan Gunthorpe
2018-10-15 17:56 ` Logan Gunthorpe
2018-10-15 17:56 ` [PATCH v2 1/6] mm: Introduce common STRUCT_PAGE_MAX_SHIFT define Logan Gunthorpe
2018-10-15 17:56   ` Logan Gunthorpe
2018-10-29 17:53   ` Will Deacon [this message]
2018-10-29 17:53     ` Will Deacon
2018-10-15 17:56 ` [PATCH v2 2/6] mm/sparse: add common helper to mark all memblocks present Logan Gunthorpe
2018-10-15 17:56   ` Logan Gunthorpe
2018-10-15 17:56 ` [PATCH v2 3/6] ARM: mm: make use of new memblocks_present() helper Logan Gunthorpe
2018-10-15 17:56   ` Logan Gunthorpe
2018-10-15 17:57 ` [PATCH v2 4/6] arm64: " Logan Gunthorpe
2018-10-15 17:57   ` Logan Gunthorpe
2018-10-15 17:57 ` [PATCH v2 5/6] sh: " Logan Gunthorpe
2018-10-15 17:57   ` Logan Gunthorpe
2018-10-15 17:57 ` [PATCH v2 6/6] RISC-V: Implement sparsemem Logan Gunthorpe
2018-10-15 17:57   ` Logan Gunthorpe
2018-12-17 14:59   ` Nick Kossifidis
2018-12-17 16:50     ` Logan Gunthorpe
2018-10-16  0:04 ` [PATCH v2 0/6] sparsemem support for RISC-V Palmer Dabbelt
2018-10-16  0:04   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029175303.GB16739@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).