From: olof@lixom.net (Olof Johansson) To: linux-riscv@lists.infradead.org Subject: [PATCH] riscv: perf: fix build warning Date: Sun, 25 Nov 2018 14:51:21 -0800 [thread overview] Message-ID: <20181125225121.4454-1-olof@lixom.net> (raw) Due to the -ENOENT return, the variables can't actually be used uninitialized, but the compiler isn't smart enough in this case. Let's just set them before returning with the error for now, it'll be filled in once implemented. arch/riscv/kernel/perf_event.c:166:5: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized] arch/riscv/kernel/perf_event.c:166:38: warning: 'op' may be used uninitialized in this function [-Wmaybe-uninitialized] arch/riscv/kernel/perf_event.c:167:39: warning: 'result' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Olof Johansson <olof@lixom.net> --- I swear I posted this exact fix just last week, but can't find a reference to it anywhere. arch/riscv/kernel/perf_event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/riscv/kernel/perf_event.c b/arch/riscv/kernel/perf_event.c index a243fae1c1dbb..81f3ba76f1dbc 100644 --- a/arch/riscv/kernel/perf_event.c +++ b/arch/riscv/kernel/perf_event.c @@ -150,6 +150,9 @@ static int riscv_map_hw_event(u64 config) int riscv_map_cache_decode(u64 config, unsigned int *type, unsigned int *op, unsigned int *result) { + *type = 0; + *op = 0; + *result = 0; return -ENOENT; } -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net> To: Palmer Dabbelt <palmer@sifive.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Olof Johansson <olof@lixom.net>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] riscv: perf: fix build warning Date: Sun, 25 Nov 2018 14:51:21 -0800 [thread overview] Message-ID: <20181125225121.4454-1-olof@lixom.net> (raw) Message-ID: <20181125225121.s9kjjNTRjyDonvB4nwc82Rvh28Au1214BriVgQNBsFE@z> (raw) Due to the -ENOENT return, the variables can't actually be used uninitialized, but the compiler isn't smart enough in this case. Let's just set them before returning with the error for now, it'll be filled in once implemented. arch/riscv/kernel/perf_event.c:166:5: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized] arch/riscv/kernel/perf_event.c:166:38: warning: 'op' may be used uninitialized in this function [-Wmaybe-uninitialized] arch/riscv/kernel/perf_event.c:167:39: warning: 'result' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Olof Johansson <olof@lixom.net> --- I swear I posted this exact fix just last week, but can't find a reference to it anywhere. arch/riscv/kernel/perf_event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/riscv/kernel/perf_event.c b/arch/riscv/kernel/perf_event.c index a243fae1c1dbb..81f3ba76f1dbc 100644 --- a/arch/riscv/kernel/perf_event.c +++ b/arch/riscv/kernel/perf_event.c @@ -150,6 +150,9 @@ static int riscv_map_hw_event(u64 config) int riscv_map_cache_decode(u64 config, unsigned int *type, unsigned int *op, unsigned int *result) { + *type = 0; + *op = 0; + *result = 0; return -ENOENT; } -- 2.11.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2018-11-25 22:51 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-25 22:51 Olof Johansson [this message] 2018-11-25 22:51 ` [PATCH] riscv: perf: fix build warning Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181125225121.4454-1-olof@lixom.net \ --to=olof@lixom.net \ --cc=linux-riscv@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).