* [PATCH v8 06/20] riscv: mm: Add p?d_large() definitions [not found] <20190403141627.11664-1-steven.price@arm.com> @ 2019-04-03 14:16 ` Steven Price 2019-04-05 4:14 ` Anup Patel 0 siblings, 1 reply; 2+ messages in thread From: Steven Price @ 2019-04-03 14:16 UTC (permalink / raw) To: linux-mm Cc: Mark Rutland, Peter Zijlstra, Catalin Marinas, Dave Hansen, Will Deacon, H. Peter Anvin, linux-riscv, Liang, Kan, x86, Steven Price, Ingo Molnar, Palmer Dabbelt, Albert Ou, Arnd Bergmann, Jérôme Glisse, Borislav Petkov, Andy Lutomirski, Thomas Gleixner, linux-arm-kernel, Ard Biesheuvel, linux-kernel, James Morse, Andrew Morton walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For riscv a page is large when it has a read, write or execute bit set on it. CC: Palmer Dabbelt <palmer@sifive.com> CC: Albert Ou <aou@eecs.berkeley.edu> CC: linux-riscv@lists.infradead.org Signed-off-by: Steven Price <steven.price@arm.com> --- arch/riscv/include/asm/pgtable-64.h | 7 +++++++ arch/riscv/include/asm/pgtable.h | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm/pgtable-64.h index 7aa0ea9bd8bb..73747d9d7c66 100644 --- a/arch/riscv/include/asm/pgtable-64.h +++ b/arch/riscv/include/asm/pgtable-64.h @@ -51,6 +51,13 @@ static inline int pud_bad(pud_t pud) return !pud_present(pud); } +#define pud_large pud_large +static inline int pud_large(pud_t pud) +{ + return pud_present(pud) + && (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); +} + static inline void set_pud(pud_t *pudp, pud_t pud) { *pudp = pud; diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index 1141364d990e..9570883c79e7 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -111,6 +111,13 @@ static inline int pmd_bad(pmd_t pmd) return !pmd_present(pmd); } +#define pmd_large pmd_large +static inline int pmd_large(pmd_t pmd) +{ + return pmd_present(pmd) + && (pmd_val(pmd) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); +} + static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) { *pmdp = pmd; -- 2.20.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v8 06/20] riscv: mm: Add p?d_large() definitions 2019-04-03 14:16 ` [PATCH v8 06/20] riscv: mm: Add p?d_large() definitions Steven Price @ 2019-04-05 4:14 ` Anup Patel 0 siblings, 0 replies; 2+ messages in thread From: Anup Patel @ 2019-04-05 4:14 UTC (permalink / raw) To: Steven Price Cc: Mark Rutland, Peter Zijlstra, Catalin Marinas, Dave Hansen, Will Deacon, linux-mm, H. Peter Anvin, linux-riscv, Liang, Kan, x86, Ingo Molnar, Palmer Dabbelt, Albert Ou, Arnd Bergmann, Jérôme Glisse, Borislav Petkov, Andy Lutomirski, Thomas Gleixner, linux-arm-kernel, Ard Biesheuvel, linux-kernel@vger.kernel.org List, James Morse, Andrew Morton On Wed, Apr 3, 2019 at 7:47 PM Steven Price <steven.price@arm.com> wrote: > > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_large() functions/macros. > > For riscv a page is large when it has a read, write or execute bit > set on it. > > CC: Palmer Dabbelt <palmer@sifive.com> > CC: Albert Ou <aou@eecs.berkeley.edu> > CC: linux-riscv@lists.infradead.org > Signed-off-by: Steven Price <steven.price@arm.com> > --- > arch/riscv/include/asm/pgtable-64.h | 7 +++++++ > arch/riscv/include/asm/pgtable.h | 7 +++++++ > 2 files changed, 14 insertions(+) > > diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm/pgtable-64.h > index 7aa0ea9bd8bb..73747d9d7c66 100644 > --- a/arch/riscv/include/asm/pgtable-64.h > +++ b/arch/riscv/include/asm/pgtable-64.h > @@ -51,6 +51,13 @@ static inline int pud_bad(pud_t pud) > return !pud_present(pud); > } > > +#define pud_large pud_large > +static inline int pud_large(pud_t pud) > +{ > + return pud_present(pud) > + && (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); > +} > + > static inline void set_pud(pud_t *pudp, pud_t pud) > { > *pudp = pud; > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index 1141364d990e..9570883c79e7 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -111,6 +111,13 @@ static inline int pmd_bad(pmd_t pmd) > return !pmd_present(pmd); > } > > +#define pmd_large pmd_large > +static inline int pmd_large(pmd_t pmd) > +{ > + return pmd_present(pmd) > + && (pmd_val(pmd) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); > +} > + > static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) > { > *pmdp = pmd; > -- > 2.20.1 > Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-05 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190403141627.11664-1-steven.price@arm.com>
2019-04-03 14:16 ` [PATCH v8 06/20] riscv: mm: Add p?d_large() definitions Steven Price
2019-04-05 4:14 ` Anup Patel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).