From: Borislav Petkov <bp@alien8.de>
To: Yash Shah <yash.shah@sifive.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
aou@eecs.berkeley.edu, palmer@sifive.com,
linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com,
robh+dt@kernel.org, james.morse@arm.com,
paul.walmsley@sifive.com, linux-riscv@lists.infradead.org,
mchehab@kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH 3/3] edac: sifive: Add EDAC platform driver for SiFive SoCs
Date: Thu, 18 Apr 2019 14:50:15 +0200 [thread overview]
Message-ID: <20190418125015.GI27160@zn.tnic> (raw)
In-Reply-To: <1555328443-30874-4-git-send-email-yash.shah@sifive.com>
On Mon, Apr 15, 2019 at 05:10:43PM +0530, Yash Shah wrote:
> This initial ver of EDAC driver supports:
> - ECC event monitoring and reporting through the EDAC framework for SiFive
> L2 cache controller.
>
> This driver registers for notifier events from the L2 cache controller
> driver (arch/riscv/mm/sifive_l2_cache.c) for L2 ECC events
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> arch/riscv/Kconfig | 1 +
> drivers/edac/Kconfig | 6 +++
> drivers/edac/Makefile | 1 +
> drivers/edac/sifive_edac.c | 121 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 129 insertions(+)
> create mode 100644 drivers/edac/sifive_edac.c
Please add a MAINTAINERS entry like the other EDAC drivers do so that
you can get CCed on patches/bug reports.
The rest looks ok to me.
I'd still like for James to have a look too, when he gets to it.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-04-18 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 11:40 [PATCH 0/3] L2 cache controller and EDAC support for SiFive SoCs Yash Shah
2019-04-15 11:40 ` [PATCH 1/3] RISC-V: Add DT documentation for SiFive L2 Cache Controller Yash Shah
2019-04-18 12:40 ` Borislav Petkov
2019-04-15 11:40 ` [PATCH 2/3] RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs Yash Shah
2019-04-15 11:40 ` [PATCH 3/3] edac: sifive: Add EDAC platform " Yash Shah
2019-04-18 12:50 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418125015.GI27160@zn.tnic \
--to=bp@alien8.de \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).