From: "hch@infradead.org" <hch@infradead.org>
To: Atish Patra <Atish.Patra@wdc.com>
Cc: "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"anup@brainfault.org" <anup@brainfault.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johan@kernel.org" <johan@kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.
Date: Sun, 18 Aug 2019 11:16:30 -0700 [thread overview]
Message-ID: <20190818181630.GA20217@infradead.org> (raw)
In-Reply-To: <3fb8d4f0383b005ecd932a69c4dd295a79b6fb1a.camel@wdc.com>
On Fri, Aug 16, 2019 at 07:21:52PM +0000, Atish Patra wrote:
> > > + if (isa[0] != '\0') {
> > > + /* Add remainging isa strings */
> > > + for (e = isa; *e != '\0'; ++e) {
> > > +#if !defined(CONFIG_VIRTUALIZATION)
> > > + if (e[0] != 'h')
> > > +#endif
> > > + seq_write(f, e, 1);
> > > + }
> > > + }
> >
> > This one I don't get. Why do we want to check CONFIG_VIRTUALIZATION?
> >
>
> If CONFIG_VIRTUALIZATION is not enabled, it shouldn't print that
> hypervisor extension "h" in isa extensions.
CONFIG_VIRTUALIZATION doesn't change anything in the kernels
capabilities, it just enables other config options. But more
importantly the 'h' extension is only relevant for S-mode software
anyway.
> This is just an information to the userspace that some of the mandatory
> ISA extensions ("mafdcsu") are not supported in kernel which may lead
> to undesirable results.
I think we need to sit down decide what the purpose of /proc/cpuinfo
is. IIRC on other architectures is just prints what the hardware
supports, not what you can actually make use of. How else would you
find out that you'd need to enable more kernel options to fully
utilize the hardware?
Also printing this warning to the kernel log when someone reads the
procfs file is very strange.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-18 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 18:23 [v5 PATCH] RISC-V: Fix unsupported isa string info Atish Patra
2019-08-12 15:02 ` Christoph Hellwig
2019-08-16 19:21 ` Atish Patra
2019-08-18 18:16 ` hch [this message]
2019-08-20 7:59 ` Atish Patra
2019-09-06 23:27 ` Atish Patra
2019-09-10 6:00 ` hch
2019-09-13 20:47 ` Palmer Dabbelt
2019-09-14 4:07 ` Atish Patra
2019-08-19 10:15 ` Jacob Lifshay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818181630.GA20217@infradead.org \
--to=hch@infradead.org \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).