From: Atish Patra <Atish.Patra@wdc.com>
To: "palmer@sifive.com" <palmer@sifive.com>,
"hch@infradead.org" <hch@infradead.org>
Cc: "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"anup@brainfault.org" <anup@brainfault.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johan@kernel.org" <johan@kernel.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.
Date: Sat, 14 Sep 2019 04:07:55 +0000 [thread overview]
Message-ID: <491aa3fb2d08e283ecedb5c02f9555d10f458ecb.camel@wdc.com> (raw)
In-Reply-To: <mhng-300d37d6-c3a0-461c-b843-ca9b0e2b4714@palmer-si-x1e>
On Fri, 2019-09-13 at 13:47 -0700, Palmer Dabbelt wrote:
> On Mon, 09 Sep 2019 23:00:10 PDT (-0700), Christoph Hellwig wrote:
> > On Fri, Sep 06, 2019 at 11:27:57PM +0000, Atish Patra wrote:
> > > > Agreed. May be something like this ?
> > > >
> > > > Let's say f/d is enabled in kernel but cpu doesn't support it.
> > > > "unsupported isa" will only appear if there are any unsupported
> > > > isa.
> > > >
> > > > processor : 3
> > > > hart : 4
> > > > isa : rv64imac
> > > > unsupported isa : fd
> > > > mmu : sv39
> > > > uarch : sifive,u54-mc
> > > >
> > > > May be I am just trying over optimize one corner case :) :).
> > > > /proc/cpuinfo should just print all the isa string. That's it.
> > > >
> > >
> > > Ping ?
> >
> > Yes, I agree with the "dumb" reporting of all capabilities.
>
> I agree: it looks like other architectures are passing info (ie, x86
> flags)
> that isn't supported by userspace. We have the ELF hwcap stuff for
> those who
> want to tell which instructions they can run, so it's sane to just
> keep this
> simple.
Great. That will simplify the code path as well. I will send a v6 with
the fixes.
--
Regards,
Atish
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-09-14 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 18:23 [v5 PATCH] RISC-V: Fix unsupported isa string info Atish Patra
2019-08-12 15:02 ` Christoph Hellwig
2019-08-16 19:21 ` Atish Patra
2019-08-18 18:16 ` hch
2019-08-20 7:59 ` Atish Patra
2019-09-06 23:27 ` Atish Patra
2019-09-10 6:00 ` hch
2019-09-13 20:47 ` Palmer Dabbelt
2019-09-14 4:07 ` Atish Patra [this message]
2019-08-19 10:15 ` Jacob Lifshay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491aa3fb2d08e283ecedb5c02f9555d10f458ecb.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).