* [PATCH bpf-next 0/4] Fix up bpf_jit_limit some more
@ 2021-09-24 9:55 Lorenz Bauer
2021-09-24 9:55 ` [PATCH bpf-next 1/4] bpf: define bpf_jit_alloc_exec_limit for riscv JIT Lorenz Bauer
0 siblings, 1 reply; 3+ messages in thread
From: Lorenz Bauer @ 2021-09-24 9:55 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexei Starovoitov,
Daniel Borkmann, Andrii Nakryiko
Cc: kernel-team, Lorenz Bauer, linux-riscv, netdev, bpf
Some more cleanups around bpf_jit_limit to make it readable via sysctl.
Things I'm not sure about:
* Is it OK to expose atomic_long_t bpf_jit_limit like this? The sysctl code
isn't atomic, but maybe it's fine because it's read only.
* All of the JIT related sysctls are quite restrictive, you have to have
CAP_SYS_ADMIN / CAP_BPF _and_ be root as well. This makes it problematic
to scrape these to expose them as metrics. Can we relax this somewhat?
Lorenz
Lorenz Bauer (4):
bpf: define bpf_jit_alloc_exec_limit for riscv JIT
bpf: define bpf_jit_alloc_exec_limit for arm64 JIT
bpf: prevent increasing bpf_jit_limit above max
bpf: export bpf_jit_current
arch/arm64/net/bpf_jit_comp.c | 5 +++++
arch/riscv/net/bpf_jit_core.c | 5 +++++
include/linux/filter.h | 2 ++
kernel/bpf/core.c | 7 ++++---
net/core/sysctl_net_core.c | 9 ++++++++-
5 files changed, 24 insertions(+), 4 deletions(-)
--
2.30.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH bpf-next 1/4] bpf: define bpf_jit_alloc_exec_limit for riscv JIT
2021-09-24 9:55 [PATCH bpf-next 0/4] Fix up bpf_jit_limit some more Lorenz Bauer
@ 2021-09-24 9:55 ` Lorenz Bauer
2021-09-24 15:28 ` Luke Nelson
0 siblings, 1 reply; 3+ messages in thread
From: Lorenz Bauer @ 2021-09-24 9:55 UTC (permalink / raw)
To: Luke Nelson, Xi Wang, Björn Töpel, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko
Cc: kernel-team, Lorenz Bauer, netdev, bpf, linux-riscv, linux-kernel
Expose the maximum amount of useable memory from the sparcv JIT.
Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
---
arch/riscv/net/bpf_jit_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/riscv/net/bpf_jit_core.c b/arch/riscv/net/bpf_jit_core.c
index fed86f42dfbe..0fee2cbaaf53 100644
--- a/arch/riscv/net/bpf_jit_core.c
+++ b/arch/riscv/net/bpf_jit_core.c
@@ -166,6 +166,11 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
return prog;
}
+u64 bpf_jit_alloc_exec_limit(void)
+{
+ return BPF_JIT_REGION_SIZE;
+}
+
void *bpf_jit_alloc_exec(unsigned long size)
{
return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START,
--
2.30.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next 1/4] bpf: define bpf_jit_alloc_exec_limit for riscv JIT
2021-09-24 9:55 ` [PATCH bpf-next 1/4] bpf: define bpf_jit_alloc_exec_limit for riscv JIT Lorenz Bauer
@ 2021-09-24 15:28 ` Luke Nelson
0 siblings, 0 replies; 3+ messages in thread
From: Luke Nelson @ 2021-09-24 15:28 UTC (permalink / raw)
To: Lorenz Bauer
Cc: Xi Wang, Björn Töpel, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
kernel-team, Networking, bpf, linux-riscv, open list
> Expose the maximum amount of useable memory from the sparcv JIT.
sparcv -> riscv?
Otherwise lgtm!
Acked-by: Luke Nelson <luke.r.nels@gmail.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-24 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 9:55 [PATCH bpf-next 0/4] Fix up bpf_jit_limit some more Lorenz Bauer
2021-09-24 9:55 ` [PATCH bpf-next 1/4] bpf: define bpf_jit_alloc_exec_limit for riscv JIT Lorenz Bauer
2021-09-24 15:28 ` Luke Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).