linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros
@ 2023-03-18  8:00 Leonardo Bras
  2023-03-18  8:00 ` [RFC PATCH 1/6] riscv/cmpxchg: Deduplicate cmpxchg() asm functions Leonardo Bras
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Leonardo Bras @ 2023-03-18  8:00 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Leonardo Bras, Guo Ren
  Cc: linux-riscv, linux-kernel

While studying riscv's cmpxchg.h file, I got really interested in 
understanding how RISCV asm implemented the different versions of 
{cmp,}xchg.

When I understood the pattern, it made sense for me to remove the 
duplications and create macros to make it easier to understand what exactly 
changes between the versions: Instruction sufixes & barriers.

I split those changes in 3 levels for each cmpxchg and xchg, resulting a 
total of 6 patches. I did this so it becomes easier to review and remove 
the last levels if desired, but I have no issue squashing them if it's 
better.

Please provide comments.

Thanks!
Leo

Leonardo Bras (6):
  riscv/cmpxchg: Deduplicate cmpxchg() asm functions
  riscv/cmpxchg: Deduplicate cmpxchg() macros
  riscv/cmpxchg: Deduplicate arch_cmpxchg() macros
  riscv/cmpxchg: Deduplicate xchg() asm functions
  riscv/cmpxchg: Deduplicate xchg() macros
  riscv/cmpxchg: Deduplicate arch_xchg() macros

 arch/riscv/include/asm/cmpxchg.h | 316 +++++++------------------------
 1 file changed, 64 insertions(+), 252 deletions(-)

-- 
2.40.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-03-22  7:45 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-18  8:00 [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros Leonardo Bras
2023-03-18  8:00 ` [RFC PATCH 1/6] riscv/cmpxchg: Deduplicate cmpxchg() asm functions Leonardo Bras
2023-03-18  8:00 ` [RFC PATCH 2/6] riscv/cmpxchg: Deduplicate cmpxchg() macros Leonardo Bras
2023-03-18  8:00 ` [RFC PATCH 3/6] riscv/cmpxchg: Deduplicate arch_cmpxchg() macros Leonardo Bras
2023-03-18  8:00 ` [RFC PATCH 4/6] riscv/cmpxchg: Deduplicate xchg() asm functions Leonardo Bras
2023-03-18  8:00 ` [RFC PATCH 5/6] riscv/cmpxchg: Deduplicate xchg() macros Leonardo Bras
2023-03-18  8:01 ` [RFC PATCH 6/6] riscv/cmpxchg: Deduplicate arch_xchg() macros Leonardo Bras
2023-03-19 20:35 ` [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros Conor Dooley
2023-03-21  6:30   ` Leonardo Brás
2023-03-21  7:48     ` Conor Dooley
2023-03-21 17:01       ` Leonardo Bras Soares Passos
2023-03-21 19:48         ` Conor Dooley
2023-03-22  3:42           ` Leonardo Bras Soares Passos
2023-03-22  7:56             ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).