Re: [PATCH] perf: RISC-V: fix IRQ detection on T-Head C908

From: Conor Dooley <conor.dooley@microchip.com>
To: Yangyu Chen <cyy@cyyself.name>
Cc: <conor@kernel.org>, <ajones@ventanamicro.com>,
	<anup@brainfault.org>, <aou@eecs.berkeley.edu>,
	<atishp@atishpatra.org>, <dqfext@gmail.com>, <guoren@kernel.org>,
	<heiko@sntech.de>, <inochiama@outlook.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<mark.rutland@arm.com>, <palmer@dabbelt.com>,
	<paul.walmsley@sifive.com>, <will@kernel.org>
Subject: Re: [PATCH] perf: RISC-V: fix IRQ detection on T-Head C908
Date: Fri, 12 Apr 2024 08:40:46 +0100	[thread overview]
Message-ID: <20240412-ivy-excitable-b740ff80c0d1@wendy> (raw)
In-Reply-To: <tencent_49E156C63C84E435E6F16509D6699339520A@qq.com>

[-- Attachment #1.1: Type: text/plain, Size: 1092 bytes --]

On Fri, Apr 12, 2024 at 02:27:28PM +0800, Yangyu Chen wrote:
> >> IMHO, it may be better to use a new DT property like "riscv,cpu-errata" or
> >> "<vendor>,cpu-errata". It can achieve almost everything like using pseudo
> >> isa. And the only cost I think is a small amount code to parse this.
> > 
> > I suppose we could do that, but accounting for vendor specifics was one
> > of the goals for the property I only just added and that I am suggesting
> > to use here.
> 
> I think there is a simpler way to do that. We use T-Head PMU by default
> for All T-Head CPUs (from mvendor id). Then, to test there is sscofpmf in
> the ISA string being probed by the kernel. If yes, then use scofpmf.
> Otherwise, use T-Head PMU.

I am strongly opposed to doing something like this. Firstly, making it
unconditional is a time-bomb as if T-Head ever ship something without
support then we'll be broken on that platform and have to return to
conditional behaviour. Secondly, we are taking agency away from
hypervisors etc that may not want a guest to use the PMU.

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv