linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Palmer Dabbelt <palmerdabbelt@google.com>,
	Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	kernel-team@android.com, kernel test robot <lkp@intel.com>,
	linux-crypto@vger.kernel.org
Subject: Re: get_cycles from modular code in jitterentropy, was Re: [PATCH] clocksource: clint: Export clint_time_val for modules
Date: Fri, 02 Oct 2020 08:55:04 +0200	[thread overview]
Message-ID: <3059805.eeVPZ7aKPO@tauon.chronox.de> (raw)
In-Reply-To: <20201002064905.GA27115@infradead.org>

Am Freitag, 2. Oktober 2020, 08:49:05 CEST schrieb Christoph Hellwig:

Hi Christoph,

> On Tue, Sep 29, 2020 at 11:56:18PM -0700, Palmer Dabbelt wrote:
> > clint_time_val will soon be used by the RISC-V implementation of
> > random_get_entropy(), which is a static inline function that may be used
> > by
> > modules (at least CRYPTO_JITTERENTROPY=m).
> 
> At very least this needs to be an EXPORT_SYMBOL_GPL.  But I really don't
> think modules have any business using get_cycles, so I'd much rather
> fix CRYPTO_JITTERENTROPY to be required to be build in.

Changing CRYPTO_JITTERENTROPY from tistate to bool should be no problem.

I will provide a patch.

Ciao
Stephan



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2020-10-02  6:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  6:56 [PATCH] clocksource: clint: Export clint_time_val for modules Palmer Dabbelt
2020-10-02  6:49 ` get_cycles from modular code in jitterentropy, was " Christoph Hellwig
2020-10-02  6:55   ` Stephan Mueller [this message]
2020-10-04 18:48   ` [PATCH] crypto: jitterentropy - bind statically into kernel Stephan Müller
2020-10-04 21:16     ` Ard Biesheuvel
2020-10-04 22:05       ` Palmer Dabbelt
2020-10-05  6:19       ` Christoph Hellwig
2020-10-05  6:24         ` Ard Biesheuvel
2020-10-05  6:40           ` Stephan Mueller
2020-10-05  6:44             ` Christoph Hellwig
2020-10-05  6:44             ` Ard Biesheuvel
2020-10-05  6:56               ` Christoph Hellwig
2020-10-05  7:45               ` Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3059805.eeVPZ7aKPO@tauon.chronox.de \
    --to=smueller@chronox.de \
    --cc=hch@infradead.org \
    --cc=kernel-team@android.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=palmerdabbelt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).