From: Palmer Dabbelt <palmerdabbelt@google.com>
To: ardb@kernel.org
Cc: lkp@intel.com, smueller@chronox.de, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-crypto@vger.kernel.org, linux-riscv@lists.infradead.org,
kernel-team@android.com
Subject: Re: [PATCH] crypto: jitterentropy - bind statically into kernel
Date: Sun, 04 Oct 2020 15:05:14 -0700 (PDT) [thread overview]
Message-ID: <mhng-bfca22db-02c7-4e71-9b83-00367c9a6bfb@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <CAMj1kXEnOh4MBiVVgkhd4P81eRPCVi3+y6JcD58jL45-eh324A@mail.gmail.com>
On Sun, 04 Oct 2020 14:16:10 PDT (-0700), ardb@kernel.org wrote:
> On Sun, 4 Oct 2020 at 20:48, Stephan Müller <smueller@chronox.de> wrote:
>>
>> The RISC-V architecture is about to implement the callback
>> random_get_entropy with a function that is not exported to modules.
>
> Why is that? Wouldn't it be better to export the symbol instead?
It's static inline (in our timex.h), so I thought we didn't need to export the
symbol? Did this just arise because clint_time_val wasn't exported? That was
fixed before the random_get_entropy() change landed in Linus' tree, so as far
as I know we should be OK here.
If I broke something here it seem better to fix this in the RISC-V port than by
just banning modular compilation of jitterentropy, as that seems like a useful
feature to me.
>> Thus, the Jitter RNG is changed to be only bound statically into the
>> kernel removing the option to compile it as module.
>>
>> Reported-by: Christoph Hellwig <hch@infradead.org>
>> Signed-off-by: Stephan Mueller <smueller@chronox.de>
>> ---
>> crypto/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/crypto/Kconfig b/crypto/Kconfig
>> index 094ef56ab7b4..5b20087b117f 100644
>> --- a/crypto/Kconfig
>> +++ b/crypto/Kconfig
>> @@ -1853,7 +1853,7 @@ config CRYPTO_DRBG
>> endif # if CRYPTO_DRBG_MENU
>>
>> config CRYPTO_JITTERENTROPY
>> - tristate "Jitterentropy Non-Deterministic Random Number Generator"
>> + bool "Jitterentropy Non-Deterministic Random Number Generator"
>> select CRYPTO_RNG
>> help
>> The Jitterentropy RNG is a noise that is intended
>> --
>> 2.26.2
>>
>>
>>
>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-10-04 22:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:56 [PATCH] clocksource: clint: Export clint_time_val for modules Palmer Dabbelt
2020-10-02 6:49 ` get_cycles from modular code in jitterentropy, was " Christoph Hellwig
2020-10-02 6:55 ` Stephan Mueller
2020-10-04 18:48 ` [PATCH] crypto: jitterentropy - bind statically into kernel Stephan Müller
2020-10-04 21:16 ` Ard Biesheuvel
2020-10-04 22:05 ` Palmer Dabbelt [this message]
2020-10-05 6:19 ` Christoph Hellwig
2020-10-05 6:24 ` Ard Biesheuvel
2020-10-05 6:40 ` Stephan Mueller
2020-10-05 6:44 ` Christoph Hellwig
2020-10-05 6:44 ` Ard Biesheuvel
2020-10-05 6:56 ` Christoph Hellwig
2020-10-05 7:45 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-bfca22db-02c7-4e71-9b83-00367c9a6bfb@palmerdabbelt-glaptop1 \
--to=palmerdabbelt@google.com \
--cc=ardb@kernel.org \
--cc=hch@infradead.org \
--cc=kernel-team@android.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).