* Re: [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
2023-03-17 13:45 [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found Ben Dooks
@ 2023-03-17 13:55 ` Conor Dooley
2023-03-17 17:32 ` Andrew Jones
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2023-03-17 13:55 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-riscv, palmer, conor.dooley, atishp
[-- Attachment #1.1: Type: text/plain, Size: 1659 bytes --]
On Fri, Mar 17, 2023 at 01:45:12PM +0000, Ben Dooks wrote:
> If Zicbom is present but there was no riscv,cbom-blocks-size property found
> during the cpu feeatures probe, or the cbom-block-size is not valid, then
> the extension will be disabled. Make the print explicitly say this is
> disabled to ensure that there is no confusion about what is being done.
>
Being explicit seems like a good idea,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/riscv/kernel/cpufeature.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> index 59d58ee0f68d..c8b883827840 100644
> --- a/arch/riscv/kernel/cpufeature.c
> +++ b/arch/riscv/kernel/cpufeature.c
> @@ -72,10 +72,10 @@ static bool riscv_isa_extension_check(int id)
> switch (id) {
> case RISCV_ISA_EXT_ZICBOM:
> if (!riscv_cbom_block_size) {
> - pr_err("Zicbom detected in ISA string, but no cbom-block-size found\n");
> + pr_err("Zicbom detected in ISA string, disabling as no cbom-block-size found\n");
> return false;
> } else if (!is_power_of_2(riscv_cbom_block_size)) {
> - pr_err("cbom-block-size present, but is not a power-of-2\n");
> + pr_err("Zicbom disabled as cbom-block-size present, but is not a power-of-2\n");
> return false;
> }
> return true;
> --
> 2.39.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
2023-03-17 13:45 [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found Ben Dooks
2023-03-17 13:55 ` Conor Dooley
@ 2023-03-17 17:32 ` Andrew Jones
2023-03-22 14:14 ` Andrew Jones
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Jones @ 2023-03-17 17:32 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-riscv, palmer, conor.dooley, atishp
On Fri, Mar 17, 2023 at 01:45:12PM +0000, Ben Dooks wrote:
> If Zicbom is present but there was no riscv,cbom-blocks-size property found
> during the cpu feeatures probe, or the cbom-block-size is not valid, then
> the extension will be disabled. Make the print explicitly say this is
> disabled to ensure that there is no confusion about what is being done.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/riscv/kernel/cpufeature.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> index 59d58ee0f68d..c8b883827840 100644
> --- a/arch/riscv/kernel/cpufeature.c
> +++ b/arch/riscv/kernel/cpufeature.c
> @@ -72,10 +72,10 @@ static bool riscv_isa_extension_check(int id)
> switch (id) {
> case RISCV_ISA_EXT_ZICBOM:
> if (!riscv_cbom_block_size) {
> - pr_err("Zicbom detected in ISA string, but no cbom-block-size found\n");
> + pr_err("Zicbom detected in ISA string, disabling as no cbom-block-size found\n");
> return false;
> } else if (!is_power_of_2(riscv_cbom_block_size)) {
> - pr_err("cbom-block-size present, but is not a power-of-2\n");
> + pr_err("Zicbom disabled as cbom-block-size present, but is not a power-of-2\n");
> return false;
> }
> return true;
> --
> 2.39.2
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
2023-03-17 13:45 [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found Ben Dooks
2023-03-17 13:55 ` Conor Dooley
2023-03-17 17:32 ` Andrew Jones
@ 2023-03-22 14:14 ` Andrew Jones
2023-06-19 22:07 ` Palmer Dabbelt
2023-06-20 1:00 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Jones @ 2023-03-22 14:14 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-riscv, palmer, conor.dooley, atishp
On Fri, Mar 17, 2023 at 01:45:12PM +0000, Ben Dooks wrote:
> If Zicbom is present but there was no riscv,cbom-blocks-size property found
> during the cpu feeatures probe, or the cbom-block-size is not valid, then
> the extension will be disabled. Make the print explicitly say this is
> disabled to ensure that there is no confusion about what is being done.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/riscv/kernel/cpufeature.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> index 59d58ee0f68d..c8b883827840 100644
> --- a/arch/riscv/kernel/cpufeature.c
> +++ b/arch/riscv/kernel/cpufeature.c
> @@ -72,10 +72,10 @@ static bool riscv_isa_extension_check(int id)
> switch (id) {
> case RISCV_ISA_EXT_ZICBOM:
> if (!riscv_cbom_block_size) {
> - pr_err("Zicbom detected in ISA string, but no cbom-block-size found\n");
> + pr_err("Zicbom detected in ISA string, disabling as no cbom-block-size found\n");
> return false;
> } else if (!is_power_of_2(riscv_cbom_block_size)) {
> - pr_err("cbom-block-size present, but is not a power-of-2\n");
> + pr_err("Zicbom disabled as cbom-block-size present, but is not a power-of-2\n");
> return false;
> }
> return true;
> --
> 2.39.2
>
Hi Ben,
If you wanted to rebase this on riscv-linux/for-next, then you could make
the same changes for zicboz at the same time.
Thanks,
drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
2023-03-17 13:45 [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found Ben Dooks
` (2 preceding siblings ...)
2023-03-22 14:14 ` Andrew Jones
@ 2023-06-19 22:07 ` Palmer Dabbelt
2023-06-20 1:00 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2023-06-19 22:07 UTC (permalink / raw)
To: linux-riscv, Ben Dooks; +Cc: Palmer Dabbelt, Conor Dooley, Atish Patra
On Fri, 17 Mar 2023 13:45:12 +0000, Ben Dooks wrote:
> If Zicbom is present but there was no riscv,cbom-blocks-size property found
> during the cpu feeatures probe, or the cbom-block-size is not valid, then
> the extension will be disabled. Make the print explicitly say this is
> disabled to ensure that there is no confusion about what is being done.
>
>
Applied, thanks!
[1/1] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
https://git.kernel.org/palmer/c/c818fea83de4
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
2023-03-17 13:45 [PATCH] riscv: say disabling zicbom if no or bad riscv,cbom-block-size found Ben Dooks
` (3 preceding siblings ...)
2023-06-19 22:07 ` Palmer Dabbelt
@ 2023-06-20 1:00 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-06-20 1:00 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-riscv, palmer, conor.dooley, atishp
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Fri, 17 Mar 2023 13:45:12 +0000 you wrote:
> If Zicbom is present but there was no riscv,cbom-blocks-size property found
> during the cpu feeatures probe, or the cbom-block-size is not valid, then
> the extension will be disabled. Make the print explicitly say this is
> disabled to ensure that there is no confusion about what is being done.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> [...]
Here is the summary with links:
- riscv: say disabling zicbom if no or bad riscv,cbom-block-size found
https://git.kernel.org/riscv/c/c818fea83de4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread