Re: Random memory corruption with v5.2

[Atish Patra <Atish.Patra@wdc.com>]

On Mon, 2019-08-05 at 16:34 +0200, Andreas Schwab wrote:
> But this does help:
> 
> --- a/arch/riscv/include/asm/tlbflush.h
> +++ b/arch/riscv/include/asm/tlbflush.h
> @@ -49,7 +49,7 @@ static inline void remote_sfence_vma(struct cpumask
> *cmask, unsigned long start,
>  
>  	cpumask_clear(&hmask);
>  	riscv_cpuid_to_hartid_mask(cmask, &hmask);
> -	sbi_remote_sfence_vma(hmask.bits, start, size);
> +	sbi_remote_sfence_vma(hmask.bits, 0, -1);
>  }
>  
>  #define flush_tlb_all() sbi_remote_sfence_vma(NULL, 0, -1)
> 

I am also able to reprduce the issue while doing a install-locales.
Here is the temporary fix that seems to solve the issue.

diff --git a/arch/riscv/include/asm/tlbflush.h
b/arch/riscv/include/asm/tlbflush.h
index 687dd19735a7..29b2bd7c9923 100644
--- a/arch/riscv/include/asm/tlbflush.h
+++ b/arch/riscv/include/asm/tlbflush.h
@@ -55,7 +55,7 @@ static inline void remote_sfence_vma(struct cpumask
*cmask, unsigned long start,
 #define flush_tlb_all() sbi_remote_sfence_vma(NULL, 0, -1)
 #define flush_tlb_page(vma, addr) flush_tlb_range(vma, addr, 0)
 #define flush_tlb_range(vma, start, end) \
-       remote_sfence_vma(mm_cpumask((vma)->vm_mm), start, (end) -
(start))
+       remote_sfence_vma(mm_cpumask((vma)->vm_mm), 0, -1)
 #define flush_tlb_mm(mm) \
        remote_sfence_vma(mm_cpumask(mm), 0, -1)

Can you please verify at your end?


While your fix flushes the entire tlb for every type of remote tlb
flush, this fix proves that the issue is with flush_tlb_range call
only.

I am looking at the OpenSBI/Kernel implementation to figure out if it
is an OpenSBI issue or something changed in kernel recently to trigger
this.

Additionally, do you know if a particular or group of locale install 
is causing this issue? 

It takes more than hour to finish the full install-locales on unleashe
board which makes it bit difficult to try out possible fixes.


> Andreas.
> 

-- 
Regards,
Atish
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv