From: Logan Gunthorpe <logang@deltatee.com>
To: Yash Shah <yash.shah@sifive.com>,
"Paul Walmsley ( Sifive)" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"Anup.Patel@wdc.com" <Anup.Patel@wdc.com>,
"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
Sachin Ghadi <sachin.ghadi@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"ren_guo@c-sky.com" <ren_guo@c-sky.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"bmeng.cn@gmail.com" <bmeng.cn@gmail.com>
Subject: Re: [PATCH v2] RISC-V: Add address map dumper
Date: Mon, 18 Nov 2019 09:44:14 -0700 [thread overview]
Message-ID: <86b0a2c6-91ee-6ea6-92e7-1e5235b559f5@deltatee.com> (raw)
In-Reply-To: <1574056694-28927-1-git-send-email-yash.shah@sifive.com>
On 2019-11-17 10:58 p.m., Yash Shah wrote:
> Add support for dumping the kernel address space layout to the console.
> User can enable CONFIG_DEBUG_VM to dump the virtual memory region into
> dmesg buffer during boot-up.
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
Looks good to me, thanks.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> This patch is based on Linux 5.4-rc6 and tested on SiFive HiFive
> Unleashed board.
>
> Changes in v2:
> - Avoid #ifdefs inside functions
> - Helper functions instead of macros
> - Drop newly added CONFIG_DEBUG_VM_LAYOUT, instead use CONFIG_DEBUG_VM
> ---
> arch/riscv/mm/init.c | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 573463d..7828136 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -45,6 +45,41 @@ void setup_zero_page(void)
> memset((void *)empty_zero_page, 0, PAGE_SIZE);
> }
>
> +#ifdef CONFIG_DEBUG_VM
> +static inline void print_mlk(char *name, unsigned long b, unsigned long t)
> +{
> + pr_notice("%12s : 0x%08lx - 0x%08lx (%4ld kB)\n", name, b, t,
> + (((t) - (b)) >> 10));
> +}
> +
> +static inline void print_mlm(char *name, unsigned long b, unsigned long t)
> +{
> + pr_notice("%12s : 0x%08lx - 0x%08lx (%4ld MB)\n", name, b, t,
> + (((t) - (b)) >> 20));
> +}
> +
> +static void print_vm_layout(void)
> +{
> + pr_notice("Virtual kernel memory layout:\n");
> + print_mlk("fixmap", (unsigned long)FIXADDR_START,
> + (unsigned long)FIXADDR_TOP);
> + print_mlm("vmemmap", (unsigned long)VMEMMAP_START,
> + (unsigned long)VMEMMAP_END);
> + print_mlm("vmalloc", (unsigned long)VMALLOC_START,
> + (unsigned long)VMALLOC_END);
> + print_mlm("lowmem", (unsigned long)PAGE_OFFSET,
> + (unsigned long)high_memory);
> + print_mlk(".init", (unsigned long)__init_begin,
> + (unsigned long)__init_end);
> + print_mlk(".text", (unsigned long)_text, (unsigned long)_etext);
> + print_mlk(".data", (unsigned long)_sdata, (unsigned long)_edata);
> + print_mlk(".bss", (unsigned long)__bss_start,
> + (unsigned long)__bss_stop);
> +}
> +#else
> +static void print_vm_layout(void) { }
> +#endif /* CONFIG_DEBUG_VM */
> +
> void __init mem_init(void)
> {
> #ifdef CONFIG_FLATMEM
> @@ -55,6 +90,7 @@ void __init mem_init(void)
> memblock_free_all();
>
> mem_init_print_info(NULL);
> + print_vm_layout();
> }
>
> #ifdef CONFIG_BLK_DEV_INITRD
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-11-18 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 5:58 [PATCH v2] RISC-V: Add address map dumper Yash Shah
2019-11-18 6:12 ` Anup Patel
2019-11-18 16:44 ` Logan Gunthorpe [this message]
2019-11-23 2:57 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b0a2c6-91ee-6ea6-92e7-1e5235b559f5@deltatee.com \
--to=logang@deltatee.com \
--cc=Anup.Patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=bmeng.cn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ren_guo@c-sky.com \
--cc=rppt@linux.ibm.com \
--cc=sachin.ghadi@sifive.com \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).