[PATCH 0/2] Add PTP support for sama7g5

[PATCH 0/2] Add PTP support for sama7g5

[Durai Manickam KR]

This patch series is intended to add PTP capability to the GEM and 
EMAC for sama7g5.

Durai Manickam KR (2):
  net: macb: Add PTP support to GEM for sama7g5
  net: macb: Add PTP support to EMAC for sama7g5

 drivers/net/ethernet/cadence/macb_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.25.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH 1/2] net: macb: Add PTP support to GEM for sama7g5

[Durai Manickam KR]

Add PTP capability to the Gigabit Ethernet MAC.

Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 6e141a8bbf43..27fc6c903d25 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4844,7 +4844,7 @@ static const struct macb_config mpfs_config = {
 
 static const struct macb_config sama7g5_gem_config = {
 	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG |
-		MACB_CAPS_MIIONRGMII,
+		MACB_CAPS_MIIONRGMII | MACB_CAPS_GEM_HAS_PTP,
 	.dma_burst_length = 16,
 	.clk_init = macb_clk_init,
 	.init = macb_init,
-- 
2.25.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH 2/2] net: macb: Add PTP support to EMAC for sama7g5

[Durai Manickam KR]

Add PTP capability to the Ethernet MAC.

Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 27fc6c903d25..1dbee16fe90a 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4853,7 +4853,8 @@ static const struct macb_config sama7g5_gem_config = {
 
 static const struct macb_config sama7g5_emac_config = {
 	.caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII |
-		MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII,
+		MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII |
+		MACB_CAPS_GEM_HAS_PTP,
 	.dma_burst_length = 16,
 	.clk_init = macb_clk_init,
 	.init = macb_init,
-- 
2.25.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 0/2] Add PTP support for sama7g5

[Michal Swiatkowski]

On Wed, Mar 15, 2023 at 03:20:51PM +0530, Durai Manickam KR wrote:
> This patch series is intended to add PTP capability to the GEM and 
> EMAC for sama7g5.
> 
> Durai Manickam KR (2):
>   net: macb: Add PTP support to GEM for sama7g5
>   net: macb: Add PTP support to EMAC for sama7g5
> 
>  drivers/net/ethernet/cadence/macb_main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

Side question, doesn't it need any software implementation? Or it is
already implemented, or it is only hw caps?

> -- 
> 2.25.1
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 0/2] Add PTP support for sama7g5

[Durai.ManickamKR]

On 15/03/23 17:13, Michal Swiatkowski wrote:
> [Some people who received this message don't often get email from michal.swiatkowski@linux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, Mar 15, 2023 at 03:20:51PM +0530, Durai Manickam KR wrote:
>> This patch series is intended to add PTP capability to the GEM and
>> EMAC for sama7g5.
>>
>> Durai Manickam KR (2):
>>    net: macb: Add PTP support to GEM for sama7g5
>>    net: macb: Add PTP support to EMAC for sama7g5
>>
>>   drivers/net/ethernet/cadence/macb_main.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>
> Side question, doesn't it need any software implementation? Or it is
> already implemented, or it is only hw caps?

Hi Michal,

It is already implemented. Here the scope is to just enable it for sama7g5.

>> --
>> 2.25.1
>>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 0/2] Add PTP support for sama7g5

[Piotr Raczynski]

On Wed, Mar 15, 2023 at 11:56:15AM +0000, Durai.ManickamKR@microchip.com wrote:
> On 15/03/23 17:13, Michal Swiatkowski wrote:
> > [Some people who received this message don't often get email from michal.swiatkowski@linux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Wed, Mar 15, 2023 at 03:20:51PM +0530, Durai Manickam KR wrote:
> >> This patch series is intended to add PTP capability to the GEM and
> >> EMAC for sama7g5.
> >>
> >> Durai Manickam KR (2):
> >>    net: macb: Add PTP support to GEM for sama7g5
> >>    net: macb: Add PTP support to EMAC for sama7g5
> >>
> >>   drivers/net/ethernet/cadence/macb_main.c | 5 +++--
> >>   1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> >
> > Side question, doesn't it need any software implementation? Or it is
> > already implemented, or it is only hw caps?
> 
> Hi Michal,
> 
> It is already implemented. Here the scope is to just enable it for sama7g5.
> 

Also, since commits lack target tree (net-next?) I'm not sure if the
patches will be picked by bot and tested.

Piotr.
> >> --
> >> 2.25.1
> >>
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 1/2] net: macb: Add PTP support to GEM for sama7g5

[Claudiu.Beznea]

On 15.03.2023 11:50, Durai Manickam KR wrote:
> Add PTP capability to the Gigabit Ethernet MAC.
> 
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  drivers/net/ethernet/cadence/macb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 6e141a8bbf43..27fc6c903d25 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4844,7 +4844,7 @@ static const struct macb_config mpfs_config = {
>  
>  static const struct macb_config sama7g5_gem_config = {
>  	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG |
> -		MACB_CAPS_MIIONRGMII,
> +		MACB_CAPS_MIIONRGMII | MACB_CAPS_GEM_HAS_PTP,
>  	.dma_burst_length = 16,
>  	.clk_init = macb_clk_init,
>  	.init = macb_init,

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 2/2] net: macb: Add PTP support to EMAC for sama7g5

[Claudiu.Beznea]

On 15.03.2023 11:50, Durai Manickam KR wrote:
> Add PTP capability to the Ethernet MAC.
> 
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> --->  drivers/net/ethernet/cadence/macb_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 27fc6c903d25..1dbee16fe90a 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4853,7 +4853,8 @@ static const struct macb_config sama7g5_gem_config = {
>  
>  static const struct macb_config sama7g5_emac_config = {
>  	.caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII |
> -		MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII,
> +		MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII |
> +		MACB_CAPS_GEM_HAS_PTP,
>  	.dma_burst_length = 16,
>  	.clk_init = macb_clk_init,
>  	.init = macb_init,

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 0/2] Add PTP support for sama7g5

[Jakub Kicinski]

On Wed, 15 Mar 2023 13:43:17 +0100 Piotr Raczynski wrote:
> > It is already implemented. Here the scope is to just enable it for sama7g5.
> 
> Also, since commits lack target tree (net-next?) I'm not sure if the
> patches will be picked by bot and tested.

The tree_selection check reports what tree it ended up picking, FWIW

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 0/2] Add PTP support for sama7g5

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 15 Mar 2023 15:20:51 +0530 you wrote:
> This patch series is intended to add PTP capability to the GEM and
> EMAC for sama7g5.
> 
> Durai Manickam KR (2):
>   net: macb: Add PTP support to GEM for sama7g5
>   net: macb: Add PTP support to EMAC for sama7g5
> 
> [...]

Here is the summary with links:
  - [1/2] net: macb: Add PTP support to GEM for sama7g5
    https://git.kernel.org/netdev/net-next/c/abc783a7b0ff
  - [2/2] net: macb: Add PTP support to EMAC for sama7g5
    https://git.kernel.org/netdev/net-next/c/9bae0dd05e61

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH 1/2] net: macb: Add PTP support to GEM for sama7g5

[Durai Manickam KR]

Add PTP capability to the Gigabit Ethernet MAC.

Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 6e141a8bbf43..27fc6c903d25 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4844,7 +4844,7 @@ static const struct macb_config mpfs_config = {
 
 static const struct macb_config sama7g5_gem_config = {
 	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG |
-		MACB_CAPS_MIIONRGMII,
+		MACB_CAPS_MIIONRGMII | MACB_CAPS_GEM_HAS_PTP,
 	.dma_burst_length = 16,
 	.clk_init = macb_clk_init,
 	.init = macb_init,
-- 
2.25.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv