From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Palmer Dabbelt <palmer@dabbelt.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
Greg Ungerer <gerg@linux-m68k.org>,
Anup Patel <Anup.Patel@wdc.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V
Date: Thu, 15 Apr 2021 00:32:10 +0000 [thread overview]
Message-ID: <BL0PR04MB65148D80C819A7E3B8365242E74D9@BL0PR04MB6514.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210407154924.1557489-1-damien.lemoal@wdc.com
On 2021/04/08 0:49, Damien Le Moal wrote:
> RISC-V NOMMU flat binaries cannot tolerate a gap between the text and
> data section as the toolchain fully resolves at compile time the PC
> relative global pointer (__global_pointer$ value loaded in gp register).
> Without a relocation entry provided, the flat bin loader cannot fix the
> value if a gap is introduced and executables fail to run.
>
> This series fixes this problem by allowing an architecture to request
> the flat loader to suppress the gap between the text and data sections.
> The first patch fixes binfmt_flat flat_load_file() using the new
> configuration option CONFIG_BINFMT_FLAT_NO_TEXT_DATA_GAP. The second
> patch enables this option for RISCV NOMMU builds.
>
> These patches do not change the binfmt_flat loader behavior for other
> architectures.
>
> Changes from v1:
> * Replace FLAT_TEXT_DATA_NO_GAP macro with
> CONFIG_BINFMT_FLAT_NO_TEXT_DATA_GAP config option (patch 1).
> * Remove the addition of riscv/include/asm/flat.h and set
> CONFIG_BINFMT_FLAT_NO_TEXT_DATA_GAP for RISCV and !MMU
>
> Damien Le Moal (2):
> binfmt_flat: allow not offsetting data start
> riscv: Disable text-data gap in flat binaries
>
> arch/riscv/Kconfig | 1 +
> fs/Kconfig.binfmt | 3 +++
> fs/binfmt_flat.c | 21 +++++++++++++++------
> 3 files changed, 19 insertions(+), 6 deletions(-)
>
Ping ?
Any comment on these patches ?
Without them, RISC-V NOMMU user space does not run... I would really like to get
these in this cycle if possible.
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-04-15 0:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 15:49 [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V Damien Le Moal
2021-04-07 15:49 ` [PATCH v2 1/2] binfmt_flat: allow not offsetting data start Damien Le Moal
2021-04-07 15:49 ` [PATCH v2 2/2] riscv: Disable text-data gap in flat binaries Damien Le Moal
2021-04-15 0:32 ` Damien Le Moal [this message]
2021-04-15 5:46 ` [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V Palmer Dabbelt
2021-04-15 5:56 ` Christoph Hellwig
2021-04-15 6:16 ` Damien Le Moal
2021-04-16 0:21 ` Al Viro
2021-04-16 0:26 ` Damien Le Moal
2021-04-16 7:26 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR04MB65148D80C819A7E3B8365242E74D9@BL0PR04MB6514.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=gerg@linux-m68k.org \
--cc=hch@lst.de \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).