* [PATCH] DT node for SiFive FU540 Ethernet Controller driver @ 2019-06-21 6:10 Yash Shah 2019-06-21 6:10 ` [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah 0 siblings, 1 reply; 5+ messages in thread From: Yash Shah @ 2019-06-21 6:10 UTC (permalink / raw) To: robh+dt, paul.walmsley, devicetree, linux-riscv, linux-kernel Cc: mark.rutland, sachin.ghadi, Yash Shah, palmer, aou This patch-set is based on 'riscv-for-v5.2/fixes-rc6' tag of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git Tested on HiFive Unleashed board with additional patches required for testing can be found at dev/yashs/ethernet_dt branch of: https://github.com/yashshah7/riscv-linux.git Yash Shah (1): riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) -- 1.9.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver 2019-06-21 6:10 [PATCH] DT node for SiFive FU540 Ethernet Controller driver Yash Shah @ 2019-06-21 6:10 ` Yash Shah 2019-06-21 9:01 ` Anup Patel 2019-07-17 19:30 ` Paul Walmsley 0 siblings, 2 replies; 5+ messages in thread From: Yash Shah @ 2019-06-21 6:10 UTC (permalink / raw) To: robh+dt, paul.walmsley, devicetree, linux-riscv, linux-kernel Cc: mark.rutland, sachin.ghadi, Yash Shah, palmer, aou DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added Signed-off-by: Yash Shah <yash.shah@sifive.com> --- arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi index 4e8fbde..584e737 100644 --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi @@ -225,5 +225,25 @@ #address-cells = <1>; #size-cells = <0>; }; + eth0: ethernet@10090000 { + compatible = "sifive,fu540-macb"; + interrupt-parent = <&plic0>; + interrupts = <53>; + reg = <0x0 0x10090000 0x0 0x2000 + 0x0 0x100a0000 0x0 0x1000>; + reg-names = "control"; + local-mac-address = [00 00 00 00 00 00]; + phy-mode = "gmii"; + phy-handle = <&phy1>; + clock-names = "pclk", "hclk"; + clocks = <&prci PRCI_CLK_GEMGXLPLL>, + <&prci PRCI_CLK_GEMGXLPLL>; + #address-cells = <1>; + #size-cells = <0>; + phy1: ethernet-phy@0 { + reg = <0>; + }; + }; + }; }; -- 1.9.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver 2019-06-21 6:10 ` [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah @ 2019-06-21 9:01 ` Anup Patel 2019-06-21 9:59 ` Yash Shah 2019-07-17 19:30 ` Paul Walmsley 1 sibling, 1 reply; 5+ messages in thread From: Anup Patel @ 2019-06-21 9:01 UTC (permalink / raw) To: Yash Shah Cc: Mark Rutland, devicetree, Albert Ou, Palmer Dabbelt, linux-kernel@vger.kernel.org List, sachin.ghadi, Rob Herring, Paul Walmsley, linux-riscv On Fri, Jun 21, 2019 at 11:40 AM Yash Shah <yash.shah@sifive.com> wrote: > > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > Signed-off-by: Yash Shah <yash.shah@sifive.com> > --- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > index 4e8fbde..584e737 100644 > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > @@ -225,5 +225,25 @@ > #address-cells = <1>; > #size-cells = <0>; > }; > + eth0: ethernet@10090000 { > + compatible = "sifive,fu540-macb"; > + interrupt-parent = <&plic0>; > + interrupts = <53>; > + reg = <0x0 0x10090000 0x0 0x2000 > + 0x0 0x100a0000 0x0 0x1000>; > + reg-names = "control"; > + local-mac-address = [00 00 00 00 00 00]; > + phy-mode = "gmii"; > + phy-handle = <&phy1>; > + clock-names = "pclk", "hclk"; > + clocks = <&prci PRCI_CLK_GEMGXLPLL>, > + <&prci PRCI_CLK_GEMGXLPLL>; > + #address-cells = <1>; > + #size-cells = <0>; Have status = "disabled"; here and have status = "okay" in board DTS file. General convention for any SOC device with external connection (e.g. ethernet, SPI, SDHC, SATA, PCI, etc) is: 1. Define only device DT node in SOC DTSi file with status = "disabled" 2. Enable device in Board DTS file with status = "okay" 3. Define PHY or external PIN connection details in Board DTS file > + phy1: ethernet-phy@0 { > + reg = <0>; > + }; The PHY DT node should be in Board DTS file. Of course, same comments apply to SPI DT nodes as well but I missed reviewing those DT nodes. You can send separate DT patch to re-organize SPI DT nodes. Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver 2019-06-21 9:01 ` Anup Patel @ 2019-06-21 9:59 ` Yash Shah 0 siblings, 0 replies; 5+ messages in thread From: Yash Shah @ 2019-06-21 9:59 UTC (permalink / raw) To: Anup Patel Cc: Mark Rutland, devicetree, Albert Ou, Palmer Dabbelt, linux-kernel@vger.kernel.org List, Sachin Ghadi, Rob Herring, Paul Walmsley, linux-riscv On Fri, Jun 21, 2019 at 2:31 PM Anup Patel <anup@brainfault.org> wrote: > > On Fri, Jun 21, 2019 at 11:40 AM Yash Shah <yash.shah@sifive.com> wrote: > > > > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > > > Signed-off-by: Yash Shah <yash.shah@sifive.com> > > --- > > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > > index 4e8fbde..584e737 100644 > > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > > @@ -225,5 +225,25 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > }; > > + eth0: ethernet@10090000 { > > + compatible = "sifive,fu540-macb"; > > + interrupt-parent = <&plic0>; > > + interrupts = <53>; > > + reg = <0x0 0x10090000 0x0 0x2000 > > + 0x0 0x100a0000 0x0 0x1000>; > > + reg-names = "control"; > > + local-mac-address = [00 00 00 00 00 00]; > > + phy-mode = "gmii"; > > + phy-handle = <&phy1>; > > + clock-names = "pclk", "hclk"; > > + clocks = <&prci PRCI_CLK_GEMGXLPLL>, > > + <&prci PRCI_CLK_GEMGXLPLL>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Have status = "disabled"; here and have > status = "okay" in board DTS file. > > General convention for any SOC device with external > connection (e.g. ethernet, SPI, SDHC, SATA, PCI, etc) > is: > > 1. Define only device DT node in SOC DTSi file with > status = "disabled" > 2. Enable device in Board DTS file with > status = "okay" > 3. Define PHY or external PIN connection details > in Board DTS file > > > + phy1: ethernet-phy@0 { > > + reg = <0>; > > + }; > > The PHY DT node should be in Board DTS file. Will move all PHY related nodes in board DTS file. > > Of course, same comments apply to SPI DT nodes as well > but I missed reviewing those DT nodes. You can send separate > DT patch to re-organize SPI DT nodes. Sure, will send a separate patch for SPI DT nodes as well. Thanks for your comments. - Yash > > Regards, > Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver 2019-06-21 6:10 ` [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah 2019-06-21 9:01 ` Anup Patel @ 2019-07-17 19:30 ` Paul Walmsley 1 sibling, 0 replies; 5+ messages in thread From: Paul Walmsley @ 2019-07-17 19:30 UTC (permalink / raw) To: Yash Shah Cc: mark.rutland, devicetree, aou, palmer, linux-kernel, sachin.ghadi, robh+dt, linux-riscv On Fri, 21 Jun 2019, Yash Shah wrote: > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > Signed-off-by: Yash Shah <yash.shah@sifive.com> Dropping this one until it's updated to align with whatever you pick for the new driver DT compatible string, per https://lore.kernel.org/linux-riscv/1558611952-13295-1-git-send-email-yash.shah@sifive.com/T/#me298e16b2feeb481116cca61b94e014433cf2977 Please send an updated DT patch at your earliest convenience so we can get it into the v5.3-rc series. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-17 19:30 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-06-21 6:10 [PATCH] DT node for SiFive FU540 Ethernet Controller driver Yash Shah 2019-06-21 6:10 ` [PATCH] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah 2019-06-21 9:01 ` Anup Patel 2019-06-21 9:59 ` Yash Shah 2019-07-17 19:30 ` Paul Walmsley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).