* [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
@ 2019-05-23 21:45 Alan Mikhak
2019-05-23 23:57 ` Alan Mikhak
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Alan Mikhak @ 2019-05-23 21:45 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
Set endpoint controller pointer to null in pci_epc_remove_epf()
to avoid -EBUSY on subsequent call to pci_epc_add_epf().
Requires checking for null endpoint function pointer.
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
---
drivers/pci/endpoint/pci-epc-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
index e4712a0f249c..2091508c1620 100644
--- a/drivers/pci/endpoint/pci-epc-core.c
+++ b/drivers/pci/endpoint/pci-epc-core.c
@@ -519,11 +519,12 @@ void pci_epc_remove_epf(struct pci_epc *epc, struct pci_epf *epf)
{
unsigned long flags;
- if (!epc || IS_ERR(epc))
+ if (!epc || IS_ERR(epc) || !epf)
return;
spin_lock_irqsave(&epc->lock, flags);
list_del(&epf->list);
+ epf->epc = NULL;
spin_unlock_irqrestore(&epc->lock, flags);
}
EXPORT_SYMBOL_GPL(pci_epc_remove_epf);
--
2.7.4
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-23 21:45 [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null Alan Mikhak
@ 2019-05-23 23:57 ` Alan Mikhak
2019-05-24 8:41 ` Kishon Vijay Abraham I
2019-05-24 6:38 ` Christoph Hellwig
2019-06-11 10:07 ` Lorenzo Pieralisi
2 siblings, 1 reply; 12+ messages in thread
From: Alan Mikhak @ 2019-05-23 23:57 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
Palmer Dabbelt, Paul Walmsley, Bjorn Helgaas
+Bjorn Helgaas
On Thu, May 23, 2019 at 2:46 PM Alan Mikhak <alan.mikhak@sifive.com> wrote:
>
> Set endpoint controller pointer to null in pci_epc_remove_epf()
> to avoid -EBUSY on subsequent call to pci_epc_add_epf().
>
> Requires checking for null endpoint function pointer.
>
> Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
> ---
> drivers/pci/endpoint/pci-epc-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> index e4712a0f249c..2091508c1620 100644
> --- a/drivers/pci/endpoint/pci-epc-core.c
> +++ b/drivers/pci/endpoint/pci-epc-core.c
> @@ -519,11 +519,12 @@ void pci_epc_remove_epf(struct pci_epc *epc, struct pci_epf *epf)
> {
> unsigned long flags;
>
> - if (!epc || IS_ERR(epc))
> + if (!epc || IS_ERR(epc) || !epf)
> return;
>
> spin_lock_irqsave(&epc->lock, flags);
> list_del(&epf->list);
> + epf->epc = NULL;
> spin_unlock_irqrestore(&epc->lock, flags);
> }
> EXPORT_SYMBOL_GPL(pci_epc_remove_epf);
> --
> 2.7.4
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-23 21:45 [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null Alan Mikhak
2019-05-23 23:57 ` Alan Mikhak
@ 2019-05-24 6:38 ` Christoph Hellwig
2019-05-24 18:23 ` Alan Mikhak
2019-05-24 19:04 ` Paul Walmsley
2019-06-11 10:07 ` Lorenzo Pieralisi
2 siblings, 2 replies; 12+ messages in thread
From: Christoph Hellwig @ 2019-05-24 6:38 UTC (permalink / raw)
To: Alan Mikhak; +Cc: linux-riscv, palmer, paul.walmsley
[trimming recipient list]
How is this related to arch/riscv?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-23 23:57 ` Alan Mikhak
@ 2019-05-24 8:41 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2019-05-24 8:41 UTC (permalink / raw)
To: Alan Mikhak, linux-pci, linux-kernel, lorenzo.pieralisi,
linux-riscv, Palmer Dabbelt, Paul Walmsley, Bjorn Helgaas
On 24/05/19 5:27 AM, Alan Mikhak wrote:
> +Bjorn Helgaas
>
> On Thu, May 23, 2019 at 2:46 PM Alan Mikhak <alan.mikhak@sifive.com> wrote:
>>
>> Set endpoint controller pointer to null in pci_epc_remove_epf()
>> to avoid -EBUSY on subsequent call to pci_epc_add_epf().
>>
>> Requires checking for null endpoint function pointer.
>>
>> Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> drivers/pci/endpoint/pci-epc-core.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
>> index e4712a0f249c..2091508c1620 100644
>> --- a/drivers/pci/endpoint/pci-epc-core.c
>> +++ b/drivers/pci/endpoint/pci-epc-core.c
>> @@ -519,11 +519,12 @@ void pci_epc_remove_epf(struct pci_epc *epc, struct pci_epf *epf)
>> {
>> unsigned long flags;
>>
>> - if (!epc || IS_ERR(epc))
>> + if (!epc || IS_ERR(epc) || !epf)
>> return;
>>
>> spin_lock_irqsave(&epc->lock, flags);
>> list_del(&epf->list);
>> + epf->epc = NULL;
>> spin_unlock_irqrestore(&epc->lock, flags);
>> }
>> EXPORT_SYMBOL_GPL(pci_epc_remove_epf);
>> --
>> 2.7.4
>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-24 6:38 ` Christoph Hellwig
@ 2019-05-24 18:23 ` Alan Mikhak
2019-05-25 8:23 ` Christoph Hellwig
2019-05-24 19:04 ` Paul Walmsley
1 sibling, 1 reply; 12+ messages in thread
From: Alan Mikhak @ 2019-05-24 18:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-riscv, Palmer Dabbelt, Paul Walmsley
Chrisoph,
These changes were implemented in Linux PCI Endpoint framework to
exercise PCIe endpoint mode on RISCV.
Alan
On Thu, May 23, 2019 at 11:38 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> [trimming recipient list]
>
>
> How is this related to arch/riscv?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-24 6:38 ` Christoph Hellwig
2019-05-24 18:23 ` Alan Mikhak
@ 2019-05-24 19:04 ` Paul Walmsley
2019-05-24 19:05 ` Alan Mikhak
1 sibling, 1 reply; 12+ messages in thread
From: Paul Walmsley @ 2019-05-24 19:04 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Alan Mikhak, palmer, linux-riscv
On Thu, 23 May 2019, Christoph Hellwig wrote:
> [trimming recipient list]
>
>
> How is this related to arch/riscv?
This was my doing: I suggested to Alan that he copy these messages to the
linux-riscv mailing list. We're seeing interest from people who want to
build PCIe cards based on RISC-V Linux, so I thought it might increase the
potential review coverage for these patches.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-24 19:04 ` Paul Walmsley
@ 2019-05-24 19:05 ` Alan Mikhak
2019-05-25 8:24 ` Christoph Hellwig
0 siblings, 1 reply; 12+ messages in thread
From: Alan Mikhak @ 2019-05-24 19:05 UTC (permalink / raw)
To: Paul Walmsley; +Cc: Christoph Hellwig, linux-riscv, Palmer Dabbelt
The get_maintainers.pl script also suggests linux-riscv mailing list.
On Fri, May 24, 2019 at 12:04 PM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Thu, 23 May 2019, Christoph Hellwig wrote:
>
> > [trimming recipient list]
> >
> >
> > How is this related to arch/riscv?
>
> This was my doing: I suggested to Alan that he copy these messages to the
> linux-riscv mailing list. We're seeing interest from people who want to
> build PCIe cards based on RISC-V Linux, so I thought it might increase the
> potential review coverage for these patches.
>
>
> - Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-24 18:23 ` Alan Mikhak
@ 2019-05-25 8:23 ` Christoph Hellwig
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Hellwig @ 2019-05-25 8:23 UTC (permalink / raw)
To: Alan Mikhak; +Cc: Christoph Hellwig, linux-riscv, Palmer Dabbelt, Paul Walmsley
On Fri, May 24, 2019 at 11:23:04AM -0700, Alan Mikhak wrote:
> Chrisoph,
>
> These changes were implemented in Linux PCI Endpoint framework to
> exercise PCIe endpoint mode on RISCV.
Well, arch/riscv isn't involved in this patch (which having an interest
in the PCIe EP stuff I really like). I still don't see how it relates
to riscv except that you apparently have been able to use it on a
RISCV SOC somehow.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-24 19:05 ` Alan Mikhak
@ 2019-05-25 8:24 ` Christoph Hellwig
2019-05-28 16:20 ` Alan Mikhak
0 siblings, 1 reply; 12+ messages in thread
From: Christoph Hellwig @ 2019-05-25 8:24 UTC (permalink / raw)
To: Alan Mikhak; +Cc: Christoph Hellwig, linux-riscv, Palmer Dabbelt, Paul Walmsley
On Fri, May 24, 2019 at 12:05:24PM -0700, Alan Mikhak wrote:
> The get_maintainers.pl script also suggests linux-riscv mailing list.
For drivers/pci/endpoint stuff? That kinda sounds like a bug, can you
paste the output here?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-25 8:24 ` Christoph Hellwig
@ 2019-05-28 16:20 ` Alan Mikhak
2019-05-30 2:24 ` Palmer Dabbelt
0 siblings, 1 reply; 12+ messages in thread
From: Alan Mikhak @ 2019-05-28 16:20 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-riscv, Palmer Dabbelt, Paul Walmsley
On Sat, May 25, 2019 at 1:24 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, May 24, 2019 at 12:05:24PM -0700, Alan Mikhak wrote:
> > The get_maintainers.pl script also suggests linux-riscv mailing list.
>
> For drivers/pci/endpoint stuff? That kinda sounds like a bug, can you
> paste the output here?
Please see below output of get_maintainers.pl for all my patches
related to PCIe endpoint work. It seems get_maintainers.pl suggests
linux-riscv based on @sifive.com email address.
$ ./scripts/get_maintainer.pl 0001-Set-endpoint-controller-pointer-to-null.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT SUBSYSTEM)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT SUBSYSTEM)
Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
$ ./scripts/get_maintainer.pl
0001-Allocate-enough-space-for-fixed-size-BAR.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:8/8=100%)
Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
(commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
$ ./scripts/get_maintainer.pl 0001-Skip-odd-BAR-when-skipping-64bit-BAR.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:8/8=100%)
Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
(commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
$ ./scripts/get_maintainer.pl 0001-Clear-BAR-before-freeing-its-space.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:8/8=100%)
Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
(commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
$ ./scripts/get_maintainer.pl 0001-Add-DMA-to-Linux-PCI-EP-Framework.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
SUBSYSTEM,commit_signer:8/8=100%)
Arnd Bergmann <arnd@arndb.de> (supporter:CHAR and MISC DRIVERS)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:CHAR and
MISC DRIVERS)
Jingoo Han <jingoohan1@gmail.com> (maintainer:PCI DRIVER FOR SYNOPSYS
DESIGNWARE)
Gustavo Pimentel <gustavo.pimentel@synopsys.com> (maintainer:PCI
DRIVER FOR SYNOPSYS
DESIGNWARE,commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
$ ./scripts/get_maintainer.pl 0001-Fix-broken-pcitest-compilation.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT SUBSYSTEM)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
$ ./scripts/get_maintainer.pl 0002-Fix-compiler-warning-in-pcitest.patch
Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT SUBSYSTEM)
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT SUBSYSTEM)
Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-28 16:20 ` Alan Mikhak
@ 2019-05-30 2:24 ` Palmer Dabbelt
0 siblings, 0 replies; 12+ messages in thread
From: Palmer Dabbelt @ 2019-05-30 2:24 UTC (permalink / raw)
To: Christoph Hellwig, alan.mikhak; +Cc: linux-riscv, Paul Walmsley
On Tue, 28 May 2019 09:20:35 PDT (-0700), alan.mikhak@sifive.com wrote:
> On Sat, May 25, 2019 at 1:24 AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> On Fri, May 24, 2019 at 12:05:24PM -0700, Alan Mikhak wrote:
>> > The get_maintainers.pl script also suggests linux-riscv mailing list.
>>
>> For drivers/pci/endpoint stuff? That kinda sounds like a bug, can you
>> paste the output here?
>
> Please see below output of get_maintainers.pl for all my patches
> related to PCIe endpoint work. It seems get_maintainers.pl suggests
> linux-riscv based on @sifive.com email address.
>
> $ ./scripts/get_maintainer.pl 0001-Set-endpoint-controller-pointer-to-null.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT SUBSYSTEM)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT SUBSYSTEM)
> Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
>
> $ ./scripts/get_maintainer.pl
> 0001-Allocate-enough-space-for-fixed-size-BAR.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:8/8=100%)
> Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> (commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
> Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
> Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
>
> $ ./scripts/get_maintainer.pl 0001-Skip-odd-BAR-when-skipping-64bit-BAR.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:8/8=100%)
> Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> (commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
> Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
> Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
>
> $ ./scripts/get_maintainer.pl 0001-Clear-BAR-before-freeing-its-space.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:8/8=100%)
> Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> (commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
> Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
> Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
>
> $ ./scripts/get_maintainer.pl 0001-Add-DMA-to-Linux-PCI-EP-Framework.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:7/8=88%,authored:4/8=50%,added_lines:61/136=45%,removed_lines:39/63=62%)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT
> SUBSYSTEM,commit_signer:8/8=100%)
> Arnd Bergmann <arnd@arndb.de> (supporter:CHAR and MISC DRIVERS)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:CHAR and
> MISC DRIVERS)
> Jingoo Han <jingoohan1@gmail.com> (maintainer:PCI DRIVER FOR SYNOPSYS
> DESIGNWARE)
> Gustavo Pimentel <gustavo.pimentel@synopsys.com> (maintainer:PCI
> DRIVER FOR SYNOPSYS
> DESIGNWARE,commit_signer:2/8=25%,authored:2/8=25%,added_lines:68/136=50%,removed_lines:22/63=35%)
> Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> Wen Yang <wen.yang99@zte.com.cn> (commit_signer:1/8=12%,authored:1/8=12%)
> Kangjie Lu <kjlu@umn.edu> (commit_signer:1/8=12%,authored:1/8=12%)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
>
> $ ./scripts/get_maintainer.pl 0001-Fix-broken-pcitest-compilation.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT SUBSYSTEM)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
>
> $ ./scripts/get_maintainer.pl 0002-Fix-compiler-warning-in-pcitest.patch
> Kishon Vijay Abraham I <kishon@ti.com> (supporter:PCI ENDPOINT SUBSYSTEM)
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> (supporter:PCI ENDPOINT SUBSYSTEM)
> Palmer Dabbelt <palmer@sifive.com> (supporter:SIFIVE DRIVERS)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:SIFIVE DRIVERS)
> linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> linux-riscv@lists.infradead.org (open list:SIFIVE DRIVERS)
I'm guessing it's this
SIFIVE DRIVERS
M: Palmer Dabbelt <palmer@sifive.com>
M: Paul Walmsley <paul.walmsley@sifive.com>
L: linux-riscv@lists.infradead.org
T: git git://github.com/sifive/riscv-linux.git
S: Supported
K: sifive
N: sifive
which, if I understand correctly, will match any "sifive" in the entire patch
body. I think the options are to either drop the K line, or to attempt a regex
that doesn't match the sifive part. This appears to at least stop the matches
for me
diff --git a/MAINTAINERS b/MAINTAINERS
index 2c2fce72e694..003570e1f8d4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14131,7 +14131,7 @@ M: Paul Walmsley <paul.walmsley@sifive.com>
L: linux-riscv@lists.infradead.org
T: git git://github.com/sifive/riscv-linux.git
S: Supported
-K: sifive
+K: ^[@]sifive
N: sifive
SILEAD TOUCHSCREEN DRIVER
Anyone have a better idea?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null
2019-05-23 21:45 [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null Alan Mikhak
2019-05-23 23:57 ` Alan Mikhak
2019-05-24 6:38 ` Christoph Hellwig
@ 2019-06-11 10:07 ` Lorenzo Pieralisi
2 siblings, 0 replies; 12+ messages in thread
From: Lorenzo Pieralisi @ 2019-06-11 10:07 UTC (permalink / raw)
To: Alan Mikhak
Cc: linux-pci, palmer, linux-kernel, kishon, paul.walmsley, linux-riscv
On Thu, May 23, 2019 at 02:45:44PM -0700, Alan Mikhak wrote:
> Set endpoint controller pointer to null in pci_epc_remove_epf()
> to avoid -EBUSY on subsequent call to pci_epc_add_epf().
>
> Requires checking for null endpoint function pointer.
>
> Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
> ---
> drivers/pci/endpoint/pci-epc-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to pci/endpoint for v5.3, thanks.
Lorenzo
> diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> index e4712a0f249c..2091508c1620 100644
> --- a/drivers/pci/endpoint/pci-epc-core.c
> +++ b/drivers/pci/endpoint/pci-epc-core.c
> @@ -519,11 +519,12 @@ void pci_epc_remove_epf(struct pci_epc *epc, struct pci_epf *epf)
> {
> unsigned long flags;
>
> - if (!epc || IS_ERR(epc))
> + if (!epc || IS_ERR(epc) || !epf)
> return;
>
> spin_lock_irqsave(&epc->lock, flags);
> list_del(&epf->list);
> + epf->epc = NULL;
> spin_unlock_irqrestore(&epc->lock, flags);
> }
> EXPORT_SYMBOL_GPL(pci_epc_remove_epf);
> --
> 2.7.4
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-06-11 10:08 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 21:45 [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null Alan Mikhak
2019-05-23 23:57 ` Alan Mikhak
2019-05-24 8:41 ` Kishon Vijay Abraham I
2019-05-24 6:38 ` Christoph Hellwig
2019-05-24 18:23 ` Alan Mikhak
2019-05-25 8:23 ` Christoph Hellwig
2019-05-24 19:04 ` Paul Walmsley
2019-05-24 19:05 ` Alan Mikhak
2019-05-25 8:24 ` Christoph Hellwig
2019-05-28 16:20 ` Alan Mikhak
2019-05-30 2:24 ` Palmer Dabbelt
2019-06-11 10:07 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).