From: bmeng.cn@gmail.com (Bin Meng)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] RISC-V: Build flat and compressed kernel images
Date: Thu, 22 Nov 2018 09:43:12 +0800 [thread overview]
Message-ID: <CAEUhbmW08WfTQRVSAaC6SRWhZmrUTAm9b8wefuMMbg8dGeKZVA@mail.gmail.com> (raw)
In-Reply-To: <mhng-7be4f47d-bc3a-4073-a6db-dc5588304d2d@palmer-si-x1c4>
Hi Palmer,
On Thu, Nov 22, 2018 at 12:28 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Tue, 20 Nov 2018 21:06:18 PST (-0800), bmeng.cn at gmail.com wrote:
> > On Mon, Nov 12, 2018 at 1:55 PM Anup Patel <anup@brainfault.org> wrote:
> >>
> >> This patch extends Linux RISC-V build system to build and install:
> >> Image - Flat uncompressed kernel image
> >> Image.gz - Flat and GZip compressed kernel image
> >>
> >> Quiet a few bootloaders (such as Uboot, UEFI, etc) are capable of
> >
> > nits: U-Boot
> >
> >> booting flat and compressed kernel images. In case of Uboot, booting
> >
> > nits: U-Boot
>
> Thanks for the review. The PR has already been tagged, but it's not scheduled
> to be sent out until later today. I generally try to avoid rewriting the tags
> unless there's something major that's wrong, so unless you feel very strongly
> about this then I think I'll let it stand.
>
> Let me know if this is a big deal for you, I can rewrite things.
>
> >> Image or Image.gz is achieved using bootm command.
> >>
> >> The flat and uncompressed kernel image (i.e. Image) is very useful
> >> in pre-silicon developent and testing because we can create back-door
> >> HEX files for RAM on FPGAs from Image.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >> arch/riscv/Makefile | 15 ++++++++-
> >> arch/riscv/boot/.gitignore | 2 ++
> >> arch/riscv/boot/Makefile | 33 ++++++++++++++++++
> >> arch/riscv/boot/install.sh | 60 +++++++++++++++++++++++++++++++++
> >> arch/riscv/kernel/head.S | 10 ++++++
> >> arch/riscv/kernel/vmlinux.lds.S | 2 +-
> >> 6 files changed, 120 insertions(+), 2 deletions(-)
> >> create mode 100644 arch/riscv/boot/.gitignore
> >> create mode 100644 arch/riscv/boot/Makefile
> >> create mode 100644 arch/riscv/boot/install.sh
> >>
> >
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Tested with U-Boot s-mode on QEMU virt, using bootm to boot the kernel
> > Tested-by: Bin Meng <bmeng.cn@gmail.com>
>
> I also won't include the tags unless I rewrite the tags.
>
> Thanks for the review!
Thanks. Let's go with this as it's a minor nits.
Regards,
Bin
WARNING: multiple messages have this Message-ID (diff)
From: Bin Meng <bmeng.cn@gmail.com>
To: palmer@sifive.com
Cc: aou@eecs.berkeley.edu, Anup Patel <anup@brainfault.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
hch@infradead.org, atish.patra@wdc.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: Build flat and compressed kernel images
Date: Thu, 22 Nov 2018 09:43:12 +0800 [thread overview]
Message-ID: <CAEUhbmW08WfTQRVSAaC6SRWhZmrUTAm9b8wefuMMbg8dGeKZVA@mail.gmail.com> (raw)
Message-ID: <20181122014312.MTM1i0iMYk1hsD58Uy_NzlzCr2TgsjEgSBAOaZOMN7w@z> (raw)
In-Reply-To: <mhng-7be4f47d-bc3a-4073-a6db-dc5588304d2d@palmer-si-x1c4>
Hi Palmer,
On Thu, Nov 22, 2018 at 12:28 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Tue, 20 Nov 2018 21:06:18 PST (-0800), bmeng.cn@gmail.com wrote:
> > On Mon, Nov 12, 2018 at 1:55 PM Anup Patel <anup@brainfault.org> wrote:
> >>
> >> This patch extends Linux RISC-V build system to build and install:
> >> Image - Flat uncompressed kernel image
> >> Image.gz - Flat and GZip compressed kernel image
> >>
> >> Quiet a few bootloaders (such as Uboot, UEFI, etc) are capable of
> >
> > nits: U-Boot
> >
> >> booting flat and compressed kernel images. In case of Uboot, booting
> >
> > nits: U-Boot
>
> Thanks for the review. The PR has already been tagged, but it's not scheduled
> to be sent out until later today. I generally try to avoid rewriting the tags
> unless there's something major that's wrong, so unless you feel very strongly
> about this then I think I'll let it stand.
>
> Let me know if this is a big deal for you, I can rewrite things.
>
> >> Image or Image.gz is achieved using bootm command.
> >>
> >> The flat and uncompressed kernel image (i.e. Image) is very useful
> >> in pre-silicon developent and testing because we can create back-door
> >> HEX files for RAM on FPGAs from Image.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >> arch/riscv/Makefile | 15 ++++++++-
> >> arch/riscv/boot/.gitignore | 2 ++
> >> arch/riscv/boot/Makefile | 33 ++++++++++++++++++
> >> arch/riscv/boot/install.sh | 60 +++++++++++++++++++++++++++++++++
> >> arch/riscv/kernel/head.S | 10 ++++++
> >> arch/riscv/kernel/vmlinux.lds.S | 2 +-
> >> 6 files changed, 120 insertions(+), 2 deletions(-)
> >> create mode 100644 arch/riscv/boot/.gitignore
> >> create mode 100644 arch/riscv/boot/Makefile
> >> create mode 100644 arch/riscv/boot/install.sh
> >>
> >
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Tested with U-Boot s-mode on QEMU virt, using bootm to boot the kernel
> > Tested-by: Bin Meng <bmeng.cn@gmail.com>
>
> I also won't include the tags unless I rewrite the tags.
>
> Thanks for the review!
Thanks. Let's go with this as it's a minor nits.
Regards,
Bin
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-22 1:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 5:55 [PATCH] RISC-V: Build flat and compressed kernel images Anup Patel
2018-11-12 5:55 ` Anup Patel
2018-11-16 21:13 ` Palmer Dabbelt
2018-11-16 21:13 ` Palmer Dabbelt
2018-11-17 3:32 ` Anup Patel
2018-11-17 3:32 ` Anup Patel
2018-11-19 20:10 ` Palmer Dabbelt
2018-11-19 20:10 ` Palmer Dabbelt
2018-11-21 5:06 ` Bin Meng
2018-11-21 5:06 ` Bin Meng
2018-11-21 16:28 ` Palmer Dabbelt
2018-11-21 16:28 ` Palmer Dabbelt
2018-11-22 1:43 ` Bin Meng [this message]
2018-11-22 1:43 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmW08WfTQRVSAaC6SRWhZmrUTAm9b8wefuMMbg8dGeKZVA@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).