* [PATCH] riscv: dts: Re-organize SPI DT nodes
@ 2019-06-24 11:24 Yash Shah
2019-06-24 21:23 ` Paul Walmsley
0 siblings, 1 reply; 4+ messages in thread
From: Yash Shah @ 2019-06-24 11:24 UTC (permalink / raw)
To: robh+dt, paul.walmsley, devicetree, linux-riscv, linux-kernel
Cc: mark.rutland, sachin.ghadi, Yash Shah, palmer, aou
As per the General convention, define only device DT node in SOC DTSi
file with status = "disabled" and enable device in Board DTS file with
status = "okay"
Reported-by: Anup Patel <anup@brainfault.org>
Signed-off-by: Yash Shah <yash.shah@sifive.com>
---
arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 3 +++
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
2 files changed, 4 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index 4e8fbde..270f6e8 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -203,6 +203,7 @@
interrupt-parent = <&plic0>;
interrupts = <51>;
clocks = <&prci PRCI_CLK_TLCLK>;
+ status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
};
@@ -213,6 +214,7 @@
interrupt-parent = <&plic0>;
interrupts = <52>;
clocks = <&prci PRCI_CLK_TLCLK>;
+ status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
};
@@ -222,6 +224,7 @@
interrupt-parent = <&plic0>;
interrupts = <6>;
clocks = <&prci PRCI_CLK_TLCLK>;
+ status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
};
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 4da8870..73e2af6 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -43,6 +43,7 @@
};
&qspi0 {
+ status = "okay";
flash@0 {
compatible = "issi,is25wp256", "jedec,spi-nor";
reg = <0>;
--
1.9.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: Re-organize SPI DT nodes
2019-06-24 11:24 [PATCH] riscv: dts: Re-organize SPI DT nodes Yash Shah
@ 2019-06-24 21:23 ` Paul Walmsley
2019-06-25 3:31 ` Anup Patel
2019-06-25 8:34 ` Yash Shah
0 siblings, 2 replies; 4+ messages in thread
From: Paul Walmsley @ 2019-06-24 21:23 UTC (permalink / raw)
To: Yash Shah
Cc: mark.rutland, devicetree, aou, palmer, linux-kernel,
sachin.ghadi, robh+dt, linux-riscv
On Mon, 24 Jun 2019, Yash Shah wrote:
> As per the General convention, define only device DT node in SOC DTSi
> file with status = "disabled" and enable device in Board DTS file with
> status = "okay"
>
> Reported-by: Anup Patel <anup@brainfault.org>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
This is a good start, but should also cover the other I/O devices in the
chip DT file. The mandatory internal devices, like the PRCI and PLIC, can
stay the way they are.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: Re-organize SPI DT nodes
2019-06-24 21:23 ` Paul Walmsley
@ 2019-06-25 3:31 ` Anup Patel
2019-06-25 8:34 ` Yash Shah
1 sibling, 0 replies; 4+ messages in thread
From: Anup Patel @ 2019-06-25 3:31 UTC (permalink / raw)
To: Paul Walmsley
Cc: Mark Rutland, devicetree, Albert Ou, Palmer Dabbelt,
linux-kernel@vger.kernel.org List, sachin.ghadi, Yash Shah,
Rob Herring, linux-riscv
On Tue, Jun 25, 2019 at 2:53 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Mon, 24 Jun 2019, Yash Shah wrote:
>
> > As per the General convention, define only device DT node in SOC DTSi
> > file with status = "disabled" and enable device in Board DTS file with
> > status = "okay"
> >
> > Reported-by: Anup Patel <anup@brainfault.org>
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
>
> This is a good start, but should also cover the other I/O devices in the
> chip DT file. The mandatory internal devices, like the PRCI and PLIC, can
> stay the way they are.
Yes, this convention only applies to SoC devices with external connections
so PRCI, PLIC, and CLINT DT nodes are not required to follow this.
Eventually, this convention helps when we have multiple boards of same
SOC and each board having different set of peripherals connections.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: Re-organize SPI DT nodes
2019-06-24 21:23 ` Paul Walmsley
2019-06-25 3:31 ` Anup Patel
@ 2019-06-25 8:34 ` Yash Shah
1 sibling, 0 replies; 4+ messages in thread
From: Yash Shah @ 2019-06-25 8:34 UTC (permalink / raw)
To: Paul Walmsley
Cc: Mark Rutland, devicetree, Albert Ou, Palmer Dabbelt,
linux-kernel@vger.kernel.org List, Sachin Ghadi, Rob Herring,
linux-riscv
On Tue, Jun 25, 2019 at 2:53 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Mon, 24 Jun 2019, Yash Shah wrote:
>
> > As per the General convention, define only device DT node in SOC DTSi
> > file with status = "disabled" and enable device in Board DTS file with
> > status = "okay"
> >
> > Reported-by: Anup Patel <anup@brainfault.org>
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
>
> This is a good start, but should also cover the other I/O devices in the
> chip DT file. The mandatory internal devices, like the PRCI and PLIC, can
> stay the way they are.
Ok, I will send another patch which will cover the other I/O devices
as well. Please ignore this patch.
- Yash
>
>
> - Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-25 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24 11:24 [PATCH] riscv: dts: Re-organize SPI DT nodes Yash Shah
2019-06-24 21:23 ` Paul Walmsley
2019-06-25 3:31 ` Anup Patel
2019-06-25 8:34 ` Yash Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).