linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-riscv@lists.infradead.org
Subject: warning in ./arch/riscv/include/asm/module.h
Date: Wed, 7 Nov 2018 22:12:09 +0100	[thread overview]
Message-ID: <CAK8P3a1hXOkL69qyu6PP3KM=ax1kVUtm5QQn1+xoExjONC_1fQ@mail.gmail.com> (raw)
In-Reply-To: <CAEn-LTr__59kApb=kkm7aH0z4w-J9xG1rzhK1xDk3xCGSis9SQ@mail.gmail.com>

On Wed, Nov 7, 2018 at 7:26 PM David Abdurachmanov
<david.abdurachmanov@gmail.com> wrote:
> On Mon, Nov 5, 2018 at 10:02 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > On 11/5/18, David Abdurachmanov <david.abdurachmanov@gmail.com> wrote:
> > > BUILDSTDERR: net/core/rtnetlink.c: In function 'rtnl_newlink':
> > > BUILDSTDERR: net/core/rtnetlink.c:3224:1: warning: the frame size of
> > > 1280 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> > > BUILDSTDERR:  }
> > > BUILDSTDERR:  ^
> >
> > This may be much harder. I've fixed this type of issue for arm and
> > x86, but it requires a much more detailed analysis of what's going
> > on. This is often a compiler bug. Which compiler version are you
> > using?
>
> Ops. I didn't indent to copy this one. This one is expected as Fedora
> has CONFIG_FRAME_WARN set to 1024. Only couple architectures
> set that to higher number (2048).

Om 64-bit architectures, setting it to 1024 causes lots of extra
warnings, since we have certain functions that put an array of
128 pointers on the stack. The default value in the kernel is 2048,
but I've managed to reduce it to 1280 in the past. I never managed
to get all the patches for that included, but I think that would be
a useful number if Fedora really wants to have something lower
than the default (and then fix the outliers).

       Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: David Abdurachmanov <david.abdurachmanov@gmail.com>
Cc: linux-riscv@lists.infradead.org
Subject: Re: warning in ./arch/riscv/include/asm/module.h
Date: Wed, 7 Nov 2018 22:12:09 +0100	[thread overview]
Message-ID: <CAK8P3a1hXOkL69qyu6PP3KM=ax1kVUtm5QQn1+xoExjONC_1fQ@mail.gmail.com> (raw)
Message-ID: <20181107211209.jRo-JQlhstnYl7u0YkyM6KqSBWcm4zmWjnPnuprYFwk@z> (raw)
In-Reply-To: <CAEn-LTr__59kApb=kkm7aH0z4w-J9xG1rzhK1xDk3xCGSis9SQ@mail.gmail.com>

On Wed, Nov 7, 2018 at 7:26 PM David Abdurachmanov
<david.abdurachmanov@gmail.com> wrote:
> On Mon, Nov 5, 2018 at 10:02 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > On 11/5/18, David Abdurachmanov <david.abdurachmanov@gmail.com> wrote:
> > > BUILDSTDERR: net/core/rtnetlink.c: In function 'rtnl_newlink':
> > > BUILDSTDERR: net/core/rtnetlink.c:3224:1: warning: the frame size of
> > > 1280 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> > > BUILDSTDERR:  }
> > > BUILDSTDERR:  ^
> >
> > This may be much harder. I've fixed this type of issue for arm and
> > x86, but it requires a much more detailed analysis of what's going
> > on. This is often a compiler bug. Which compiler version are you
> > using?
>
> Ops. I didn't indent to copy this one. This one is expected as Fedora
> has CONFIG_FRAME_WARN set to 1024. Only couple architectures
> set that to higher number (2048).

Om 64-bit architectures, setting it to 1024 causes lots of extra
warnings, since we have certain functions that put an array of
128 pointers on the stack. The default value in the kernel is 2048,
but I've managed to reduce it to 1280 in the past. I never managed
to get all the patches for that included, but I think that would be
a useful number if Fedora really wants to have something lower
than the default (and then fix the outliers).

       Arnd

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2018-11-07 21:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 14:51 warning in ./arch/riscv/include/asm/module.h David Abdurachmanov
2018-11-05 14:51 ` David Abdurachmanov
2018-11-05 21:02 ` Arnd Bergmann
2018-11-05 21:02   ` Arnd Bergmann
2018-11-07 18:25   ` David Abdurachmanov
2018-11-07 18:25     ` David Abdurachmanov
2018-11-07 21:12     ` Arnd Bergmann [this message]
2018-11-07 21:12       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a1hXOkL69qyu6PP3KM=ax1kVUtm5QQn1+xoExjONC_1fQ@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).