* [PATCH] riscv: remove unused variable in ftrace
@ 2018-12-06 10:26 David Abdurachmanov
2018-12-06 19:20 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: David Abdurachmanov @ 2018-12-06 10:26 UTC (permalink / raw)
To: palmer, aou, linux-riscv, linux-kernel; +Cc: David Abdurachmanov
Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
Fedora 30/RISCV.
[..]
BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
BUILDSTDERR: int err;
BUILDSTDERR: ^~~
[..]
Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
arch/riscv/kernel/ftrace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/kernel/ftrace.c b/arch/riscv/kernel/ftrace.c
index c433f6d3dd64..a840b7d074f7 100644
--- a/arch/riscv/kernel/ftrace.c
+++ b/arch/riscv/kernel/ftrace.c
@@ -132,7 +132,6 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
{
unsigned long return_hooker = (unsigned long)&return_to_handler;
unsigned long old;
- int err;
if (unlikely(atomic_read(¤t->tracing_graph_pause)))
return;
--
2.19.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: remove unused variable in ftrace
2018-12-06 10:26 [PATCH] riscv: remove unused variable in ftrace David Abdurachmanov
@ 2018-12-06 19:20 ` Olof Johansson
2018-12-07 1:07 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2018-12-06 19:20 UTC (permalink / raw)
To: David Abdurachmanov
Cc: linux-riscv, Palmer Dabbelt, Steven Rostedt,
Linux Kernel Mailing List, Albert Ou
On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
<david.abdurachmanov@gmail.com> wrote:
>
> Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> Fedora 30/RISCV.
>
> [..]
> BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> BUILDSTDERR: int err;
> BUILDSTDERR: ^~~
> [..]
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
Please add a:
Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
function_graph_enter()")
Reviewed-by: Olof Johansson <olof@lixom.net>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: remove unused variable in ftrace
2018-12-06 19:20 ` Olof Johansson
@ 2018-12-07 1:07 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2018-12-07 1:07 UTC (permalink / raw)
To: Olof Johansson
Cc: linux-riscv, Palmer Dabbelt, Linux Kernel Mailing List,
Albert Ou, David Abdurachmanov
On Thu, 6 Dec 2018 11:20:31 -0800
Olof Johansson <olof@lixom.net> wrote:
> On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
> <david.abdurachmanov@gmail.com> wrote:
> >
> > Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> > Fedora 30/RISCV.
> >
> > [..]
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> > BUILDSTDERR: int err;
> > BUILDSTDERR: ^~~
Bah. I could have sworn I checked for all the error messages when I did
my cross-compiling of the architectures. I fixed this issue in other
places, not sure how I missed riscv.
Thanks for fixing it.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> > [..]
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>
> Please add a:
> Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
> function_graph_enter()")
> Reviewed-by: Olof Johansson <olof@lixom.net>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-07 1:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 10:26 [PATCH] riscv: remove unused variable in ftrace David Abdurachmanov
2018-12-06 19:20 ` Olof Johansson
2018-12-07 1:07 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).