linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: Zhangjin Wu <falcon@tinylab.org>,
	Palmer Dabbelt <palmer@rivosinc.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] tools/nolibc: riscv: Fix up compile error for rv32
Date: Fri, 19 May 2023 12:19:10 +0200	[thread overview]
Message-ID: <ZGdNHv/QmAGBIYsM@1wt.eu> (raw)
In-Reply-To: <c5140f54-99f2-4d7f-8b53-bd3cd1093727@t-8ch.de>

On Fri, May 19, 2023 at 12:11:00PM +0200, Thomas Weißschuh wrote:
> Hi Willy,
> 
> On 2023-05-19 11:40:30+0200, Willy Tarreau wrote:
> > Hi Zhangjin,
> > 
> > On Fri, May 19, 2023 at 01:00:18AM +0800, Zhangjin Wu wrote:
> > > Hi, Willy
> > > 
> > > nolibc for riscv is only tested for rv64 currently (see
> > > tools/testing/selftests/nolibc/Makefile), this patchset tries to let it
> > > compile for rv32, but still not pass the nolibc selftest:
> > > 
> > > * The first patch uses lw/sw instead of ld/sd for rv32 and verse-vice for rv64
> > >     * This patch may conflict with the stackprotector patch [1], because
> > >       both of them changed the _start assembly in arch-riscv.h
> > 
> > That's quite embarrassing, I'm having to trace of that series here. Now
> > I can find it in my LKML archives, but I don't have the direct message and
> > didn't spot the other ones. I'll have to investigate, thanks for notifying
> > me! I'm CCing Thomas, I will check with him how to best merge the two.
> 
> I think the conflict should be trivial to fix.
> 
> I can also resend my series or just the single riscv patch.

OK then I'll pick Zhangjin's series and will apply yours on top of it.
Do not bother resending the whole series, only the riscv patch will be
sufficient, I have the rest of your series in my lkml mbox.

Thanks!
Willy

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-05-19 10:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 17:00 [PATCH 0/2] tools/nolibc: riscv: Fix up compile error for rv32 Zhangjin Wu
2023-05-18 17:02 ` [PATCH 1/2] tools/nolibc: riscv: Fix up load/store instructions " Zhangjin Wu
2023-05-20  8:50   ` Willy Tarreau
2023-05-20  9:11     ` Zhangjin Wu
2023-05-20  9:33       ` Willy Tarreau
2023-05-20 10:05         ` Zhangjin Wu
2023-05-20 10:20           ` Willy Tarreau
2023-05-18 17:03 ` [PATCH 2/2] tools/nolibc: riscv: Support __NR_llseek " Zhangjin Wu
2023-05-19  9:40 ` [PATCH 0/2] tools/nolibc: riscv: Fix up compile error " Willy Tarreau
2023-05-19 10:11   ` Thomas Weißschuh
2023-05-19 10:19     ` Willy Tarreau [this message]
2023-05-20  7:18       ` Thomas Weißschuh
2023-05-20  8:46         ` Willy Tarreau
2023-05-20 14:31   ` Zhangjin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGdNHv/QmAGBIYsM@1wt.eu \
    --to=w@1wt.eu \
    --cc=aou@eecs.berkeley.edu \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulmck@kernel.org \
    --cc=thomas@t-8ch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).