From: Paul Walmsley <paul.walmsley@sifive.com>
To: satish kumar <gsatish.ldd@gmail.com>
Cc: linux-riscv@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH] RISCV:IRQ: Adds Err column to /proc/interrupts
Date: Mon, 7 Jan 2019 20:17:32 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1901072013320.14547@viisi.sifive.com> (raw)
In-Reply-To: <CAK1XJzWreGAXY+1x=DGwcfea2Bz51DrYidXJGLiJg3g0UYRWPw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
On Tue, 8 Jan 2019, satish kumar wrote:
> On Tue, 8 Jan 2019 at 00:09, Paul Walmsley <paul.walmsley@sifive.com> wrote:
> >
> > On Mon, 7 Jan 2019, satish kumar wrote:
> >
> > > On Mon, 7 Jan 2019 at 12:04, Paul Walmsley <paul.walmsley@sifive.com> wrote:
> > > On Sat, 5 Jan 2019, G SatishKumar wrote:
> > >
> > > > This patch adds extra row showing error count to output of
> > > > /proc/interrupts using seq_printf().
> > > > seq_printf() API is used when printing to /proc/ files as a
> > > > helper functions to return formatted output from ‘proc_read’
> > > > callback.
> > > >
> > > > It adds Err: row to /proc/interrupts
> > >
> > > Why? It's always going to print "0" with this patch. Does the missing
> > > line break something?
> > >
> > > It adds extra info in the /proc/interrupts which provides error count.
> > > It is used for printing information.
> >
> > If this patch kept track of interrupt-related errors, I'd agree. But if
> > it always prints 0, as it currently does, then there doesn't seem much
> > point?
> Yes, it does. This patch gives information of Interrupt error count
> in all cases .
NAK from me until either
1. the patch is modified to increment the IRQ error count when a bad IRQ
occurs, or
2. someone finds a common userspace tool that breaks if the "Err:" field
isn't present
- Paul
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-01-08 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 13:51 [PATCH] RISCV:IRQ: Adds Err column to /proc/interrupts G SatishKumar
2019-01-07 6:34 ` Paul Walmsley
[not found] ` <CAK1XJzUHgkSe9GODaUHH89b4XD0zW0EvO5RMzt5f7hpWiVsfNg@mail.gmail.com>
2019-01-07 18:39 ` Paul Walmsley
2019-01-08 3:45 ` satish kumar
2019-01-08 4:17 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1901072013320.14547@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=gsatish.ldd@gmail.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).