* [PATCH] riscv: Remove gate area stubs
@ 2019-06-27 4:46 Andy Lutomirski
2019-06-27 9:00 ` Christoph Hellwig
2019-06-27 22:52 ` Paul Walmsley
0 siblings, 2 replies; 3+ messages in thread
From: Andy Lutomirski @ 2019-06-27 4:46 UTC (permalink / raw)
To: LKML
Cc: Florian Weimer, Albert Ou, Kees Cook, Jann Horn, x86,
Palmer Dabbelt, Andy Lutomirski, linux-riscv
Since commit a6c19dfe3994 ("arm64,ia64,ppc,s390,sh,tile,um,x86,mm:
remove default gate area"), which predates riscv's inclusion in
Linux by almost three years, the default behavior wrt the gate area
is sane. Remove riscv's gate area stubs.
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
arch/riscv/include/asm/page.h | 4 ----
arch/riscv/kernel/vdso.c | 19 -------------------
2 files changed, 23 deletions(-)
diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h
index 8ddb6c7fedac..d3e5f6c0c21a 100644
--- a/arch/riscv/include/asm/page.h
+++ b/arch/riscv/include/asm/page.h
@@ -115,8 +115,4 @@ extern unsigned long min_low_pfn;
#include <asm-generic/memory_model.h>
#include <asm-generic/getorder.h>
-/* vDSO support */
-/* We do define AT_SYSINFO_EHDR but don't use the gate mechanism */
-#define __HAVE_ARCH_GATE_AREA
-
#endif /* _ASM_RISCV_PAGE_H */
diff --git a/arch/riscv/kernel/vdso.c b/arch/riscv/kernel/vdso.c
index a0084c36d270..c9c21e0d5641 100644
--- a/arch/riscv/kernel/vdso.c
+++ b/arch/riscv/kernel/vdso.c
@@ -92,22 +92,3 @@ const char *arch_vma_name(struct vm_area_struct *vma)
return "[vdso]";
return NULL;
}
-
-/*
- * Function stubs to prevent linker errors when AT_SYSINFO_EHDR is defined
- */
-
-int in_gate_area_no_mm(unsigned long addr)
-{
- return 0;
-}
-
-int in_gate_area(struct mm_struct *mm, unsigned long addr)
-{
- return 0;
-}
-
-struct vm_area_struct *get_gate_vma(struct mm_struct *mm)
-{
- return NULL;
-}
--
2.21.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Remove gate area stubs
2019-06-27 4:46 [PATCH] riscv: Remove gate area stubs Andy Lutomirski
@ 2019-06-27 9:00 ` Christoph Hellwig
2019-06-27 22:52 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-06-27 9:00 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Florian Weimer, Albert Ou, Kees Cook, Jann Horn, x86, LKML,
Palmer Dabbelt, linux-riscv
On Wed, Jun 26, 2019 at 09:46:18PM -0700, Andy Lutomirski wrote:
> Since commit a6c19dfe3994 ("arm64,ia64,ppc,s390,sh,tile,um,x86,mm:
> remove default gate area"), which predates riscv's inclusion in
> Linux by almost three years, the default behavior wrt the gate area
> is sane. Remove riscv's gate area stubs.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Remove gate area stubs
2019-06-27 4:46 [PATCH] riscv: Remove gate area stubs Andy Lutomirski
2019-06-27 9:00 ` Christoph Hellwig
@ 2019-06-27 22:52 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2019-06-27 22:52 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Florian Weimer, Albert Ou, Kees Cook, Jann Horn, x86, LKML, hch,
Palmer Dabbelt, linux-riscv
On Wed, 26 Jun 2019, Andy Lutomirski wrote:
> Since commit a6c19dfe3994 ("arm64,ia64,ppc,s390,sh,tile,um,x86,mm:
> remove default gate area"), which predates riscv's inclusion in
> Linux by almost three years, the default behavior wrt the gate area
> is sane. Remove riscv's gate area stubs.
>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Thanks, queued for v5.3 with Christoph's Reviewed-by:.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-27 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 4:46 [PATCH] riscv: Remove gate area stubs Andy Lutomirski
2019-06-27 9:00 ` Christoph Hellwig
2019-06-27 22:52 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).