linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul.walmsley@sifive.com>
To: Alan Mikhak <alan.mikhak@sifive.com>
Cc: jason@lakedaemon.net, maz@kernel.org, palmer@sifive.com,
	linux-kernel@vger.kernel.org, hch@infradead.org,
	linux-riscv@lists.infradead.org, tglx@linutronix.de
Subject: Re: [PATCH] irqchip: Skip contexts other supervisor in plic_init()
Date: Wed, 23 Oct 2019 11:54:54 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910231152580.16536@viisi.sifive.com> (raw)
In-Reply-To: <1571847755-20388-1-git-send-email-alan.mikhak@sifive.com>

+ hch

On Wed, 23 Oct 2019, Alan Mikhak wrote:

> From: Alan Mikhak <alan.mikhak@sifive.com>
> 
> Modify plic_init() to skip .dts interrupt contexts other
> than supervisor external interrupt.

Might be good to explain the motivation here.

> 
> Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
> ---
>  drivers/irqchip/irq-sifive-plic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index c72c036aea76..5f2a773d5669 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -251,8 +251,8 @@ static int __init plic_init(struct device_node *node,
>  			continue;
>  		}
>  
> -		/* skip context holes */
> -		if (parent.args[0] == -1)
> +		/* skip contexts other than supervisor external interrupt */
> +		if (parent.args[0] != IRQ_S_EXT)
>  			continue;

Will this need to change for RISC-V M-mode Linux support?  

https://lore.kernel.org/linux-riscv/20191017173743.5430-1-hch@lst.de/


- Paul



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2019-10-23 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 16:22 [PATCH] irqchip: Skip contexts other supervisor in plic_init() Alan Mikhak
2019-10-23 18:54 ` Paul Walmsley [this message]
2019-10-23 21:34   ` Alan Mikhak
2019-10-24  2:21     ` Paul Walmsley
2019-10-23 22:07   ` Palmer Dabbelt
2019-10-24  1:30     ` Christoph Hellwig
2019-10-24  6:51       ` Marc Zyngier
2019-10-24  7:03         ` Christoph Hellwig
2019-10-24  7:27           ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.9999.1910231152580.16536@viisi.sifive.com \
    --to=paul.walmsley@sifive.com \
    --cc=alan.mikhak@sifive.com \
    --cc=hch@infradead.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=palmer@sifive.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).