From: mick@ics.forth.gr (Nick Kossifidis)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] RISC-V: Update Kconfig to better handle CMDLINE
Date: Fri, 09 Nov 2018 20:34:00 +0200 [thread overview]
Message-ID: <ebe1db4d71a42711acb212013fd0fc2b@mailhost.ics.forth.gr> (raw)
In-Reply-To: <20181004113230.7995-1-mick@ics.forth.gr>
Hello Palmer,
???? 2018-10-04 14:32, Nick Kossifidis ??????:
> Add a menu to chose how the built-in command line will be used and
> add CMDLINE_EXTEND for compatibility with FDT code.
>
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> ---
> arch/riscv/Kconfig | 45 ++++++++++++++++++++++++---------------------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 82172bf85..cce141552 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -218,39 +218,42 @@ endmenu
>
> menu "Boot options"
>
> -config CMDLINE_BOOL
> - bool "Built-in kernel command line"
> +config CMDLINE
> + string "Built-in kernel command line"
> help
> For most platforms, it is firmware or second stage bootloader
> that by default specifies the kernel command line options.
> However, it might be necessary or advantageous to either override
> - the default kernel command line or add a few extra options to it.
> - For such cases, this option allows hardcoding command line options
> - directly into the kernel.
> + the provided kernel command line or add a few extra options to it.
> + For such cases, it is possible to define a built-in command line
> + here and chose how the kernel should use it later on.
>
> - For that, choose 'Y' here and fill in the extra boot parameters
> - in CONFIG_CMDLINE.
> +choice
> + prompt "Built-in command line usage" if CMDLINE != ""
> + default CMDLINE_FALLBACK
> + help
> + Chose how the kernel will handle the provided built-in command
> + line.
>
> - The built-in options will be concatenated to the default command
> - line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
> - command line will be ignored and replaced by the built-in string.
> +config CMDLINE_FALLBACK
> + bool "Fallback"
> + help
> + Use the built-in command line as fallback in case we get nothing
> + from the boot loader.
>
> -config CMDLINE
> - string "Built-in kernel command string"
> - depends on CMDLINE_BOOL
> - default ""
> +config CMDLINE_EXTEND
> + bool "Extension"
> help
> - Supply command-line options at build time by entering them here.
> + Use the built-in command line as an extension of the command line
> + provided by the boot loader.
>
> config CMDLINE_FORCE
> - bool "Built-in command line overrides bootloader arguments"
> - depends on CMDLINE_BOOL
> + bool "Forced"
> help
> - Set this option to 'Y' to have the kernel ignore the bootloader
> - or firmware command line. Instead, the built-in command line
> - will be used exclusively.
> + Use the built-in command line in place of the command line
> + provided by the boot loader.
>
> - If you don't know what to do here, say N.
> +endchoice
>
> endmenu
Since we'll be using FDT only for handling cmdline, this one is still
needed
because FDT code uses CMDLINE_EXTEND / FALLBACK instead. Do you want me
to
re-send ?
WARNING: multiple messages have this Message-ID (diff)
From: Nick Kossifidis <mick@ics.forth.gr>
To: palmer@sifive.com
Cc: mick@ics.forth.gr, linux-riscv@lists.infradead.org,
aou@eecs.berkeley.edu
Subject: Re: [PATCH] RISC-V: Update Kconfig to better handle CMDLINE
Date: Fri, 09 Nov 2018 20:34:00 +0200 [thread overview]
Message-ID: <ebe1db4d71a42711acb212013fd0fc2b@mailhost.ics.forth.gr> (raw)
Message-ID: <20181109183400.cR1AmZ6FRzfQdlEi4wE5w5JpYsgff9ANNFMvP1LFFiw@z> (raw)
In-Reply-To: <20181004113230.7995-1-mick@ics.forth.gr>
Hello Palmer,
Στις 2018-10-04 14:32, Nick Kossifidis έγραψε:
> Add a menu to chose how the built-in command line will be used and
> add CMDLINE_EXTEND for compatibility with FDT code.
>
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> ---
> arch/riscv/Kconfig | 45 ++++++++++++++++++++++++---------------------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 82172bf85..cce141552 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -218,39 +218,42 @@ endmenu
>
> menu "Boot options"
>
> -config CMDLINE_BOOL
> - bool "Built-in kernel command line"
> +config CMDLINE
> + string "Built-in kernel command line"
> help
> For most platforms, it is firmware or second stage bootloader
> that by default specifies the kernel command line options.
> However, it might be necessary or advantageous to either override
> - the default kernel command line or add a few extra options to it.
> - For such cases, this option allows hardcoding command line options
> - directly into the kernel.
> + the provided kernel command line or add a few extra options to it.
> + For such cases, it is possible to define a built-in command line
> + here and chose how the kernel should use it later on.
>
> - For that, choose 'Y' here and fill in the extra boot parameters
> - in CONFIG_CMDLINE.
> +choice
> + prompt "Built-in command line usage" if CMDLINE != ""
> + default CMDLINE_FALLBACK
> + help
> + Chose how the kernel will handle the provided built-in command
> + line.
>
> - The built-in options will be concatenated to the default command
> - line if CMDLINE_FORCE is set to 'N'. Otherwise, the default
> - command line will be ignored and replaced by the built-in string.
> +config CMDLINE_FALLBACK
> + bool "Fallback"
> + help
> + Use the built-in command line as fallback in case we get nothing
> + from the boot loader.
>
> -config CMDLINE
> - string "Built-in kernel command string"
> - depends on CMDLINE_BOOL
> - default ""
> +config CMDLINE_EXTEND
> + bool "Extension"
> help
> - Supply command-line options at build time by entering them here.
> + Use the built-in command line as an extension of the command line
> + provided by the boot loader.
>
> config CMDLINE_FORCE
> - bool "Built-in command line overrides bootloader arguments"
> - depends on CMDLINE_BOOL
> + bool "Forced"
> help
> - Set this option to 'Y' to have the kernel ignore the bootloader
> - or firmware command line. Instead, the built-in command line
> - will be used exclusively.
> + Use the built-in command line in place of the command line
> + provided by the boot loader.
>
> - If you don't know what to do here, say N.
> +endchoice
>
> endmenu
Since we'll be using FDT only for handling cmdline, this one is still
needed
because FDT code uses CMDLINE_EXTEND / FALLBACK instead. Do you want me
to
re-send ?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-09 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 11:32 [PATCH] RISC-V: Update Kconfig to better handle CMDLINE Nick Kossifidis
2018-10-04 11:32 ` Nick Kossifidis
2018-11-09 18:34 ` Nick Kossifidis [this message]
2018-11-09 18:34 ` Nick Kossifidis
2018-11-09 21:05 ` Palmer Dabbelt
2018-11-09 21:05 ` Palmer Dabbelt
2018-11-10 1:02 Nick Kossifidis
2018-11-10 1:02 ` Nick Kossifidis
2018-11-16 16:52 ` Palmer Dabbelt
2018-11-16 16:52 ` Palmer Dabbelt
2018-11-16 17:08 ` Nick Kossifidis
2018-11-16 17:08 ` Nick Kossifidis
2018-11-16 17:14 ` Nick Kossifidis
2018-11-16 17:14 ` Nick Kossifidis
2018-11-16 17:27 ` Palmer Dabbelt
2018-11-16 17:27 ` Palmer Dabbelt
2018-11-16 17:33 ` Nick Kossifidis
2018-11-16 17:33 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe1db4d71a42711acb212013fd0fc2b@mailhost.ics.forth.gr \
--to=mick@ics.forth.gr \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).