From: elfring@users.sourceforge.net (SF Markus Elfring) To: linux-riscv@lists.infradead.org Subject: [PATCH -next v2 1/3] mm: treewide: remove unused address argument from pte_alloc functions Date: Sat, 3 Nov 2018 13:51:20 +0100 [thread overview] Message-ID: <fd939e7c-3d9e-760e-f20c-e7263f064153@users.sourceforge.net> (raw) In-Reply-To: <20181103040041.7085-2-joelaf@google.com> > ? There is concern that ? Does this wording need a small adjustment? > The changes were obtained by applying the following Coccinelle script. I would find it nicer if previous patch review comments will trigger further useful effects here. https://patchwork.kernel.org/patch/10637703/#22265203 https://lore.kernel.org/linuxppc-dev/03b524f3-5f3a-baa0-2254-9c588103d2d6 at users.sourceforge.net/ https://www.mail-archive.com/linuxppc-dev at lists.ozlabs.org/msg140009.html If you have got difficulties with the usage of advanced regular expressions for SmPL constraints, I suggest to use desired function names in SmPL lists or disjunctions instead because of different run time characteristics for such a source code transformation approach. > // Note: I split the 'identifier fn' line, so if you are manually > // running it, please unsplit it so it runs for you. Please delete this questionable comment. * The semantic patch language should handle the mentioned code formatting. * You can use multi-line regular expressions (if it would be desired). > @pte_alloc_func_def depends on patch exists@ > identifier E2; > identifier fn =~ How do you think about to avoid the repetition of a SmPL key word at such places? Regards, Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: Joel Fernandes <joel@joelfernandes.org>, kernel-janitors@vger.kernel.org Cc: linux-mips@linux-mips.org, Rich Felker <dalias@libc.org>, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Catalin Marinas <catalin.marinas@arm.com>, Dave Hansen <dave.hansen@linux.intel.com>, Will Deacon <will.deacon@arm.com>, Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org, Lokesh Gidra <lokeshgidra@google.com>, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Anton Ivanov <anton.ivanov@kot-begemot.co.uk>, Jonas Bonn <jonas@southpole.se>, linux-s390@vger.kernel.org, Daniel Colascione <dancol@google.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>, "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" <x86@kernel.org>, Hugh Dickins <hughd@google.com>, "James E. J. Bottomley" <jejb@parisc-linux.org>, kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ingo Molnar <mingo@redhat.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Andrey Ryabinin <aryabinin@virtuozzo.com>, linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey <sammy@sammy.net>, Fenghua Yu <fenghua.yu@intel.com>, Jeff Dike <jdike@addtoit.com>, linux-um@lists.infradead.org, Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>, Julia Lawall <Julia.Lawall@lip6.fr>, linux-m68k@lists.linux-m68k.org, Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>, nios2-dev@lists.rocketboards.org, "Kirill A . Shutemov" <kirill@shutemov.name>, Stafford Horne <shorne@gmail.com>, Guan Xuetao <gxt@pku.edu.cn>, Chris Zankel <chris@zankel.net>, Tony Luck <tony.luck@intel.com>, Richard Weinberger <richard@nod.at>, linux-parisc@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>, pantin@google.com, linux-kernel@vger.kernel.org, Minchan Kim <minchan@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, linux-alpha@vger.kernel.org, Ley Foon Tan <lftan@altera.com>, Andrew Morton <akpm@linux-foundation.org>, linuxppc-dev@lists.ozlabs.org, "David S. Miller" <davem@davemloft.net> Subject: Re: [PATCH -next v2 1/3] mm: treewide: remove unused address argument from pte_alloc functions Date: Sat, 3 Nov 2018 13:51:20 +0100 [thread overview] Message-ID: <fd939e7c-3d9e-760e-f20c-e7263f064153@users.sourceforge.net> (raw) Message-ID: <20181103125120.ARs5Xv_xU9FtZIWGVELXUc4d8pU-HLtWHniyQXosz4M@z> (raw) In-Reply-To: <20181103040041.7085-2-joelaf@google.com> > … There is concern that … Does this wording need a small adjustment? > The changes were obtained by applying the following Coccinelle script. I would find it nicer if previous patch review comments will trigger further useful effects here. https://patchwork.kernel.org/patch/10637703/#22265203 https://lore.kernel.org/linuxppc-dev/03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net/ https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg140009.html If you have got difficulties with the usage of advanced regular expressions for SmPL constraints, I suggest to use desired function names in SmPL lists or disjunctions instead because of different run time characteristics for such a source code transformation approach. > // Note: I split the 'identifier fn' line, so if you are manually > // running it, please unsplit it so it runs for you. Please delete this questionable comment. * The semantic patch language should handle the mentioned code formatting. * You can use multi-line regular expressions (if it would be desired). > @pte_alloc_func_def depends on patch exists@ > identifier E2; > identifier fn =~ How do you think about to avoid the repetition of a SmPL key word at such places? Regards, Markus _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-03 12:51 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-03 4:00 [PATCH -next 0/3] Add support for fast mremap Joel Fernandes 2018-11-03 4:00 ` Joel Fernandes 2018-11-03 4:00 ` [PATCH -next 1/3] mm: treewide: remove unused address argument from pte_alloc functions (v2) Joel Fernandes 2018-11-03 4:00 ` Joel Fernandes 2018-11-03 12:51 ` SF Markus Elfring [this message] 2018-11-03 12:51 ` [PATCH -next v2 1/3] mm: treewide: remove unused address argument from pte_alloc functions SF Markus Elfring 2018-11-03 4:00 ` [PATCH -next 2/3] mm: speed up mremap by 20x on large regions (v4) Joel Fernandes 2018-11-03 4:00 ` Joel Fernandes 2018-11-03 16:45 ` kbuild test robot 2018-11-03 16:45 ` kbuild test robot 2018-11-03 16:56 ` kbuild test robot 2018-11-03 16:56 ` kbuild test robot 2018-11-03 4:00 ` [PATCH -next 3/3] mm: select HAVE_MOVE_PMD in x86 for faster mremap Joel Fernandes 2018-11-03 4:00 ` Joel Fernandes 2018-11-03 9:15 ` [PATCH -next 0/3] Add support for fast mremap Richard Weinberger 2018-11-03 9:15 ` Richard Weinberger 2018-11-03 9:24 ` Anton Ivanov 2018-11-03 9:24 ` Anton Ivanov 2018-11-03 15:20 ` Joel Fernandes 2018-11-03 15:20 ` Joel Fernandes 2018-11-03 18:32 ` Joel Fernandes 2018-11-03 18:32 ` Joel Fernandes 2018-11-04 6:56 ` William Kucharski 2018-11-04 6:56 ` William Kucharski 2018-11-06 4:36 ` Joel Fernandes 2018-11-06 4:36 ` Joel Fernandes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fd939e7c-3d9e-760e-f20c-e7263f064153@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=linux-riscv@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).