* [PATCH for-next] riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration
@ 2020-09-05 5:52 Pekka Enberg
2020-09-09 3:14 ` Palmer Dabbelt
0 siblings, 1 reply; 2+ messages in thread
From: Pekka Enberg @ 2020-09-05 5:52 UTC (permalink / raw)
To: linux-riscv; +Cc: Pekka Enberg, palmer, kernel test robot
The "inline" keyword is in the wrong place in vmalloc_fault()
declaration:
>> arch/riscv/mm/fault.c:56:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
56 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
| ^~~~~~
Fix that up.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
arch/riscv/mm/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
index a23eaf5ce95c..a173432ccf82 100644
--- a/arch/riscv/mm/fault.c
+++ b/arch/riscv/mm/fault.c
@@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
no_context(regs, addr);
}
-static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
+static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
{
pgd_t *pgd, *pgd_k;
pud_t *pud, *pud_k;
--
2.26.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-next] riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration
2020-09-05 5:52 [PATCH for-next] riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration Pekka Enberg
@ 2020-09-09 3:14 ` Palmer Dabbelt
0 siblings, 0 replies; 2+ messages in thread
From: Palmer Dabbelt @ 2020-09-09 3:14 UTC (permalink / raw)
To: penberg; +Cc: penberg, linux-riscv, lkp
On Fri, 04 Sep 2020 22:52:52 PDT (-0700), penberg@kernel.org wrote:
> The "inline" keyword is in the wrong place in vmalloc_fault()
> declaration:
>
>>> arch/riscv/mm/fault.c:56:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
> 56 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
> | ^~~~~~
>
> Fix that up.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> ---
> arch/riscv/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
> index a23eaf5ce95c..a173432ccf82 100644
> --- a/arch/riscv/mm/fault.c
> +++ b/arch/riscv/mm/fault.c
> @@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
> no_context(regs, addr);
> }
>
> -static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
> +static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
> {
> pgd_t *pgd, *pgd_k;
> pud_t *pud, *pud_k;
Thanks, this is on for-next.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 5:52 [PATCH for-next] riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration Pekka Enberg
2020-09-09 3:14 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).