From: palmer@sifive.com (Palmer Dabbelt)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
Date: Mon, 19 Nov 2018 09:36:32 -0800 (PST) [thread overview]
Message-ID: <mhng-37d3ed08-3bb9-420e-bb62-3bd555d141dd@palmer-si-x1c4> (raw)
In-Reply-To: <CAOesGMjzOkPNv7v_uMMsCw=20NuebPvkLBS5b5eaS9Z6=p1qKg@mail.gmail.com>
On Fri, 16 Nov 2018 19:09:36 PST (-0800), Olof Johansson wrote:
> On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov at gmail.com wrote:
>> > Fixes warning: 'struct module' declared inside parameter list will not be
>> > visible outside of this definition or declaration
>> >
>> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>> > ---
>> > arch/riscv/include/asm/module.h | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
>> > index 349df33808c4..cd2af4b013e3 100644
>> > --- a/arch/riscv/include/asm/module.h
>> > +++ b/arch/riscv/include/asm/module.h
>> > @@ -8,6 +8,7 @@
>> >
>> > #define MODULE_ARCH_VERMAGIC "riscv"
>> >
>> > +struct module;
>> > u64 module_emit_got_entry(struct module *mod, u64 val);
>> > u64 module_emit_plt_entry(struct module *mod, u64 val);
>>
>> Works for me. Looks like arm64 might have exactly the same issue. I'll roll
>> it up into the next RC.
>
> Looks like it's still here in -next. So, patch:
>
> Acked-by: Olof Johansson <olof@lixom.net>
>
> (and it'd be great to pickup together with the 32-bit build fix).
Sorry, I must have managed to screw something up here and drop both of these
from my fixes list. Not sure how they managed to make it into -next without
being in the list, but it's been on my TODO list to fix up my workflow scripts
for a while anyway...
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@sifive.com>
To: Olof Johansson <olof@lixom.net>
Cc: linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu,
linux-kernel@vger.kernel.org, david.abdurachmanov@gmail.com
Subject: Re: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
Date: Mon, 19 Nov 2018 09:36:32 -0800 (PST) [thread overview]
Message-ID: <mhng-37d3ed08-3bb9-420e-bb62-3bd555d141dd@palmer-si-x1c4> (raw)
Message-ID: <20181119173632.90cJS6uIH6mAIrDUE9awRULatPCEr9uCUXzGlEvxhrs@z> (raw)
In-Reply-To: <CAOesGMjzOkPNv7v_uMMsCw=20NuebPvkLBS5b5eaS9Z6=p1qKg@mail.gmail.com>
On Fri, 16 Nov 2018 19:09:36 PST (-0800), Olof Johansson wrote:
> On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov@gmail.com wrote:
>> > Fixes warning: 'struct module' declared inside parameter list will not be
>> > visible outside of this definition or declaration
>> >
>> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>> > ---
>> > arch/riscv/include/asm/module.h | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
>> > index 349df33808c4..cd2af4b013e3 100644
>> > --- a/arch/riscv/include/asm/module.h
>> > +++ b/arch/riscv/include/asm/module.h
>> > @@ -8,6 +8,7 @@
>> >
>> > #define MODULE_ARCH_VERMAGIC "riscv"
>> >
>> > +struct module;
>> > u64 module_emit_got_entry(struct module *mod, u64 val);
>> > u64 module_emit_plt_entry(struct module *mod, u64 val);
>>
>> Works for me. Looks like arm64 might have exactly the same issue. I'll roll
>> it up into the next RC.
>
> Looks like it's still here in -next. So, patch:
>
> Acked-by: Olof Johansson <olof@lixom.net>
>
> (and it'd be great to pickup together with the 32-bit build fix).
Sorry, I must have managed to screw something up here and drop both of these
from my fixes list. Not sure how they managed to make it into -next without
being in the list, but it's been on my TODO list to fix up my workflow scripts
for a while anyway...
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-19 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 19:07 [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h David Abdurachmanov
2018-11-08 19:07 ` David Abdurachmanov
2018-11-08 19:32 ` Palmer Dabbelt
2018-11-08 19:32 ` Palmer Dabbelt
2018-11-17 3:09 ` Olof Johansson
2018-11-17 3:09 ` Olof Johansson
2018-11-19 17:36 ` Palmer Dabbelt [this message]
2018-11-19 17:36 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-37d3ed08-3bb9-420e-bb62-3bd555d141dd@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).