* [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file
@ 2020-02-19 3:49 Yash Shah
2020-03-04 3:45 ` Anup Patel
2020-03-05 20:28 ` Palmer Dabbelt
0 siblings, 2 replies; 3+ messages in thread
From: Yash Shah @ 2020-02-19 3:49 UTC (permalink / raw)
To: robh+dt, mark.rutland, palmer, paul.walmsley
Cc: devicetree, aou, linux-kernel, atish.patra, Yash Shah, linux-riscv
Add the ability to reboot the HiFive Unleashed board via GPIO.
Signed-off-by: Yash Shah <yash.shah@sifive.com>
---
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 609198c..4a2729f 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -2,6 +2,7 @@
/* Copyright (c) 2018-2019 SiFive, Inc */
#include "fu540-c000.dtsi"
+#include <dt-bindings/gpio/gpio.h>
/* Clock frequency (in Hz) of the PCB crystal for rtcclk */
#define RTCCLK_FREQ 1000000
@@ -41,6 +42,10 @@
clock-frequency = <RTCCLK_FREQ>;
clock-output-names = "rtcclk";
};
+ gpio-restart {
+ compatible = "gpio-restart";
+ gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
+ };
};
&uart0 {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file
2020-02-19 3:49 [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file Yash Shah
@ 2020-03-04 3:45 ` Anup Patel
2020-03-05 20:28 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2020-03-04 3:45 UTC (permalink / raw)
To: Yash Shah
Cc: Mark Rutland, devicetree, Albert Ou,
linux-kernel@vger.kernel.org List, Atish Patra, Rob Herring,
Palmer Dabbelt, Paul Walmsley, linux-riscv
On Wed, Feb 19, 2020 at 9:19 AM Yash Shah <yash.shah@sifive.com> wrote:
>
> Add the ability to reboot the HiFive Unleashed board via GPIO.
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
LGTM.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 609198c..4a2729f 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -2,6 +2,7 @@
> /* Copyright (c) 2018-2019 SiFive, Inc */
>
> #include "fu540-c000.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> /* Clock frequency (in Hz) of the PCB crystal for rtcclk */
> #define RTCCLK_FREQ 1000000
> @@ -41,6 +42,10 @@
> clock-frequency = <RTCCLK_FREQ>;
> clock-output-names = "rtcclk";
> };
> + gpio-restart {
> + compatible = "gpio-restart";
> + gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
> + };
> };
>
> &uart0 {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file
2020-02-19 3:49 [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file Yash Shah
2020-03-04 3:45 ` Anup Patel
@ 2020-03-05 20:28 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2020-03-05 20:28 UTC (permalink / raw)
To: yash.shah
Cc: mark.rutland, devicetree, aou, linux-kernel, Atish Patra,
yash.shah, robh+dt, Paul Walmsley, linux-riscv
On Tue, 18 Feb 2020 19:49:07 PST (-0800), yash.shah@sifive.com wrote:
> Add the ability to reboot the HiFive Unleashed board via GPIO.
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 609198c..4a2729f 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -2,6 +2,7 @@
> /* Copyright (c) 2018-2019 SiFive, Inc */
>
> #include "fu540-c000.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> /* Clock frequency (in Hz) of the PCB crystal for rtcclk */
> #define RTCCLK_FREQ 1000000
> @@ -41,6 +42,10 @@
> clock-frequency = <RTCCLK_FREQ>;
> clock-output-names = "rtcclk";
> };
> + gpio-restart {
> + compatible = "gpio-restart";
> + gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
> + };
> };
>
> &uart0 {
Thanks, this is on fixes -- I figure that given it's just a DT change there's
no reason to delay it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-05 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 3:49 [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file Yash Shah
2020-03-04 3:45 ` Anup Patel
2020-03-05 20:28 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).