From: Palmer Dabbelt <palmer@dabbelt.com>
To: greentime.hu@sifive.com
Cc: aou@eecs.berkeley.edu, lkp@intel.com,
linux-kernel@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
greentime.hu@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] riscv: Fix building error in entry.S when CONFIG_RISCV_M_MODE is enabled
Date: Tue, 21 Jul 2020 19:58:58 -0700 (PDT) [thread overview]
Message-ID: <mhng-ca23efdb-a932-4c2c-9b67-223fe779a284@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <742f0a82a9d4ab62d8616784db5a88a95d8b5389.1594629047.git.greentime.hu@sifive.com>
On Mon, 13 Jul 2020 01:32:15 PDT (-0700), greentime.hu@sifive.com wrote:
> arch/riscv/kernel/entry.S: Assembler messages:
> arch/riscv/kernel/entry.S:106: Error: illegal operands `andi a0,s1,0x00001800'
>
> This building error is because of the SR_MPP value is too large to be used
> as an immediate value for andi. To fix this issue I use li to set the
> immediate value to t0, then it can use t0 and s1 to do and operation.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
> ---
> arch/riscv/kernel/entry.S | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S
> index 6ed579fc1073..000984695cd6 100644
> --- a/arch/riscv/kernel/entry.S
> +++ b/arch/riscv/kernel/entry.S
> @@ -99,7 +99,8 @@ _save_context:
>
> #ifdef CONFIG_CONTEXT_TRACKING
> /* If previous state is in user mode, call context_tracking_user_exit. */
> - andi a0, s1, SR_SPP
> + li t0, SR_PP
> + and a0, s1, t0
> bnez a0, skip_context_tracking
> call context_tracking_user_exit
Looks like this one already got fixed, I guess I saw the build report go by and
fixed it? I don't remember if I actually pulled this in, but I ended up with a
3-register andi so I guess I didn't do it that well.
I'm not sure why my build test aren't catching the M-mode stuff, as the
defconfigs are in the list. I'll go take a look...
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-07-22 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 8:32 [PATCH 1/2] riscv: Fix building error in entry.S when CONFIG_RISCV_M_MODE is enabled Greentime Hu
2020-07-13 8:32 ` [PATCH 2/2] riscv: Simplify the checking for SR_PP Greentime Hu
2020-07-22 2:59 ` Palmer Dabbelt
2020-07-13 20:11 ` [PATCH 1/2] riscv: Fix building error in entry.S when CONFIG_RISCV_M_MODE is enabled Palmer Dabbelt
2020-07-22 2:58 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-ca23efdb-a932-4c2c-9b67-223fe779a284@palmerdabbelt-glaptop1 \
--to=palmer@dabbelt.com \
--cc=aou@eecs.berkeley.edu \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).