From: palmer@sifive.com (Palmer Dabbelt)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] OF: Add a warning in case chosen node is not present
Date: Sun, 11 Nov 2018 13:52:06 -0800 (PST) [thread overview]
Message-ID: <mhng-e3979636-81f8-42d6-b810-eeed6786d4bb@palmer-si-x1c4> (raw)
In-Reply-To: <20181110005317.5631-1-mick@ics.forth.gr>
On Fri, 09 Nov 2018 16:53:17 PST (-0800), mick at ics.forth.gr wrote:
> On architectures that only get their bootargs through devicetree's
> chosen node (such as RISC-V), that node is mandatory. After a
> discussion with Rob [1] I'm adding a warning in case chosen node
> is not present, to let users know about it.
>
> [1]: https://patchwork.ozlabs.org/patch/984224/#2016136
>
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> ---
> drivers/of/fdt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index bb532aae0d92..7ff67bf1f6d6 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1200,8 +1200,12 @@ bool __init early_init_dt_verify(void *params)
>
> void __init early_init_dt_scan_nodes(void)
> {
> + int rc = 0;
> +
> /* Retrieve various information from the /chosen node */
> - of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
> + rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
> + if (!rc)
> + pr_warn("No chosen node found, continuing without\n");
>
> /* Initialize {size,address}-cells info */
> of_scan_flat_dt(early_init_dt_scan_root, NULL);
Thanks! Note that in our case we actually ignore the built-in boot arguments
without a /chosen node, which isn't clear to me from the message. I'm not sure
if it's sane to warn everyone of this, but it was decided that RISC-V should
have this behavior because it's all standard code.
In other words, it might be worth adding some sort of
#ifdef CONFIG_CMDLINE
pr_warn("Due to the lack of a /chosen node, we're also ignoring your builtin kernel command-line\n");
#endif
though that wording is, of course, a bit poor :).
Either way,
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
as this is better than nothing! Now I can just point users to the error and
tell them that, obviously, they should know what it means -- I just hope I can
remember :)
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@sifive.com>
To: mick@ics.forth.gr
Cc: mick@ics.forth.gr, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, robh+dt@kernel.org,
frowand.list@gmail.com
Subject: Re: [PATCH] OF: Add a warning in case chosen node is not present
Date: Sun, 11 Nov 2018 13:52:06 -0800 (PST) [thread overview]
Message-ID: <mhng-e3979636-81f8-42d6-b810-eeed6786d4bb@palmer-si-x1c4> (raw)
Message-ID: <20181111215206.24bp8_F0SQhZX6_6oX-xJwfCWOy_yzulokrSFK5EiLs@z> (raw)
In-Reply-To: <20181110005317.5631-1-mick@ics.forth.gr>
On Fri, 09 Nov 2018 16:53:17 PST (-0800), mick@ics.forth.gr wrote:
> On architectures that only get their bootargs through devicetree's
> chosen node (such as RISC-V), that node is mandatory. After a
> discussion with Rob [1] I'm adding a warning in case chosen node
> is not present, to let users know about it.
>
> [1]: https://patchwork.ozlabs.org/patch/984224/#2016136
>
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> ---
> drivers/of/fdt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index bb532aae0d92..7ff67bf1f6d6 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1200,8 +1200,12 @@ bool __init early_init_dt_verify(void *params)
>
> void __init early_init_dt_scan_nodes(void)
> {
> + int rc = 0;
> +
> /* Retrieve various information from the /chosen node */
> - of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
> + rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
> + if (!rc)
> + pr_warn("No chosen node found, continuing without\n");
>
> /* Initialize {size,address}-cells info */
> of_scan_flat_dt(early_init_dt_scan_root, NULL);
Thanks! Note that in our case we actually ignore the built-in boot arguments
without a /chosen node, which isn't clear to me from the message. I'm not sure
if it's sane to warn everyone of this, but it was decided that RISC-V should
have this behavior because it's all standard code.
In other words, it might be worth adding some sort of
#ifdef CONFIG_CMDLINE
pr_warn("Due to the lack of a /chosen node, we're also ignoring your builtin kernel command-line\n");
#endif
though that wording is, of course, a bit poor :).
Either way,
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
as this is better than nothing! Now I can just point users to the error and
tell them that, obviously, they should know what it means -- I just hope I can
remember :)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-11 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 0:53 [PATCH] OF: Add a warning in case chosen node is not present Nick Kossifidis
2018-11-10 0:53 ` Nick Kossifidis
2018-11-11 21:52 ` Palmer Dabbelt [this message]
2018-11-11 21:52 ` Palmer Dabbelt
2018-12-03 23:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-e3979636-81f8-42d6-b810-eeed6786d4bb@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).