* [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
[not found] <20210910234047.1019925-1-ndesaulniers@google.com>
@ 2021-09-10 23:40 ` Nick Desaulniers
2021-09-11 0:09 ` Nathan Chancellor
2021-09-13 16:23 ` Kees Cook
0 siblings, 2 replies; 6+ messages in thread
From: Nick Desaulniers @ 2021-09-10 23:40 UTC (permalink / raw)
To: Andrew Morton
Cc: Linus Torvalds, Rasmus Villemoes, Nathan Chancellor,
Masahiro Yamada, Joe Perches, Arnd Bergmann, Stephen Rothwell,
llvm, linux-kernel, Nick Desaulniers, Paul Walmsley,
Palmer Dabbelt, Albert Ou, linux-riscv
The minimum supported version of GCC is now 5.1. The check wasn't
correct as written anyways since GCC_VERSION is 0 when CC=clang.
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/riscv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index c79955655fa4..5fc1d0cc82e1 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -235,7 +235,7 @@ config ARCH_RV32I
config ARCH_RV64I
bool "RV64I"
select 64BIT
- select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000
+ select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL
--
2.33.0.309.g3052b89438-goog
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
2021-09-10 23:40 ` [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I Nick Desaulniers
@ 2021-09-11 0:09 ` Nathan Chancellor
2021-09-13 16:23 ` Kees Cook
1 sibling, 0 replies; 6+ messages in thread
From: Nathan Chancellor @ 2021-09-11 0:09 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Andrew Morton, Linus Torvalds, Rasmus Villemoes, Masahiro Yamada,
Joe Perches, Arnd Bergmann, Stephen Rothwell, llvm, linux-kernel,
Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv
On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
> The minimum supported version of GCC is now 5.1. The check wasn't
> correct as written anyways since GCC_VERSION is 0 when CC=clang.
>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Indeed, I meant to clean this up a while ago but forgot :/
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/riscv/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index c79955655fa4..5fc1d0cc82e1 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -235,7 +235,7 @@ config ARCH_RV32I
> config ARCH_RV64I
> bool "RV64I"
> select 64BIT
> - select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000
> + select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
> select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
> select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
> select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL
> --
> 2.33.0.309.g3052b89438-goog
>
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
2021-09-10 23:40 ` [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I Nick Desaulniers
2021-09-11 0:09 ` Nathan Chancellor
@ 2021-09-13 16:23 ` Kees Cook
2021-10-05 0:40 ` Palmer Dabbelt
1 sibling, 1 reply; 6+ messages in thread
From: Kees Cook @ 2021-09-13 16:23 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Andrew Morton, Linus Torvalds, Rasmus Villemoes,
Nathan Chancellor, Masahiro Yamada, Joe Perches, Arnd Bergmann,
Stephen Rothwell, llvm, linux-kernel, Paul Walmsley,
Palmer Dabbelt, Albert Ou, linux-riscv
On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
> The minimum supported version of GCC is now 5.1. The check wasn't
> correct as written anyways since GCC_VERSION is 0 when CC=clang.
>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Yeah, good catch for Clang too.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
2021-09-13 16:23 ` Kees Cook
@ 2021-10-05 0:40 ` Palmer Dabbelt
2021-10-05 0:50 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Palmer Dabbelt @ 2021-10-05 0:40 UTC (permalink / raw)
To: ndesaulniers, keescook
Cc: ndesaulniers, akpm, Linus Torvalds, linux, nathan, masahiroy,
joe, arnd, Stephen Rothwell, llvm, linux-kernel, Paul Walmsley,
aou, linux-riscv
On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote:
> On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
>> The minimum supported version of GCC is now 5.1. The check wasn't
>> correct as written anyways since GCC_VERSION is 0 when CC=clang.
>>
>> Cc: Paul Walmsley <paul.walmsley@sifive.com>
>> Cc: Palmer Dabbelt <palmer@dabbelt.com>
>> Cc: Albert Ou <aou@eecs.berkeley.edu>
>> Cc: linux-riscv@lists.infradead.org
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Yeah, good catch for Clang too.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
Only this patch ended up in my inbox. Where you guys planning on
keeping this whole series together, or did you want me to pick this for
the RISC-V tree?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
2021-10-05 0:40 ` Palmer Dabbelt
@ 2021-10-05 0:50 ` Kees Cook
2021-10-05 0:57 ` Palmer Dabbelt
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2021-10-05 0:50 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: ndesaulniers, akpm, Linus Torvalds, linux, nathan, masahiroy,
joe, arnd, Stephen Rothwell, llvm, linux-kernel, Paul Walmsley,
aou, linux-riscv
On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote:
> On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote:
> > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
> > > The minimum supported version of GCC is now 5.1. The check wasn't
> > > correct as written anyways since GCC_VERSION is 0 when CC=clang.
> > >
> > > Cc: Paul Walmsley <paul.walmsley@sifive.com>
> > > Cc: Palmer Dabbelt <palmer@dabbelt.com>
> > > Cc: Albert Ou <aou@eecs.berkeley.edu>
> > > Cc: linux-riscv@lists.infradead.org
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> >
> > Yeah, good catch for Clang too.
> >
> > Reviewed-by: Kees Cook <keescook@chromium.org>
>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
>
> Only this patch ended up in my inbox. Where you guys planning on keeping
> this whole series together, or did you want me to pick this for the RISC-V
> tree?
Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895)
--
Kees Cook
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
2021-10-05 0:50 ` Kees Cook
@ 2021-10-05 0:57 ` Palmer Dabbelt
0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-10-05 0:57 UTC (permalink / raw)
To: keescook
Cc: ndesaulniers, akpm, Linus Torvalds, linux, nathan, masahiroy,
joe, arnd, Stephen Rothwell, llvm, linux-kernel, Paul Walmsley,
aou, linux-riscv
On Mon, 04 Oct 2021 17:50:46 PDT (-0700), keescook@chromium.org wrote:
> On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote:
>> On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote:
>> > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
>> > > The minimum supported version of GCC is now 5.1. The check wasn't
>> > > correct as written anyways since GCC_VERSION is 0 when CC=clang.
>> > >
>> > > Cc: Paul Walmsley <paul.walmsley@sifive.com>
>> > > Cc: Palmer Dabbelt <palmer@dabbelt.com>
>> > > Cc: Albert Ou <aou@eecs.berkeley.edu>
>> > > Cc: linux-riscv@lists.infradead.org
>> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>> >
>> > Yeah, good catch for Clang too.
>> >
>> > Reviewed-by: Kees Cook <keescook@chromium.org>
>>
>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
>> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> Only this patch ended up in my inbox. Where you guys planning on keeping
>> this whole series together, or did you want me to pick this for the RISC-V
>> tree?
>
> Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895)
Thanks.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-05 0:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210910234047.1019925-1-ndesaulniers@google.com>
2021-09-10 23:40 ` [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I Nick Desaulniers
2021-09-11 0:09 ` Nathan Chancellor
2021-09-13 16:23 ` Kees Cook
2021-10-05 0:40 ` Palmer Dabbelt
2021-10-05 0:50 ` Kees Cook
2021-10-05 0:57 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).