* [PATCH] riscv: Make RISCV_TIMER depends on RISCV_SBI
@ 2020-10-28 13:12 Kefeng Wang
2020-11-06 7:14 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Kefeng Wang @ 2020-10-28 13:12 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Daniel Lezcano, linux-riscv
Cc: Kefeng Wang
The riscv timer is set via SBI timer call, let's make RISCV_TIMER
depends on RISCV_SBI, and it also fixes some build issue.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/clocksource/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 68b087bff59c..2be849bb794a 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -654,7 +654,7 @@ config ATCPIT100_TIMER
config RISCV_TIMER
bool "Timer for the RISC-V platform" if COMPILE_TEST
- depends on GENERIC_SCHED_CLOCK && RISCV
+ depends on GENERIC_SCHED_CLOCK && RISCV && RISCV_SBI
select TIMER_PROBE
select TIMER_OF
help
--
2.26.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Make RISCV_TIMER depends on RISCV_SBI
2020-10-28 13:12 [PATCH] riscv: Make RISCV_TIMER depends on RISCV_SBI Kefeng Wang
@ 2020-11-06 7:14 ` Palmer Dabbelt
2020-11-27 2:53 ` Kefeng Wang
0 siblings, 1 reply; 3+ messages in thread
From: Palmer Dabbelt @ 2020-11-06 7:14 UTC (permalink / raw)
To: wangkefeng.wang
Cc: wangkefeng.wang, linux-riscv, aou, daniel.lezcano, Paul Walmsley
On Wed, 28 Oct 2020 06:12:30 PDT (-0700), wangkefeng.wang@huawei.com wrote:
> The riscv timer is set via SBI timer call, let's make RISCV_TIMER
> depends on RISCV_SBI, and it also fixes some build issue.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68b087bff59c..2be849bb794a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -654,7 +654,7 @@ config ATCPIT100_TIMER
>
> config RISCV_TIMER
> bool "Timer for the RISC-V platform" if COMPILE_TEST
> - depends on GENERIC_SCHED_CLOCK && RISCV
> + depends on GENERIC_SCHED_CLOCK && RISCV && RISCV_SBI
> select TIMER_PROBE
> select TIMER_OF
> help
This should probably be
Fixes: 2bc3fc877aa9 ("RISC-V: Remove CLINT related code from timer and arch")
not really a bug in that commit, but since then the memory-mapped and SBI
timers have been split and therefor there's no way this driver can do anything
without SBI support.
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
Thanks!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] riscv: Make RISCV_TIMER depends on RISCV_SBI
2020-11-06 7:14 ` Palmer Dabbelt
@ 2020-11-27 2:53 ` Kefeng Wang
0 siblings, 0 replies; 3+ messages in thread
From: Kefeng Wang @ 2020-11-27 2:53 UTC (permalink / raw)
To: Palmer Dabbelt; +Cc: linux-riscv, aou, daniel.lezcano, Paul Walmsley
Hi Daniel, ping...
On 2020/11/6 15:14, Palmer Dabbelt wrote:
> On Wed, 28 Oct 2020 06:12:30 PDT (-0700), wangkefeng.wang@huawei.com
> wrote:
>> The riscv timer is set via SBI timer call, let's make RISCV_TIMER
>> depends on RISCV_SBI, and it also fixes some build issue.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> drivers/clocksource/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 68b087bff59c..2be849bb794a 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -654,7 +654,7 @@ config ATCPIT100_TIMER
>>
>> config RISCV_TIMER
>> bool "Timer for the RISC-V platform" if COMPILE_TEST
>> - depends on GENERIC_SCHED_CLOCK && RISCV
>> + depends on GENERIC_SCHED_CLOCK && RISCV && RISCV_SBI
>> select TIMER_PROBE
>> select TIMER_OF
>> help
>
> This should probably be
>
> Fixes: 2bc3fc877aa9 ("RISC-V: Remove CLINT related code from timer and
> arch")
>
> not really a bug in that commit, but since then the memory-mapped and SBI
> timers have been split and therefor there's no way this driver can do
> anything
> without SBI support.
>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
>
> Thanks!
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-27 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 13:12 [PATCH] riscv: Make RISCV_TIMER depends on RISCV_SBI Kefeng Wang
2020-11-06 7:14 ` Palmer Dabbelt
2020-11-27 2:53 ` Kefeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).