linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org, Helen Koike <helen.koike@collabora.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	hjc@rock-chips.com, robh+dt@kernel.org,
	sebastian.fricke@posteo.net, linux-media@vger.kernel.org,
	dafna.hirschfeld@collabora.com, ezequiel@collabora.com,
	cmuellner@linux.com
Subject: Re: [PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi
Date: Wed, 24 Mar 2021 15:52:59 +0100	[thread overview]
Message-ID: <12741091.uLZWGnKmhe@diego> (raw)
In-Reply-To: <d7b8137c-66ce-935a-c8d7-e507146143d7@collabora.com>

Am Montag, 15. Februar 2021, 15:33:19 CET schrieb Helen Koike:
> > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> > index cb25c0e8fc9b..3094d4533ad6 100644
> > --- a/drivers/gpu/drm/rockchip/Kconfig
> > +++ b/drivers/gpu/drm/rockchip/Kconfig
> > @@ -9,6 +9,8 @@ config DRM_ROCKCHIP
> >   	select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP
> >   	select DRM_DW_HDMI if ROCKCHIP_DW_HDMI
> >   	select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI
> > +	select GENERIC_PHY if ROCKCHIP_DW_MIPI_DSI
> > +	select GENERIC_PHY_MIPI_DPHY if ROCKCHIP_DW_MIPI_DSI
> 
> maybe alphabetical order?

ok

> > +static int dw_mipi_dsi_dphy_power_on(struct phy *phy)
> > +{
> > +	struct dw_mipi_dsi_rockchip *dsi = phy_get_drvdata(phy);
> > +	int i, ret;
> 
> It seems "i" could be removed, use ret instead.

I don't think so

I.e. the driver does

	i = max_mbps_to_parameter(...)
	...
	ret = power-on-clocks-and-stuff
	...
	dw_mipi_dsi_phy_write(.... dppa_map[i].hsfreqrange)

So will need to keep the param index separate.


> In general, the patch doesn't look wrong to me.
> 
> For the whole serie:
> Acked-by: Helen Koike <helen.koike@collabora.com>

Thanks a lot :-)


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2021-03-24 14:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 11:10 [PATCH v2 0/6] Support second Image Signal Processor on rk3399 Heiko Stuebner
2021-02-10 11:10 ` [PATCH v2 1/6] drm/rockchip: dsi: add own additional pclk handling Heiko Stuebner
2021-02-10 11:10 ` [PATCH v2 2/6] dt-bindings: display: rockchip-dsi: add optional #phy-cells property Heiko Stuebner
2021-02-10 11:10 ` [PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi Heiko Stuebner
2021-02-15 14:33   ` Helen Koike
2021-03-24 14:52     ` Heiko Stübner [this message]
2021-02-10 11:10 ` [PATCH 4/6] arm64: dts: rockchip: add #phy-cells to mipi-dsi1 Heiko Stuebner
2021-02-10 11:10 ` [PATCH 5/6] arm64: dts: rockchip: add cif clk-control pinctrl for rk3399 Heiko Stuebner
2021-02-10 11:10 ` [PATCH 6/6] arm64: dts: rockchip: add isp1 node on rk3399 Heiko Stuebner
2021-02-10 11:11 ` [PATCH v2 0/6] Support second Image Signal Processor " Heiko Stübner
2021-02-14  4:52 ` Sebastian Fricke
2021-07-25 22:58 ` Heiko Stübner
  -- strict thread matches above, loose matches on Subject: below --
2021-02-02 14:56 [PATCH " Heiko Stuebner
2021-02-02 14:56 ` [PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12741091.uLZWGnKmhe@diego \
    --to=heiko@sntech.de \
    --cc=cmuellner@linux.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ezequiel@collabora.com \
    --cc=helen.koike@collabora.com \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.fricke@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).