From: Sebastian Fricke <sebastian.fricke@posteo.net>
To: Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, dafna.hirschfeld@collabora.com,
cmuellner@linux.com, hjc@rock-chips.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, helen.koike@collabora.com,
robh+dt@kernel.org, ezequiel@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Support second Image Signal Processor on rk3399
Date: Sun, 14 Feb 2021 05:52:06 +0100 [thread overview]
Message-ID: <20210214045206.4jqae2yuolgdxwad@basti-TUXEDO-Book-XA1510> (raw)
In-Reply-To: <20210210111020.2476369-1-heiko@sntech.de>
Hey Heiko,
I have tested your series and it successfully fixes the problem with the
2nd camera when HDMI is connected at boot. Besides that the patch looks
good and my tests have confirmed that both cameras have the same output
quality when I exchange the connected ISP instances.
Tested-by: Sebastian Fricke <sebastian.fricke@posteo.net>
Greetings,
Sebastian
On 10.02.2021 12:10, Heiko Stuebner wrote:
>The rk3399 has two ISPs and right now only the first one is usable.
>The second ISP is connected to the TXRX dphy on the soc.
>
>The phy of ISP1 is only accessible through the DSI controller's
>io-memory, so this series adds support for simply using the dsi
>controller is a phy if needed.
>
>That solution is needed at least on rk3399 and rk3288 but no-one
>has looked at camera support on rk3288 at all, so right now
>only implement the rk3399 specifics.
>
>changes in v2:
>- enable grf-clock also for init callback
> to not break if for example hdmi is connected on boot
> and disabled the grf clock during its probe
>- add Sebastian's Tested-by
>- add Rob's Ack for the phy-cells property
>
>Heiko Stuebner (6):
> drm/rockchip: dsi: add own additional pclk handling
> dt-bindings: display: rockchip-dsi: add optional #phy-cells property
> drm/rockchip: dsi: add ability to work as a phy instead of full dsi
> arm64: dts: rockchip: add #phy-cells to mipi-dsi1
> arm64: dts: rockchip: add cif clk-control pinctrl for rk3399
> arm64: dts: rockchip: add isp1 node on rk3399
>
> .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 +
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 ++
> drivers/gpu/drm/rockchip/Kconfig | 2 +
> .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 349 ++++++++++++++++++
> 4 files changed, 391 insertions(+)
>
>--
>2.29.2
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-02-14 4:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 11:10 [PATCH v2 0/6] Support second Image Signal Processor on rk3399 Heiko Stuebner
2021-02-10 11:10 ` [PATCH v2 1/6] drm/rockchip: dsi: add own additional pclk handling Heiko Stuebner
2021-02-10 11:10 ` [PATCH v2 2/6] dt-bindings: display: rockchip-dsi: add optional #phy-cells property Heiko Stuebner
2021-02-10 11:10 ` [PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi Heiko Stuebner
2021-02-15 14:33 ` Helen Koike
2021-03-24 14:52 ` Heiko Stübner
2021-02-10 11:10 ` [PATCH 4/6] arm64: dts: rockchip: add #phy-cells to mipi-dsi1 Heiko Stuebner
2021-02-10 11:10 ` [PATCH 5/6] arm64: dts: rockchip: add cif clk-control pinctrl for rk3399 Heiko Stuebner
2021-02-10 11:10 ` [PATCH 6/6] arm64: dts: rockchip: add isp1 node on rk3399 Heiko Stuebner
2021-02-10 11:11 ` [PATCH v2 0/6] Support second Image Signal Processor " Heiko Stübner
2021-02-14 4:52 ` Sebastian Fricke [this message]
2021-07-25 22:58 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214045206.4jqae2yuolgdxwad@basti-TUXEDO-Book-XA1510 \
--to=sebastian.fricke@posteo.net \
--cc=cmuellner@linux.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).