linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Jianqun Xu <jay.xu@rock-chips.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Kever Yang <kever.yang@rock-chips.com>,
	David Wu <david.wu@rock-chips.com>
Subject: Re: [PATCH 0/2] pinctrl: rockchip: codingstyle for pinctrl-rockchip
Date: Sat, 12 Sep 2020 14:02:22 +0200	[thread overview]
Message-ID: <1646119.L9t6MPyLfv@diego> (raw)
In-Reply-To: <CACRpkdYGJsK4Ek8pDCeNMWt41dd2s--Lkxewh4Po4E-45UdwMg@mail.gmail.com>

Hi Linus,

Am Samstag, 12. September 2020, 13:27:44 CEST schrieb Linus Walleij:
> Jianqun, Heiko,
> 
> On Fri, Jan 17, 2020 at 9:14 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> 
> > Do codingstyle for pinctrl-rockchip by spliting driver by SoC types.
> >
> > Convenienty for reviewing, the first patch only moving
> > pinctrl-rockchip.c from driver/pinctrl to driver/pinctrl/rockchip/ .
> >
> > Jianqun Xu (2):
> >   pinctrl: rockchip: new rockchip dir for pinctrl-rockchip
> >   pinctrl: rockchip: split rockchip pinctrl driver by SoC type
> 
> Why were these patches never applied? Is it my fault?

It's not your fault :-)

> I don't even have patch 2/2 in my mailbox, possibly it was
> too big!
> 
> Heiko if you're OK with this change can Jianqun just send a
> rebased version?

We agreed to split it into smaller chunks which I think is the 13-patch
series you mentioned elsewhere today. But I guess that fell through
the cracks in my review :-( .

So I guess we should do the current GKI thingy first to get that
module build and after that maybe Jianqun can find the time to rebase
the per-soc split on top of that.


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2020-09-12 12:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09  9:40 [PATCH] pinctrl/rockchip: splite soc data to separated driver Jianqun Xu
2020-01-10 16:19 ` kbuild test robot
     [not found] ` <20200109094001.24343-1-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-01-13  1:16   ` [PATCH v2] " Jianqun Xu
2020-01-15 12:51     ` Linus Walleij
     [not found]       ` <CACRpkdY_EHQbF4rRyGwoxEk8LeWfmRzmCd=8=SY95LPXMHYOmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-16  3:44         ` Kever Yang
     [not found]           ` <c4ec95a7-aaf1-2331-352f-2def319a1c7d-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-01-16  7:14             ` [PATCH v3] pinctrl: rockchip: split rockchip pinctrl driver by SoC type Jianqun Xu
2020-01-16  7:47             ` [PATCH v3 RESEND] " Jianqun Xu
2020-01-16 10:34               ` Robin Murphy
2020-01-17  8:13           ` [PATCH 0/2] pinctrl: rockchip: codingstyle for pinctrl-rockchip Jianqun Xu
2020-01-17  8:13             ` [PATCH 1/2] pinctrl: rockchip: new rockchip dir " Jianqun Xu
     [not found]             ` <20200117081358.5772-1-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-01-17  8:13               ` [PATCH v4 2/2] pinctrl: rockchip: split rockchip pinctrl driver by SoC type Jianqun Xu
2020-02-15 11:11                 ` Heiko Stuebner
2020-09-12 11:27             ` [PATCH 0/2] pinctrl: rockchip: codingstyle for pinctrl-rockchip Linus Walleij
2020-09-12 12:02               ` Heiko Stübner [this message]
2020-09-14  0:01                 ` jay.xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1646119.L9t6MPyLfv@diego \
    --to=heiko@sntech.de \
    --cc=david.wu@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).