* [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus
@ 2023-05-13 6:52 Tianling Shen
2023-05-13 6:52 ` [PATCH 2/2] arm64: dts: rockchip: Add " Tianling Shen
2023-05-13 9:17 ` [PATCH 1/2] dt-bindings: Add doc for " Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Tianling Shen @ 2023-05-13 6:52 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Jagan Teki, Tianling Shen, Andy Yan, Chris Morgan,
Nicolas Frattaroli, Brian Norris, Maya Matuszczyk, Andrew Lunn,
Michael Riesch, Sebastian Reichel, Andrew Powers-Holmes
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Add devicetree binding documentation for the NanoPi R2C Plus.
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index b1d271778179..6f4d966744a5 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -189,6 +189,7 @@ properties:
items:
- enum:
- friendlyarm,nanopi-r2c
+ - friendlyarm,nanopi-r2c-plus
- friendlyarm,nanopi-r2s
- const: rockchip,rk3328
--
2.40.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: Add FriendlyARM NanoPi R2C Plus
2023-05-13 6:52 [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus Tianling Shen
@ 2023-05-13 6:52 ` Tianling Shen
2023-05-13 9:17 ` [PATCH 1/2] dt-bindings: Add doc for " Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Tianling Shen @ 2023-05-13 6:52 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Jagan Teki, Tianling Shen, Andy Yan, Chris Morgan,
Nicolas Frattaroli, Brian Norris, Maya Matuszczyk, Andrew Lunn,
Michael Riesch, Sebastian Reichel, Andrew Powers-Holmes
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
The NanoPi R2C Plus is a small variant of NanoPi R2C with a on-board
eMMC flash (8G) included.
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../dts/rockchip/rk3328-nanopi-r2c-plus.dts | 33 +++++++++++++++++++
2 files changed, 34 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 1cf105d7407f..794da4d41f14 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go3.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-a1.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2c.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2c-plus.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2s.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-orangepi-r1-plus.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-orangepi-r1-plus-lts.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dts
new file mode 100644
index 000000000000..16a1958e4572
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dts
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2021 FriendlyElec Computer Tech. Co., Ltd.
+ * (http://www.friendlyarm.com)
+ *
+ * Copyright (c) 2023 Tianling Shen <cnsztl@gmail.com>
+ */
+
+/dts-v1/;
+#include "rk3328-nanopi-r2c.dts"
+
+/ {
+ model = "FriendlyElec NanoPi R2C Plus";
+ compatible = "friendlyarm,nanopi-r2c-plus", "rockchip,rk3328";
+
+ aliases {
+ mmc1 = &emmc;
+ };
+};
+
+&emmc {
+ bus-width = <8>;
+ cap-mmc-highspeed;
+ max-frequency = <150000000>;
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ non-removable;
+ pinctrl-names = "default";
+ pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
+ vmmc-supply = <&vcc_io_33>;
+ vqmmc-supply = <&vcc18_emmc>;
+ status = "okay";
+};
--
2.40.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus
2023-05-13 6:52 [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus Tianling Shen
2023-05-13 6:52 ` [PATCH 2/2] arm64: dts: rockchip: Add " Tianling Shen
@ 2023-05-13 9:17 ` Krzysztof Kozlowski
2023-05-13 10:21 ` Tianling Shen
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-13 9:17 UTC (permalink / raw)
To: Tianling Shen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, Jagan Teki, Andy Yan, Chris Morgan,
Nicolas Frattaroli, Brian Norris, Maya Matuszczyk, Andrew Lunn,
Michael Riesch, Sebastian Reichel, Andrew Powers-Holmes
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On 13/05/2023 08:52, Tianling Shen wrote:
> Add devicetree binding documentation for the NanoPi R2C Plus.
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
subject: missing prefixes (arm: rockchip:)
Drop "doc for"
Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is
already stating that these are bindings and it is documentation.
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus
2023-05-13 9:17 ` [PATCH 1/2] dt-bindings: Add doc for " Krzysztof Kozlowski
@ 2023-05-13 10:21 ` Tianling Shen
0 siblings, 0 replies; 4+ messages in thread
From: Tianling Shen @ 2023-05-13 10:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Jagan Teki, Andy Yan, Chris Morgan, Nicolas Frattaroli,
Brian Norris, Maya Matuszczyk, Andrew Lunn, Michael Riesch,
Sebastian Reichel, Andrew Powers-Holmes, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Hi Krzysztof,
On Sat, May 13, 2023 at 5:17 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 13/05/2023 08:52, Tianling Shen wrote:
> > Add devicetree binding documentation for the NanoPi R2C Plus.
> >
> > Signed-off-by: Tianling Shen <cnsztl@gmail.com>
>
> subject: missing prefixes (arm: rockchip:)
>
> Drop "doc for"
>
> Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is
> already stating that these are bindings and it is documentation.
Thanks for the suggestion! Will send v2 for it.
Regards,
Tianling.
> > ---
> > Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-13 10:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-13 6:52 [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus Tianling Shen
2023-05-13 6:52 ` [PATCH 2/2] arm64: dts: rockchip: Add " Tianling Shen
2023-05-13 9:17 ` [PATCH 1/2] dt-bindings: Add doc for " Krzysztof Kozlowski
2023-05-13 10:21 ` Tianling Shen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).