From: Conor Dooley <conor@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Serge Semin <fancer.lancer@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-ide@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 4/6] dt-bindings: phy: rockchip: rk3588 has two reset lines
Date: Mon, 22 May 2023 20:24:40 +0100 [thread overview]
Message-ID: <20230522-blanching-unfiled-b89a4378622e@spud> (raw)
In-Reply-To: <20230522173423.64691-5-sebastian.reichel@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 1216 bytes --]
Hey Sebastian,
On Mon, May 22, 2023 at 07:34:21PM +0200, Sebastian Reichel wrote:
> The RK3588 has two reset lines for the combphy. One for the
> APB interface and one for the actual PHY.
But the 68 only has one? Should per-compatible enforcement be added
like you added for the clocks?
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> index 9ae514fa7533..82550a5c2ed5 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> @@ -31,8 +31,14 @@ properties:
> - const: pipe
>
> resets:
> + minItems: 1
> + maxItems: 2
> +
> + reset-names:
> + minItems: 1
> items:
> - - description: exclusive PHY reset line
> + - const: phy
> + - const: apb
>
> rockchip,enable-ssc:
> type: boolean
> --
> 2.39.2
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-05-22 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 17:34 [PATCH v2 0/6] Add RK3588 SATA support Sebastian Reichel
2023-05-22 17:34 ` [PATCH v2 1/6] dt-bindings: soc: rockchip: add rk3588 pipe-phy syscon Sebastian Reichel
2023-05-22 17:34 ` [PATCH v2 2/6] dt-bindings: ata: ahci: add RK3588 AHCI controller Sebastian Reichel
2023-05-22 19:33 ` Conor Dooley
2023-06-04 18:58 ` Serge Semin
2023-05-22 17:34 ` [PATCH v2 3/6] dt-bindings: ata: ahci: dwc: enforce rockchip clocks Sebastian Reichel
2023-06-04 19:11 ` Serge Semin
2023-05-22 17:34 ` [PATCH v2 4/6] dt-bindings: phy: rockchip: rk3588 has two reset lines Sebastian Reichel
2023-05-22 19:24 ` Conor Dooley [this message]
2023-05-22 17:34 ` [PATCH v2 5/6] arm64: dts: rockchip: rk3588: add combo PHYs Sebastian Reichel
2023-05-22 17:34 ` [PATCH v2 6/6] arm64: dts: rockchip: rk3588: add SATA support Sebastian Reichel
2023-05-31 11:35 ` [PATCH v2 0/6] Add RK3588 " Serge Semin
2023-06-06 17:07 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522-blanching-unfiled-b89a4378622e@spud \
--to=conor@kernel.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).