* [PATCH] media: rockchip: rga: use v4l2_m2m_buf_copy_metadata
@ 2023-05-23 9:03 Michael Tretter
2023-05-25 15:35 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tretter @ 2023-05-23 9:03 UTC (permalink / raw)
To: jacob-chen, ezequiel, mchehab, heiko
Cc: linux-media, linux-rockchip, linux-arm-kernel, kernel, m.tretter
The v4l2_m2m_buf_copy_metadata function correctly copies the metadata of
the buffer. Use that function instead of open-coding the metadata copy.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
drivers/media/platform/rockchip/rga/rga.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index 67dcf22e5ba3..e4b8ce9ab3c6 100644
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -76,10 +76,7 @@ static irqreturn_t rga_isr(int irq, void *prv)
WARN_ON(!src);
WARN_ON(!dst);
- dst->timecode = src->timecode;
- dst->vb2_buf.timestamp = src->vb2_buf.timestamp;
- dst->flags &= ~V4L2_BUF_FLAG_TSTAMP_SRC_MASK;
- dst->flags |= src->flags & V4L2_BUF_FLAG_TSTAMP_SRC_MASK;
+ v4l2_m2m_buf_copy_metadata(src, dst, true);
v4l2_m2m_buf_done(src, VB2_BUF_STATE_DONE);
v4l2_m2m_buf_done(dst, VB2_BUF_STATE_DONE);
--
2.39.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rockchip: rga: use v4l2_m2m_buf_copy_metadata
2023-05-23 9:03 [PATCH] media: rockchip: rga: use v4l2_m2m_buf_copy_metadata Michael Tretter
@ 2023-05-25 15:35 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2023-05-25 15:35 UTC (permalink / raw)
To: Michael Tretter, jacob-chen, ezequiel, mchehab, heiko
Cc: linux-media, linux-rockchip, linux-arm-kernel, kernel
Le mardi 23 mai 2023 à 11:03 +0200, Michael Tretter a écrit :
> The v4l2_m2m_buf_copy_metadata function correctly copies the metadata of
> the buffer. Use that function instead of open-coding the metadata copy.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/rockchip/rga/rga.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
> index 67dcf22e5ba3..e4b8ce9ab3c6 100644
> --- a/drivers/media/platform/rockchip/rga/rga.c
> +++ b/drivers/media/platform/rockchip/rga/rga.c
> @@ -76,10 +76,7 @@ static irqreturn_t rga_isr(int irq, void *prv)
> WARN_ON(!src);
> WARN_ON(!dst);
>
> - dst->timecode = src->timecode;
> - dst->vb2_buf.timestamp = src->vb2_buf.timestamp;
> - dst->flags &= ~V4L2_BUF_FLAG_TSTAMP_SRC_MASK;
> - dst->flags |= src->flags & V4L2_BUF_FLAG_TSTAMP_SRC_MASK;
> + v4l2_m2m_buf_copy_metadata(src, dst, true);
>
> v4l2_m2m_buf_done(src, VB2_BUF_STATE_DONE);
> v4l2_m2m_buf_done(dst, VB2_BUF_STATE_DONE);
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-25 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 9:03 [PATCH] media: rockchip: rga: use v4l2_m2m_buf_copy_metadata Michael Tretter
2023-05-25 15:35 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).