* [PATCH] media: staging: rkisp1: remove TODO item to document quantization handling
@ 2020-09-28 15:28 Dafna Hirschfeld
2020-10-14 20:30 ` Helen Koike
0 siblings, 1 reply; 2+ messages in thread
From: Dafna Hirschfeld @ 2020-09-28 15:28 UTC (permalink / raw)
To: linux-media
Cc: mchehab, dafna.hirschfeld, dafna3, tfiga, hverkuil,
linux-rockchip, helen.koike, laurent.pinchart, sakari.ailus,
kernel, ezequiel
The quantization handling is already documented
in the file rkisp1.rst so this item can be removed.
Fixes: 6616726907418 (media: staging: rkisp1: allow quantization setting by userspace on the isp source pad)
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/staging/media/rkisp1/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/rkisp1/TODO b/drivers/staging/media/rkisp1/TODO
index e7c8398fc2ce..d9360607fbfb 100644
--- a/drivers/staging/media/rkisp1/TODO
+++ b/drivers/staging/media/rkisp1/TODO
@@ -1,6 +1,5 @@
* Fix pad format size for statistics and parameters entities.
* Fix checkpatch errors.
-* Add uapi docs. Remember to add documentation of how quantization is handled.
* streaming paths (mainpath and selfpath) check if the other path is streaming
in several places of the code, review this, specially that it doesn't seem it
supports streaming from both paths at the same time.
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: staging: rkisp1: remove TODO item to document quantization handling
2020-09-28 15:28 [PATCH] media: staging: rkisp1: remove TODO item to document quantization handling Dafna Hirschfeld
@ 2020-10-14 20:30 ` Helen Koike
0 siblings, 0 replies; 2+ messages in thread
From: Helen Koike @ 2020-10-14 20:30 UTC (permalink / raw)
To: Dafna Hirschfeld, linux-media
Cc: mchehab, dafna3, tfiga, hverkuil, linux-rockchip,
laurent.pinchart, sakari.ailus, kernel, ezequiel
On 9/28/20 12:28 PM, Dafna Hirschfeld wrote:
> The quantization handling is already documented
> in the file rkisp1.rst so this item can be removed.
>
> Fixes: 6616726907418 (media: staging: rkisp1: allow quantization setting by userspace on the isp source pad)
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
> ---
> drivers/staging/media/rkisp1/TODO | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkisp1/TODO b/drivers/staging/media/rkisp1/TODO
> index e7c8398fc2ce..d9360607fbfb 100644
> --- a/drivers/staging/media/rkisp1/TODO
> +++ b/drivers/staging/media/rkisp1/TODO
> @@ -1,6 +1,5 @@
> * Fix pad format size for statistics and parameters entities.
> * Fix checkpatch errors.
> -* Add uapi docs. Remember to add documentation of how quantization is handled.
> * streaming paths (mainpath and selfpath) check if the other path is streaming
> in several places of the code, review this, specially that it doesn't seem it
> supports streaming from both paths at the same time.
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-14 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 15:28 [PATCH] media: staging: rkisp1: remove TODO item to document quantization handling Dafna Hirschfeld
2020-10-14 20:30 ` Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).