* [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs
@ 2022-08-14 4:08 Jarrah Gosbell
2022-08-14 13:12 ` Peter Geis
0 siblings, 1 reply; 3+ messages in thread
From: Jarrah Gosbell @ 2022-08-14 4:08 UTC (permalink / raw)
To: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab,
Heiko Stuebner, linux-media, linux-rockchip, linux-arm-kernel,
linux-kernel
Cc: phone-devel, Ondrej Jirman, Jarrah Gosbell
From: Ondrej Jirman <megi@xff.cz>
rga_parse_dt is missing a error return, so if some of the resources
return DEFER_PROBE, probe will succeed without these resources.
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Jarrah Gosbell <kernel@undef.tools>
---
drivers/media/platform/rockchip/rga/rga.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index 2f8df74ad0fd..b88dd7ed2036 100644
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -815,8 +815,10 @@ static int rga_probe(struct platform_device *pdev)
mutex_init(&rga->mutex);
ret = rga_parse_dt(rga);
- if (ret)
+ if (ret) {
dev_err(&pdev->dev, "Unable to parse OF data\n");
+ return ret;
+ }
pm_runtime_enable(rga->dev);
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs
2022-08-14 4:08 [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs Jarrah Gosbell
@ 2022-08-14 13:12 ` Peter Geis
2022-08-14 22:01 ` Jarrah Gosbell
0 siblings, 1 reply; 3+ messages in thread
From: Peter Geis @ 2022-08-14 13:12 UTC (permalink / raw)
To: Jarrah Gosbell
Cc: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab,
Heiko Stuebner, Linux Media Mailing List,
open list:ARM/Rockchip SoC...,
arm-mail-list, Linux Kernel Mailing List, phone-devel,
Ondrej Jirman
On Sun, Aug 14, 2022 at 6:10 AM Jarrah Gosbell <kernel@undef.tools> wrote:
>
> From: Ondrej Jirman <megi@xff.cz>
>
> rga_parse_dt is missing a error return, so if some of the resources
> return DEFER_PROBE, probe will succeed without these resources.
>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Jarrah Gosbell <kernel@undef.tools>
> ---
> drivers/media/platform/rockchip/rga/rga.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
> index 2f8df74ad0fd..b88dd7ed2036 100644
> --- a/drivers/media/platform/rockchip/rga/rga.c
> +++ b/drivers/media/platform/rockchip/rga/rga.c
> @@ -815,8 +815,10 @@ static int rga_probe(struct platform_device *pdev)
> mutex_init(&rga->mutex);
>
> ret = rga_parse_dt(rga);
> - if (ret)
> + if (ret) {
> dev_err(&pdev->dev, "Unable to parse OF data\n");
If this can return EPROBE_DEFER, shouldn't this be dev_err_probe
instead of dev_err?
> + return ret;
> + }
>
> pm_runtime_enable(rga->dev);
>
> --
> 2.35.1
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs
2022-08-14 13:12 ` Peter Geis
@ 2022-08-14 22:01 ` Jarrah Gosbell
0 siblings, 0 replies; 3+ messages in thread
From: Jarrah Gosbell @ 2022-08-14 22:01 UTC (permalink / raw)
To: Peter Geis
Cc: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab,
Heiko Stuebner, Linux Media Mailing List,
open list:ARM/Rockchip SoC...,
arm-mail-list, Linux Kernel Mailing List, phone-devel,
Ondrej Jirman
On 8/14/22 23:12, Peter Geis wrote:
>> ret = rga_parse_dt(rga);
>> - if (ret)
>> + if (ret) {
>> dev_err(&pdev->dev, "Unable to parse OF data\n");
> If this can return EPROBE_DEFER, shouldn't this be dev_err_probe
> instead of dev_err?
Looking into it that does make more sense. I suspect it wasn't done this
way originally because dev_err_probe isn't used elsewhere in rga.c. I'll
send a v2 with that change shortly.
Thanks for the review.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-14 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-14 4:08 [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs Jarrah Gosbell
2022-08-14 13:12 ` Peter Geis
2022-08-14 22:01 ` Jarrah Gosbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).