[PATCH 0/1] *** Make licence explicit for ssdd ***

[PATCH 0/1] *** Make licence explicit for ssdd ***

[John Kacur]

The default license for programs in the rt-tests suite is GPL version 2

Joe, I would like to get your signed-off-by for this, or please let us
know if this was not your intention.

thanks

John Kacur (1):
  rt-tests: ssdd: Add Licence information to ssdd

 src/ssdd/ssdd.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.20.1

[PATCH 1/1] rt-tests: ssdd: Add Licence information to ssdd

[John Kacur]

Add License Information to ssdd

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 src/ssdd/ssdd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/ssdd/ssdd.c b/src/ssdd/ssdd.c
index 4e293586526e..2c3a779be9f1 100644
--- a/src/ssdd/ssdd.c
+++ b/src/ssdd/ssdd.c
@@ -15,6 +15,13 @@
  *
  * The tracer waits on each PTRACE_SINGLESTEP with a waitpid(2)
  * and checks that waitpid's return values for correctness.
+ *
+ * This program was originally written by
+ * Joe Korty <joe.korty@concurrent-rt.com>
+ * This program is free software; you can redistribute it and / or modify
+ * it under the terms of the GNU General Public License Version 2
+ * of the licence, or (at your option) any later version
+ * see COPYING for more information
  */
 #include <stdio.h>
 #include <stdlib.h>
-- 
2.20.1

Re: [PATCH 0/1] *** Make licence explicit for ssdd ***

[Joe Korty]

On Fri, Jun 14, 2019 at 01:37:46PM +0200, John Kacur wrote:
> The default license for programs in the rt-tests suite is GPL version 2
> 
> Joe, I would like to get your signed-off-by for this, or please let us
> know if this was not your intention.
> 
> thanks
> 
> John Kacur (1):
>   rt-tests: ssdd: Add Licence information to ssdd
> 
>  src/ssdd/ssdd.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> -- 
> 2.20.1

Signed-off-by: Joe Korty <joe.korty@concurrent-rt.com>

Re: [PATCH 1/1] rt-tests: ssdd: Add Licence information to ssdd

[Sebastian Andrzej Siewior]

On 2019-06-14 13:37:47 [+0200], John Kacur wrote:
> Add License Information to ssdd

> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  src/ssdd/ssdd.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/ssdd/ssdd.c b/src/ssdd/ssdd.c
> index 4e293586526e..2c3a779be9f1 100644
> --- a/src/ssdd/ssdd.c
> +++ b/src/ssdd/ssdd.c
> @@ -15,6 +15,13 @@
>   *
>   * The tracer waits on each PTRACE_SINGLESTEP with a waitpid(2)
>   * and checks that waitpid's return values for correctness.
> + *
> + * This program was originally written by
> + * Joe Korty <joe.korty@concurrent-rt.com>
> + * This program is free software; you can redistribute it and / or modify
> + * it under the terms of the GNU General Public License Version 2
> + * of the licence, or (at your option) any later version
> + * see COPYING for more information

SPDX tags is not something that you have in rt-tests, right? Because a
standard tag would be kind of better than having yet another unique
version of text saying that it is GPLv2-or-later.

So you could reduce this to two lines:
- // SPDX-License-Identifier: GPL-2.0-or-later
  top

- Author: Joe Korty <joe.korty@concurrent-rt.com>
  Somewhere at top where the comment starts.

>   */
>  #include <stdio.h>
>  #include <stdlib.h>

Sebastian

Re: [PATCH 1/1] rt-tests: ssdd: Add Licence information to ssdd

[John Kacur]

On Fri, 14 Jun 2019, Sebastian Andrzej Siewior wrote:

> On 2019-06-14 13:37:47 [+0200], John Kacur wrote:
> > Add License Information to ssdd
> 
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> >  src/ssdd/ssdd.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/src/ssdd/ssdd.c b/src/ssdd/ssdd.c
> > index 4e293586526e..2c3a779be9f1 100644
> > --- a/src/ssdd/ssdd.c
> > +++ b/src/ssdd/ssdd.c
> > @@ -15,6 +15,13 @@
> >   *
> >   * The tracer waits on each PTRACE_SINGLESTEP with a waitpid(2)
> >   * and checks that waitpid's return values for correctness.
> > + *
> > + * This program was originally written by
> > + * Joe Korty <joe.korty@concurrent-rt.com>
> > + * This program is free software; you can redistribute it and / or modify
> > + * it under the terms of the GNU General Public License Version 2
> > + * of the licence, or (at your option) any later version
> > + * see COPYING for more information
> 
> SPDX tags is not something that you have in rt-tests, right? Because a
> standard tag would be kind of better than having yet another unique
> version of text saying that it is GPLv2-or-later.
> 
> So you could reduce this to two lines:
> - // SPDX-License-Identifier: GPL-2.0-or-later
>   top
> 
> - Author: Joe Korty <joe.korty@concurrent-rt.com>
>   Somewhere at top where the comment starts.
> 
> >   */
> >  #include <stdio.h>
> >  #include <stdlib.h>
> 
> Sebastian
> 

Thanks for the tip Sebastian, looks good to me,
I'm looking into doing this.

John