Linux-rt-users archive on lore.kernel.org
 help / color / Atom feed
* [RT PATCH] sched/deadline: Make inactive timer run in hardirq context
@ 2019-07-31 10:37 Juri Lelli
  2019-07-31 11:56 ` Daniel Bristot de Oliveira
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Juri Lelli @ 2019-07-31 10:37 UTC (permalink / raw)
  To: tglx, bigeasy, rostedt
  Cc: linux-rt-users, peterz, linux-kernel, bristot, williams, Juri Lelli

SCHED_DEADLINE inactive timer needs to run in hardirq context (as
dl_task_timer already does).

Make it HRTIMER_MODE_REL_HARD.

Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
---
Hi,

Both v4.19-rt and v5.2-rt need this.

Mainline "sched: Mark hrtimers to expire in hard interrupt context"
series needs this as well (20190726185753.077004842@linutronix.de in
particular). Do I need to send out a separate patch for it?

Best,

Juri
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 1794e152d888..0889674b8915 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1292,7 +1292,7 @@ void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se)
 {
 	struct hrtimer *timer = &dl_se->inactive_timer;
 
-	hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
+	hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
 	timer->function = inactive_task_timer;
 }
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq context
  2019-07-31 10:37 [RT PATCH] sched/deadline: Make inactive timer run in hardirq context Juri Lelli
@ 2019-07-31 11:56 ` Daniel Bristot de Oliveira
  2019-07-31 14:25 ` Clark Williams
  2019-08-13 13:09 ` Sebastian Andrzej Siewior
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel Bristot de Oliveira @ 2019-07-31 11:56 UTC (permalink / raw)
  To: Juri Lelli, tglx, bigeasy, rostedt
  Cc: linux-rt-users, peterz, linux-kernel, bristot, williams



On 31/07/2019 12:37, Juri Lelli wrote:
> SCHED_DEADLINE inactive timer needs to run in hardirq context (as
> dl_task_timer already does).
> 
> Make it HRTIMER_MODE_REL_HARD.
> 
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>

Acked-by: Daniel Bristot de Oliveira <bristot@redhat.com>

-- Daniel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq context
  2019-07-31 10:37 [RT PATCH] sched/deadline: Make inactive timer run in hardirq context Juri Lelli
  2019-07-31 11:56 ` Daniel Bristot de Oliveira
@ 2019-07-31 14:25 ` Clark Williams
  2019-08-13 13:09 ` Sebastian Andrzej Siewior
  2 siblings, 0 replies; 5+ messages in thread
From: Clark Williams @ 2019-07-31 14:25 UTC (permalink / raw)
  To: Juri Lelli
  Cc: tglx, bigeasy, rostedt, linux-rt-users, peterz, linux-kernel, bristot

On Wed, 31 Jul 2019 12:37:15 +0200
Juri Lelli <juri.lelli@redhat.com> wrote:

> SCHED_DEADLINE inactive timer needs to run in hardirq context (as
> dl_task_timer already does).
> 
> Make it HRTIMER_MODE_REL_HARD.
> 
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
> ---
> Hi,
> 
> Both v4.19-rt and v5.2-rt need this.
> 
> Mainline "sched: Mark hrtimers to expire in hard interrupt context"
> series needs this as well (20190726185753.077004842@linutronix.de in
> particular). Do I need to send out a separate patch for it?
> 
> Best,
> 
> Juri
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 1794e152d888..0889674b8915 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1292,7 +1292,7 @@ void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se)
>  {
>  	struct hrtimer *timer = &dl_se->inactive_timer;
>  
> -	hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> +	hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
>  	timer->function = inactive_task_timer;
>  }
>  
> -- 
> 2.17.2
> 
Acked-by: Clark Williams <williams@redhat.com>

-- 
The United States Coast Guard
Ruining Natural Selection since 1790

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq context
  2019-07-31 10:37 [RT PATCH] sched/deadline: Make inactive timer run in hardirq context Juri Lelli
  2019-07-31 11:56 ` Daniel Bristot de Oliveira
  2019-07-31 14:25 ` Clark Williams
@ 2019-08-13 13:09 ` Sebastian Andrzej Siewior
  2019-08-13 13:19   ` Juri Lelli
  2 siblings, 1 reply; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2019-08-13 13:09 UTC (permalink / raw)
  To: Juri Lelli
  Cc: tglx, rostedt, linux-rt-users, peterz, linux-kernel, bristot, williams

On 2019-07-31 12:37:15 [+0200], Juri Lelli wrote:
> Hi,
Hi,

> Both v4.19-rt and v5.2-rt need this.
> 
> Mainline "sched: Mark hrtimers to expire in hard interrupt context"
> series needs this as well (20190726185753.077004842@linutronix.de in
> particular). Do I need to send out a separate patch for it?

time will show. I applied it now to my tree and will ping tglx later…

> Best,
> 
> Juri

Sebastian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq context
  2019-08-13 13:09 ` Sebastian Andrzej Siewior
@ 2019-08-13 13:19   ` Juri Lelli
  0 siblings, 0 replies; 5+ messages in thread
From: Juri Lelli @ 2019-08-13 13:19 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: tglx, rostedt, linux-rt-users, peterz, linux-kernel, bristot, williams

On 13/08/19 15:09, Sebastian Andrzej Siewior wrote:
> On 2019-07-31 12:37:15 [+0200], Juri Lelli wrote:
> > Hi,
> Hi,
> 
> > Both v4.19-rt and v5.2-rt need this.
> > 
> > Mainline "sched: Mark hrtimers to expire in hard interrupt context"
> > series needs this as well (20190726185753.077004842@linutronix.de in
> > particular). Do I need to send out a separate patch for it?
> 
> time will show. I applied it now to my tree and will ping tglx later…

Thanks. tglx actually already applied it to tip (with a fixup):

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=4394ba872c36255d25c6bde151b061f04655ebfb

Best,

Juri

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 10:37 [RT PATCH] sched/deadline: Make inactive timer run in hardirq context Juri Lelli
2019-07-31 11:56 ` Daniel Bristot de Oliveira
2019-07-31 14:25 ` Clark Williams
2019-08-13 13:09 ` Sebastian Andrzej Siewior
2019-08-13 13:19   ` Juri Lelli

Linux-rt-users archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org linux-rt-users@archiver.kernel.org
	public-inbox-index linux-rt-users


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/ public-inbox