* [PATCH] genirq: replace notify with old_notify in irq_set_affinity_notifier()
@ 2019-09-28 15:19 Ivan Safonov
2019-09-28 21:25 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Safonov @ 2019-09-28 15:19 UTC (permalink / raw)
To: linux-kernel
Cc: Sebastian Andrzej Siewior, Steven Rostedt, Thomas Gleixner,
linux-rt-users, Ivan Safonov
This patch is for Linux 4.19 with a RT patch.
The second 'if' block does not check notify for NULL,
this leads to a system crash.
Most likely, there is a typo here.
With old_notify system works as expected.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
---
kernel/irq/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 290cd520dba1..79a7072dfb3c 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -412,7 +412,7 @@ irq_set_affinity_notifier(unsigned int irq, struct irq_affinity_notify *notify)
if (old_notify) {
#ifdef CONFIG_PREEMPT_RT_BASE
- kthread_cancel_work_sync(¬ify->work);
+ kthread_cancel_work_sync(&old_notify->work);
#else
cancel_work_sync(&old_notify->work);
#endif
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] genirq: replace notify with old_notify in irq_set_affinity_notifier()
2019-09-28 15:19 [PATCH] genirq: replace notify with old_notify in irq_set_affinity_notifier() Ivan Safonov
@ 2019-09-28 21:25 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2019-09-28 21:25 UTC (permalink / raw)
To: Ivan Safonov
Cc: linux-kernel, Sebastian Andrzej Siewior, Thomas Gleixner, linux-rt-users
On Sat, 28 Sep 2019 18:19:20 +0300
Ivan Safonov <insafonov@gmail.com> wrote:
> This patch is for Linux 4.19 with a RT patch.
>
> The second 'if' block does not check notify for NULL,
> this leads to a system crash.
>
> Most likely, there is a typo here.
>
> With old_notify system works as expected.
>
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
> ---
> kernel/irq/manage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 290cd520dba1..79a7072dfb3c 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -412,7 +412,7 @@ irq_set_affinity_notifier(unsigned int irq, struct irq_affinity_notify *notify)
>
> if (old_notify) {
> #ifdef CONFIG_PREEMPT_RT_BASE
> - kthread_cancel_work_sync(¬ify->work);
> + kthread_cancel_work_sync(&old_notify->work);
Thanks for the patch, but I currently have an RFC out that rewrites all
this code. I'm hoping to apply the RFC patch next week.
-- Steve
> #else
> cancel_work_sync(&old_notify->work);
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-28 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-28 15:19 [PATCH] genirq: replace notify with old_notify in irq_set_affinity_notifier() Ivan Safonov
2019-09-28 21:25 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).