From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org,
Woojung Huh <woojung.huh@microchip.com>,
Marc Zyngier <maz@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Stefan Wahren <wahrenst@gmx.net>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling
Date: Tue, 22 Oct 2019 10:17:47 -0700 [thread overview]
Message-ID: <20191022101747.001b6d06@cakuba.netronome.com> (raw)
In-Reply-To: <20191018131532.dsfhyiilsi7cy4cm@linutronix.de>
On Fri, 18 Oct 2019 15:15:32 +0200, Sebastian Andrzej Siewior wrote:
> On 2019-10-18 10:28:17 [+0200], Daniel Wagner wrote:
> > handle_simple_irq() expect interrupts to be disabled. The USB
> > framework is using threaded interrupts, which implies that interrupts
> > are re-enabled as soon as it has run.
>
> Without threading interrupts, this is invoked in pure softirq context
> since commit ed194d1367698 ("usb: core: remove local_irq_save() around
> ->complete() handler") where the local_irq_disable() has been removed.
>
> This is probably not a problem because the lock is never observed with
> in IRQ context.
>
> Wouldn't handle_nested_irq() work here instead of the simple thingy?
Daniel could you try this suggestion? Would it work?
I'm not sure we are at the stage yet where "doesn't work on -rt" is
sufficient reason to revert a working upstream patch. Please correct
me if I'm wrong.
next prev parent reply other threads:[~2019-10-22 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:28 [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling Daniel Wagner
2019-10-18 11:02 ` Marc Zyngier
2019-10-18 13:15 ` Sebastian Andrzej Siewior
2019-10-22 17:17 ` Jakub Kicinski [this message]
2019-10-22 17:34 ` Marc Zyngier
2019-10-23 7:47 ` Daniel Wagner
2019-10-23 8:06 ` Daniel Wagner
2019-10-24 10:43 ` Sebastian Andrzej Siewior
2019-10-24 11:06 ` Daniel Wagner
2019-10-24 14:12 ` Daniel Wagner
2019-10-24 17:25 ` Stefan Wahren
2019-10-25 7:33 ` Daniel Wagner
2019-10-24 21:57 ` David Miller
2019-10-25 7:36 ` Sebastian Andrzej Siewior
2019-10-25 6:00 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022101747.001b6d06@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wahrenst@gmx.net \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).