From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: David Miller <davem@davemloft.net>
Cc: dwagner@suse.de, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
woojung.huh@microchip.com, maz@kernel.org, andrew@lunn.ch,
wahrenst@gmx.net, Jisheng.Zhang@synaptics.com,
tglx@linutronix.de
Subject: Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling
Date: Fri, 25 Oct 2019 09:36:42 +0200 [thread overview]
Message-ID: <20191025073642.3ov2lwo2sr4nrdzn@linutronix.de> (raw)
In-Reply-To: <20191024.145716.1208414850964996816.davem@davemloft.net>
On 2019-10-24 14:57:16 [-0700], David Miller wrote:
> From: Daniel Wagner <dwagner@suse.de>
> Date: Fri, 18 Oct 2019 10:28:17 +0200
>
> > handle_simple_irq() expect interrupts to be disabled. The USB
> > framework is using threaded interrupts, which implies that interrupts
> > are re-enabled as soon as it has run.
> ...
>
> Where are we with this patch? I'm tossing it.
>
> It seems Sebastian made a suggestion, someone else said his suggestion
> should be tried, then everything died.
>
> Please follow up and post when something is ready.
My suggestion with the nested-handler was nonsense. The suggestion with
the local_irq_disable() before invoking generic_handle_irq() did avoid
the warning but the NFS-root was not stable (and Daniel reported a lot
of USB interrupts coming which indicates that the interrupt-handler is
not acknowledging the interrupt properly).
It works by reverting the IRQ-domain code as this patch does. "Works" as
in "no warnings" and "NFS-root looks stable".
You have two ACKs on that patch. I could ask Daniel to repost the patch
with additional informations.
My last information from Daniel was that the rpi tree works and I'm not
sure if he is looking for the missing ingredient or preferring the
removal of the non-working code.
Sebastian
next prev parent reply other threads:[~2019-10-25 7:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:28 [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling Daniel Wagner
2019-10-18 11:02 ` Marc Zyngier
2019-10-18 13:15 ` Sebastian Andrzej Siewior
2019-10-22 17:17 ` Jakub Kicinski
2019-10-22 17:34 ` Marc Zyngier
2019-10-23 7:47 ` Daniel Wagner
2019-10-23 8:06 ` Daniel Wagner
2019-10-24 10:43 ` Sebastian Andrzej Siewior
2019-10-24 11:06 ` Daniel Wagner
2019-10-24 14:12 ` Daniel Wagner
2019-10-24 17:25 ` Stefan Wahren
2019-10-25 7:33 ` Daniel Wagner
2019-10-24 21:57 ` David Miller
2019-10-25 7:36 ` Sebastian Andrzej Siewior [this message]
2019-10-25 6:00 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025073642.3ov2lwo2sr4nrdzn@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Jisheng.Zhang@synaptics.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wahrenst@gmx.net \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).