* [PATCH] pi_stress: limit the number of inversion groups to the number of online cores
@ 2020-07-21 21:10 Clark Williams
2020-07-21 22:29 ` John Kacur
0 siblings, 1 reply; 2+ messages in thread
From: Clark Williams @ 2020-07-21 21:10 UTC (permalink / raw)
To: jkacur; +Cc: linux-rt-users
Each inversion group is three SCHED_FIFO threads, so the chances of more groups
than online cores actually getting to run is very slim. Limit the number of
groups requested to be <= the number of online cpus.
Signed-off-by: Clark Williams <williams@redhat.com>
---
src/pi_tests/pi_stress.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
index 0ed844c636cd..ce446d4ea037 100644
--- a/src/pi_tests/pi_stress.c
+++ b/src/pi_tests/pi_stress.c
@@ -1327,6 +1327,12 @@ void process_command_line(int argc, char **argv)
break;
case 'g':
ngroups = strtol(optarg, NULL, 10);
+ if (ngroups > num_processors) {
+ pi_error("the number of groups cannot exceed "
+ "the number of online processors (%d)\n",
+ num_processors);
+ exit(-1);
+ }
pi_info("number of groups set to %d\n", ngroups);
break;
case 'r':
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pi_stress: limit the number of inversion groups to the number of online cores
2020-07-21 21:10 [PATCH] pi_stress: limit the number of inversion groups to the number of online cores Clark Williams
@ 2020-07-21 22:29 ` John Kacur
0 siblings, 0 replies; 2+ messages in thread
From: John Kacur @ 2020-07-21 22:29 UTC (permalink / raw)
To: Clark Williams; +Cc: linux-rt-users
On Tue, 21 Jul 2020, Clark Williams wrote:
> Each inversion group is three SCHED_FIFO threads, so the chances of more groups
> than online cores actually getting to run is very slim. Limit the number of
> groups requested to be <= the number of online cpus.
>
> Signed-off-by: Clark Williams <williams@redhat.com>
> ---
> src/pi_tests/pi_stress.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
> index 0ed844c636cd..ce446d4ea037 100644
> --- a/src/pi_tests/pi_stress.c
> +++ b/src/pi_tests/pi_stress.c
> @@ -1327,6 +1327,12 @@ void process_command_line(int argc, char **argv)
> break;
> case 'g':
> ngroups = strtol(optarg, NULL, 10);
> + if (ngroups > num_processors) {
> + pi_error("the number of groups cannot exceed "
> + "the number of online processors (%d)\n",
> + num_processors);
> + exit(-1);
> + }
> pi_info("number of groups set to %d\n", ngroups);
> break;
> case 'r':
> --
> 2.26.2
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-21 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 21:10 [PATCH] pi_stress: limit the number of inversion groups to the number of online cores Clark Williams
2020-07-21 22:29 ` John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).